[v8-dev] Re: store ics for js api accessors (issue 23549019)

2013-09-06 Thread dcarney
Committed patchset #3 manually as r16571 (presubmit successful). https://codereview.chromium.org/23549019/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: store ics for js api accessors (issue 23549019)

2013-09-05 Thread dcarney
yep, will add tests https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (left): https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359 src/ia32/stub-cache-ia32.cc:1359: ASSERT(call_optimization.is_simple_a

[v8-dev] Re: store ics for js api accessors (issue 23549019)

2013-09-05 Thread mstarzinger
LGTM. Can we haz test coverage? https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (left): https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359 src/ia32/stub-cache-ia32.cc:1359: ASSERT(call_optimization