not lgtm!
Let's not have commented out code in public API.
Thanks for fixing in follow-up CL.
https://codereview.chromium.org/24023004/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24023004/diff/1/include/v8.h#newcode552
include/v8.h:552: // V8_INLINE(~Persistent()) {
Since it is a public API, please remove completely instead of commenting
out (just for the push)
https://codereview.chromium.org/24023004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
