[v8-dev] Re: v8_external_snapshot target visible only when using v8_use_external_startup_data (issue 643163002 by ba...@chromium.org)

2014-10-13 Thread rmcilroy
Committed patchset #2 (id:60001) manually as 24550 (presubmit successful). https://codereview.chromium.org/643163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: v8_external_snapshot target visible only when using v8_use_external_startup_data (issue 643163002 by ba...@chromium.org)

2014-10-11 Thread rmcilroy
LGTM, thanks Andre. https://codereview.chromium.org/643163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: v8_external_snapshot target visible only when using v8_use_external_startup_data (issue 643163002 by ba...@chromium.org)

2014-10-10 Thread rmcilroy
Please update the description to mention the reason why this is a problem currently. Also please add the tracking bug in a BUG= line. https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right):

[v8-dev] Re: v8_external_snapshot target visible only when using v8_use_external_startup_data (issue 643163002 by ba...@chromium.org)

2014-10-10 Thread baixo
Addressed Ross' comment. https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp#newcode1405 tools/gyp/v8.gyp:1405: [ 'v8_use_external_startup_data==1', { On 2014/10/10 16:31:33, rmcilroy