Reviewers: Reid Kleckner, Benedikt Meurer,
Message:
This should fix link errors such as
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds/441/steps/gclient%20runhooks/logs/stdio
Description:
Set V8_HAS_DECLSPEC_SELECTANY for clang-cl
This macro is used for defining static data members with
STATIC_CONST_MEMBER_DEFINITION. Clang-cl mimics MSVC's
behaviour here, so it also needs __declspec(selectany).
This change was prompted by Clang r237787 which changed
a bug where Clang would previously not emit symbols for
some static data members.
BUG=82385
Please review this at https://codereview.chromium.org/1145213004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -0 lines):
M include/v8config.h
Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index
991a43afd445c066eda7d5fc6e5d56209a5a0cf4..8c8eb4d0419550bd53e595a99371dbd741870ddd
100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -201,6 +201,7 @@
# define V8_CC_GNU 1
#elif defined(_MSC_VER) // Clang in cl mode.
# define V8_CC_MSVC 1
+# define V8_HAS_DECLSPEC_SELECTANY 1
#endif
// Clang defines __alignof__ as alias for __alignof
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
