It seem I got a clean bill of health locally after fixing the obvious bug I
had:
>>> Running tests for x64.debug
>>> Running with test processors
[70:10|% 96|+ 18516|- 0]: Done
>>> 19139 base tests produced 18516 (96%) non-filtered tests
>>> 18516
Oops, yeah.
Locally I already have related failed DCHECKs so this ain't gonna be pretty.
# Fatal error in ../../src/sandbox/sandboxed-pointer-inl.h, line 35
# Check failed: GetProcessWideSandbox()->Contains(pointer).
#
#
#
#FailureMessage Object: 0x7fad9b7e54f8
C stack trace
I guess you meant to link to https://crrev.com/c/4896678. I triggered
dry-runs, let's see what happens.
On Wed, Sep 27, 2023 at 2:12 PM Aapo Alasuutari
wrote:
> Thank you for the response!
>
> Hopefully this was then much easier than I even expected. I opened this
> CL:
Thank you for the response!
Hopefully this was then much easier than I even expected. I opened this
CL: https://groups.google.com/g/v8-dev/c/wuncGizO1EU
Unfortunately I'm not a dry-runner so I cannot start try-bots on this
myself. I'll try running some tests locally at least.
-Aapo
On
This is the place where we store the special "empty backing store buffer"
in the ArrayBuffer if the passed BackingStore is empty:
https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/js-array-buffer.cc;l=82;drc=57bf7660f3e50a0f68f329059f0dff8f641effc4
In a non-sandbox build,
