[v8-users] Re: When is SetSecondPassCallback need to be called?

2018-07-26 Thread fengxingren
Thanks for your reply. But I can't find any other conversations by searching with keywords such like "SetSecondPassCallback", "phantom handles". If two Persistent handles refer to the same v8 object, weak callback will be called twice. So wrappable object will be double-deleted either using

[v8-users] Re: [blink-dev] Intent to Implement and Ship: rename Intl.DateTimeFormat.prototype.formatToParts type "dayperiod" to "dayPeriod"

2018-07-26 Thread Adam Klein
+Jungshik and Dan, who I believe worked on this feature in V8 originally. I'm curious if they know how it happened that this ended up with the wrong capitalization. I appreciate the outreach you've done to fix uses in the wild, but it still scares me a little bit to make such a hard-breaking chang

[v8-users] Re: [blink-dev] Intent to Implement and Ship: rename Intl.DateTimeFormat.prototype.formatToParts type "dayperiod" to "dayPeriod"

2018-07-26 Thread PhistucK
I misremembered formatToParts as a relatively recent feature, but now I see that the intent I remembered was actually discussing NumberFormat. DateTimeFormat did not seem to have an intent on blink-dev (but I see that it did on v8-users). https://www.chromestatus.com/features/6319456309477376 says