Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
Found the root cause. I was setting a named interceptor on an instance template with both the propertyGetter and propertySetter being null: NamedPropertyHandlerConfiguration config(propertyGetter, propertySetter); instanceTemplate->SetHandler(config); I am not sure how how this affects V8 and

Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
I have pretty much narrowed it down and will send a repro once I remove all the noise from my project On Thursday, September 12, 2019 at 5:45:19 PM UTC+3, Jakob Kummerow wrote: > > CC author of that commit. > > Darin, do you have a full repro you can share? That would be useful for > debugging.

Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Jakob Kummerow
CC author of that commit. Darin, do you have a full repro you can share? That would be useful for debugging. On Thu, Sep 12, 2019 at 4:36 PM Darin Dimitrov wrote: > I am embedding v8 in my iOS application and calling some js function: > > Local callback = ... > > std::vector> v8Args = ... > >

[v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
I am embedding v8 in my iOS application and calling some js function: Local callback = ... std::vector> v8Args = ... Local result; TryCatch tc(isolate); callback->Call(context, thiz, (*int*)v8Args.size(), v8Args.data()).ToLocal (&result)); This code works pretty fine but starting from this c

Re: [v8-users] Calling function from shared library in V8 7.7.299.11

2019-09-12 Thread Darin Dimitrov
It might be, but normally I build my .so with the exact same custom libc++ which I use to build my android app. I am also able to perform other operations on the object such as ->Get On Thursday, September 12, 2019 at 4:16:00 PM UTC+3, Jakob Gruber wrote: > > Could this be another libcxx mismatc

Re: [v8-users] Calling function from shared library in V8 7.7.299.11

2019-09-12 Thread Jakob Gruber
Could this be another libcxx mismatch issue and 7.7 just exposes it incidentally? On Thu, Sep 12, 2019 at 2:54 PM Darin Dimitrov wrote: > I am cross compiling V8 for android and I have created a shared library > containing a simple function which adds some property to a provided object: > > exte

[v8-users] Calling function from shared library in V8 7.7.299.11

2019-09-12 Thread Darin Dimitrov
I am cross compiling V8 for android and I have created a shared library containing a simple function which adds some property to a provided object: extern "C" void MyFunc(Isolate* isolate, Local& obj) { Local context = isolate->GetCurrentContext(); obj->Set(context, v8::String::NewFromUtf