Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-17 Thread Jakob Gruber
It'd be interesting to find out what more. We should not attempt to jump into runtime-allocated executable code in jitless mode. If you have a repro, please open a bug and I will take a look. On Thu, Sep 12, 2019 at 5:45 PM Darin Dimitrov wrote: > Found the root cause. > > I was setting a named

Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
Found the root cause. I was setting a named interceptor on an instance template with both the propertyGetter and propertySetter being null: NamedPropertyHandlerConfiguration config(propertyGetter, propertySetter); instanceTemplate->SetHandler(config); I am not sure how how this affects V8 and

Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
I have pretty much narrowed it down and will send a repro once I remove all the noise from my project On Thursday, September 12, 2019 at 5:45:19 PM UTC+3, Jakob Kummerow wrote: > > CC author of that commit. > > Darin, do you have a full repro you can share? That would be useful for > debugging.

Re: [v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Jakob Kummerow
CC author of that commit. Darin, do you have a full repro you can share? That would be useful for debugging. On Thu, Sep 12, 2019 at 4:36 PM Darin Dimitrov wrote: > I am embedding v8 in my iOS application and calling some js function: > > Local callback = ... > > std::vector> v8Args = ... > >

[v8-users] Calling js functions in jitless (iOS)

2019-09-12 Thread Darin Dimitrov
I am embedding v8 in my iOS application and calling some js function: Local callback = ... std::vector> v8Args = ... Local result; TryCatch tc(isolate); callback->Call(context, thiz, (*int*)v8Args.size(), v8Args.data()).ToLocal (&result)); This code works pretty fine but starting from this c