I still need the third LGTM from anAPI owner (sffc is not an API owner)
On Tue, Jan 7, 2020 at 8:06 AM Shane Carr <s...@google.com> wrote: > LGTM > > The proposal is Stage 3. It was officially promoted here > <https://github.com/tc39/proposals/commit/9717f0dc700d17c464964f796275cd024f168cc7#diff-738bf168ca04c8cfc21d0903825cb5c9> > . > > On Tue, Jan 7, 2020 at 1:49 AM امیرحسین <amirhosinf...@gmail.com> > wrote: > >> >> >> >> >> از گوشی هوشمند Samsung Galaxy ارسال شده است. >> >> >> -------- پیام اصلی -------- >> از: امیرحسین <amirhosinf...@gmail.com> >> تاریخ: ۲۰۲۰/۱/۷ ۳:۴۴ (GMT+03:30) >> گیرنده: PhistucK <phist...@gmail.com>, Frank Tang <ft...@chromium.org> >> گیرنده کپی: amirhosinf...@gmail.com, Nebojša Ćirić <c...@google.com>, >> blink-api-owners-discuss <blink-api-owners-disc...@chromium.org>, >> v8-...@googlegroups.com, Jungshik Shin <js...@chromium.org>, Shane Carr < >> s...@google.com>, v8-users <v8-users@googlegroups.com>, Daniel Bratell < >> bratel...@gmail.com>, Jakob Kummerow <jkumme...@chromium.org>, Mathias >> Bynens <m...@google.com>, Frank Yung-Fong Tang <ft...@google.com>, Chris >> Harrelson <chris...@chromium.org>, blink-dev <blink-...@chromium.org>, >> Yoav Weiss <y...@yoav.ws>, Adam Klein <ad...@chromium.org> >> موضوع FW: Re: [blink-dev] Intent to Ship: Intl.DisplayNames >> >> >> >> >> >> از گوشی هوشمند Samsung Galaxy ارسال شده است. >> >> >> -------- پیام اصلی -------- >> از: امیرحسین <amirhosinf...@gmail.com> >> تاریخ: ۲۰۲۰/۱/۷ ۳:۴۳ (GMT+03:30) >> گیرنده: Frank Tang <ft...@chromium.org>, PhistucK <phist...@gmail.com> >> گیرنده کپی: amirhosinf...@gmail.com, Yoav Weiss <y...@yoav.ws>, Chris >> Harrelson <chris...@chromium.org>, blink-api-owners-discuss < >> blink-api-owners-disc...@chromium.org>, Daniel Bratell < >> bratel...@gmail.com>, v8-...@googlegroups.com, v8-users < >> v8-users@googlegroups.com>, Adam Klein <ad...@chromium.org>, blink-dev < >> blink-...@chromium.org>, Mathias Bynens <m...@google.com>, Frank >> Yung-Fong Tang <ft...@google.com>, Shane Carr <s...@google.com>, Nebojša >> Ćirić <c...@google.com>, Jakob Kummerow <jkumme...@chromium.org>, >> Jungshik Shin <js...@chromium.org> >> موضوع Re: [blink-dev] Intent to Ship: Intl.DisplayNames >> >> >> >> >> >> از گوشی هوشمند Samsung Galaxy ارسال شده است. >> >> >> -------- پیام اصلی -------- >> از: Frank Tang <ft...@chromium.org> >> تاریخ: ۲۰۲۰/۱/۷ ۲:۰۶ (GMT+03:30) >> گیرنده: PhistucK <phist...@gmail.com> >> گیرنده کپی: Yoav Weiss <y...@yoav.ws>, Chris Harrelson < >> chris...@chromium.org>, blink-api-owners-discuss < >> blink-api-owners-disc...@chromium.org>, Daniel Bratell < >> bratel...@gmail.com>, v8-...@googlegroups.com, v8-users < >> v8-users@googlegroups.com>, Adam Klein <ad...@chromium.org>, blink-dev < >> blink-...@chromium.org>, Mathias Bynens <m...@google.com>, Frank >> Yung-Fong Tang <ft...@google.com>, Shane Carr <s...@google.com>, Nebojša >> Ćirić <c...@google.com>, Jakob Kummerow <jkumme...@chromium.org>, >> Jungshik Shin <js...@chromium.org> >> موضوع Re: [blink-dev] Intent to Ship: Intl.DisplayNames >> >> I double check with BFS (Bradley Farias <https://github.com/bmeck> bmeck >> <https://github.com/bmeck> bradley.m...@gmail.com) >> He commented on >> >> https://github.com/tc39/proposal-intl-displaynames/issues/38#issuecomment-571320389 >> >> as >> "LGTM spec wise, there are a couple of README PRs outstanding it looks >> like though; nothing to block on" >> >> I apologize for my previous misunderstanding of the conclusion in Oct >> TC39 meeting and declare the reaching of Stage 3 w/o double check with BFS. >> Now the pending clause of Stage 3 is fulfilled. >> >> >> >> >> >> >> >> On Mon, Jan 6, 2020 at 10:16 AM PhistucK <phist...@gmail.com> wrote: >> >>> It is pending review, so not going to stage 3 just yet. >>> >>> ☆*PhistucK* >>> >>> >>> On Mon, Jan 6, 2020 at 8:07 PM Frank Tang <ft...@chromium.org> wrote: >>> >>>> >>>> >>>> On Mon, Jan 6, 2020 at 10:05 AM Frank Tang <ft...@chromium.org> wrote: >>>> >>>>> >>>>> >>>>> On Sun, Jan 5, 2020 at 11:21 PM Yoav Weiss <y...@yoav.ws> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, Jan 3, 2020 at 7:49 PM Frank Tang <ft...@chromium.org> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 2, 2020 at 10:34 AM Frank Tang <ft...@chromium.org> >>>>>>> wrote: >>>>>>> >>>>>>>> still need one more >>>>>>>> >>>>>>>> On Fri, Dec 27, 2019 at 12:12 PM Chris Harrelson < >>>>>>>> chris...@chromium.org> wrote: >>>>>>>> >>>>>>>>> LGTM2 >>>>>>>>> >>>>>>>>> On Fri, Dec 27, 2019 at 12:01 PM Daniel Bratell < >>>>>>>>> bratel...@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> LGTM1 >>>>>>>>>> >>>>>>>>>> /Daniel >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2019-12-26 23:03, Frank Tang wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Contact emails ft...@chromium.org,js...@chromium.org Explainer >>>>>>>>>> https://github.com/tc39/proposal-intl-displaynames Spec >>>>>>>>>> https://tc39.github.io/proposal-intl-displaynames/ TAG review A >>>>>>>>>> small JavaScript features, a TAG review is not required, as TC39 >>>>>>>>>> already >>>>>>>>>> provide significant technical oversight. Summary Provides a new >>>>>>>>>> API to get localized names of language, region, script, currency >>>>>>>>>> codes of >>>>>>>>>> international standard as well as commonly used names of date fields >>>>>>>>>> and >>>>>>>>>> symbols. Link to “Intent to Prototype” blink-dev discussion >>>>>>>>>> https://mail.google.com/mail/u/0/#search/Intl.DisplayNames+Intent/KtbxLwgxBjLmZRWGMwZfjnVwNFvdndwvBq >>>>>>>>>> Risks >>>>>>>>>> Interoperability and Compatibility This is a new API. It is >>>>>>>>>> currently under TC39 Stage 3. *Firefox*: No public signals >>>>>>>>>> >>>>>>>>>> for mozilla , Zibi from mozilla were the original spec champion . >>>>> They filed tracking bug in >>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1557727 >>>>> >>>>>> *Edge*: No public signals *Safari*: No public signals *Web >>>>>>>>>> developers*: No signals >>>>>>>>>> >>>>>>>>>> I'm assuming that at least some of the above supported the >>>>>> proposal in order for it to make it to stage 3... >>>>>> >>>>> >>>>> TC39 meeting not to propose to Stage 3 >>>>> >>>>> https://github.com/tc39/notes/blob/master/meetings/2019-10/october-2.md#intldisplaynames >>>>> >>>> >>>> sorry. Typo. I mean to write " TC39 meeting note to..." not "TC39 >>>> meeting not to..." fat finger missed a 'e' before I sent the reply. >>>> >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>>> Ergonomics The implementation depend on pre-existing functions in >>>>>>>>>> already linked in ICU library During the prototype phrase we >>>>>>>>>> identify no >>>>>>>>>> small size increase impact since all the strings were already >>>>>>>>>> included to >>>>>>>>>> support other Chrome functionality. >>>>>>>>>> >>>>>>>>>> The "Ergonomics" section refers to developer ergonomics of the >>>>>> feature itself and how web developers would use it, not to the ergonomics >>>>>> of Chromium engineers developing it. >>>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>>> Activation Web developers could use the API immediately upon our >>>>>>>>>> shipment. Security Web developers could use the API immediately >>>>>>>>>> upon our shipment. >>>>>>>>>> >>>>>>>>>> The "Security" section refers to the security considerations of >>>>>> the feature, and whether we believe it puts users at risk. I believe the >>>>>> answer is no, but can you confirm? >>>>>> >>>>> >>>>> Agree. The answer is NO >>>>> >>>>>> Debuggability Nothing special. Will this feature be supported on all >>>>>>>>>> six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and >>>>>>>>>> Android >>>>>>>>>> WebView)? Yes It will be supported on all platform. Is this >>>>>>>>>> feature fully tested by web-platform-tests >>>>>>>>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md> >>>>>>>>>> ? Yes Tests were added into test262 before shipping it in >>>>>>>>>> chrome. Tracking bug >>>>>>>>>> https://bugs.chromium.org/p/v8/issues/detail?id=8703 Link to >>>>>>>>>> entry on the Chrome Platform Status >>>>>>>>>> https://www.chromestatus.com/feature/4965112605573120 >>>>>>>>>> This intent message was generated by Chrome Platform Status >>>>>>>>>> <https://www.chromestatus.com/>. >>>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8S-wQiUw6WXMp9VN5A%2BwKVCHvtv%3DHJd8WE7OS%3D%2B7Bqnw%40mail.gmail.com >>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8S-wQiUw6WXMp9VN5A%2BwKVCHvtv%3DHJd8WE7OS%3D%2B7Bqnw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>> . >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>> Google Groups "blink-dev" group. >>>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0b437b38-9b1a-3af6-b783-b8ff76ca1f01%40gmail.com >>>>>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/0b437b38-9b1a-3af6-b783-b8ff76ca1f01%40gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>> . >>>>>>>>>> >>>>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "blink-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to blink-dev+unsubscr...@chromium.org. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8NOkN1N6i9_dXqTvO8CSD7wiJqh9BmG%3Dd4ckEKtV6e6g%40mail.gmail.com >>>>>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL8NOkN1N6i9_dXqTvO8CSD7wiJqh9BmG%3Dd4ckEKtV6e6g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-api-owners-discuss" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-api-owners-discuss+unsubscr...@chromium.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CAOcELL_ThP62DJwjD3DvcX-K80pd68tJX3ufm84jBiTmq%2Bc_tA%40mail.gmail.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CAOcELL_ThP62DJwjD3DvcX-K80pd68tJX3ufm84jBiTmq%2Bc_tA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL-7L9R8%2BfMKhsJu59RpKAfxUNdahH1Z%3DHWg-T_s71Wspg%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOcELL-7L9R8%2BfMKhsJu59RpKAfxUNdahH1Z%3DHWg-T_s71Wspg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAOcELL-FPs50sgUdJmvQA_inWFb3C1NhVNZm_dnzohUy8mLnSg%40mail.gmail.com.
