[v8-users] Re: Intend to Ship: Locale sensitive BigInt.prototype.toLocaleString & allow Intl.NumberFormat format/formatToParts to take BigInt

2019-04-18 Thread Frank Tang
Sorry, correction here for my incorrect "example". It should be I made some mistake in my copy/paste Example 12345678901234567890n.toLocaleString("de") // "12.345.678.901.234.567.890" 12345678901234567890n.toLocaleString("en") // "12,345,678,901,234,567,890"

[v8-users] Re: Intend to Ship: Locale sensitive BigInt.prototype.toLocaleString & allow Intl.NumberFormat format/formatToParts to take BigInt

2019-04-18 Thread Adam Klein
LGTM2 On Thu, Apr 18, 2019 at 4:21 PM Sathya Gunasekaran wrote: > LGTM > > On Thu, Apr 18, 2019 at 4:02 PM Frank Tang wrote: > >> *Intend to Ship: Locale sensitive BigInt.prototype.toLocaleString & allow >> Intl.NumberFormat format/formatToParts to take BigInt* >> >> >> Spec >> >>

[v8-users] Re: Intend to Ship: Locale sensitive BigInt.prototype.toLocaleString & allow Intl.NumberFormat format/formatToParts to take BigInt

2019-04-18 Thread Sathya Gunasekaran
LGTM On Thu, Apr 18, 2019 at 4:02 PM Frank Tang wrote: > *Intend to Ship: Locale sensitive BigInt.prototype.toLocaleString & allow > Intl.NumberFormat format/formatToParts to take BigInt* > > > Spec > > https://github.com/tc39/ecma402/pull/236 > > > Summary > > A Stage 3 Pull Request to change