Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-18 Thread 'Erik Arvidsson' via v8-users
We settled the caching of the template pattern object today. The frozen array is cached based on the global and the strings building up the literal. That means that two literals in different location but exactly the same value, in the same global, will share the frozen object. On Thu, Nov 13, 2014

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-13 Thread 'Erik Arvidsson' via v8-users
FWIW, IE11 developer preview does cache the call site object. It seems to do so based on location in the source. Two identical call sites leads to two objects. Two evals leads to same call site object. On Fri, Nov 7, 2014 at 11:51 AM, 'Andreas Rossberg' via v8-users < v8-users@googlegroups.com> wr

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-07 Thread 'Andreas Rossberg' via v8-users
It is fine to move ahead as far as possible anyway, and implement caching once the spec is resolved. We don't plan to stage or ship before that, obviously. /Andreas -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message becau

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-07 Thread Dmitry Lomov
LGTM to implement non-tagged template literals, tagged template literals pend spec issue resolution. On Tue, Nov 4, 2014 at 1:33 PM, 'Andreas Rossberg' via v8-users < v8-users@googlegroups.com> wrote: > On 4 November 2014 12:53, Dmitry Lomov wrote: > > On Tue, Nov 4, 2014 at 12:25 PM, Dmitry Lom

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-04 Thread 'Andreas Rossberg' via v8-users
On 4 November 2014 12:53, Dmitry Lomov wrote: > On Tue, Nov 4, 2014 at 12:25 PM, Dmitry Lomov wrote: >> On Tue, Nov 4, 2014 at 11:56 AM, 'Andreas Rossberg' via v8-users >> wrote: >>> >>> On 4 November 2014 10:16, Dmitry Lomov wrote: >>> > On Tue, Nov 4, 2014 at 8:43 AM, 'Andreas Rossberg' via v

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-04 Thread Dmitry Lomov
On Tue, Nov 4, 2014 at 12:25 PM, Dmitry Lomov wrote: > > > On Tue, Nov 4, 2014 at 11:56 AM, 'Andreas Rossberg' via v8-users < > v8-users@googlegroups.com> wrote: > >> On 4 November 2014 10:16, Dmitry Lomov wrote: >> > On Tue, Nov 4, 2014 at 8:43 AM, 'Andreas Rossberg' via v8-users >> > wrote: >

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-04 Thread Dmitry Lomov
On Tue, Nov 4, 2014 at 11:56 AM, 'Andreas Rossberg' via v8-users < v8-users@googlegroups.com> wrote: > On 4 November 2014 10:16, Dmitry Lomov wrote: > > On Tue, Nov 4, 2014 at 8:43 AM, 'Andreas Rossberg' via v8-users > > wrote: > >> > >> On 3 November 2014 16:58, Andreas Rossberg wrote: > >> >

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-04 Thread 'Andreas Rossberg' via v8-users
On 4 November 2014 10:16, Dmitry Lomov wrote: > On Tue, Nov 4, 2014 at 8:43 AM, 'Andreas Rossberg' via v8-users > wrote: >> >> On 3 November 2014 16:58, Andreas Rossberg wrote: >> > On 3 November 2014 16:47, Caitlin Potter wrote: >> >> It looks like there is machinery in `Scope` for storing int

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-04 Thread Dmitry Lomov
On Tue, Nov 4, 2014 at 8:43 AM, 'Andreas Rossberg' via v8-users < v8-users@googlegroups.com> wrote: > On 3 November 2014 16:58, Andreas Rossberg wrote: > > On 3 November 2014 16:47, Caitlin Potter wrote: > >> It looks like there is machinery in `Scope` for storing internal > variables. > >> Coul

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-03 Thread 'Andreas Rossberg' via v8-users
On 3 November 2014 16:58, Andreas Rossberg wrote: > On 3 November 2014 16:47, Caitlin Potter wrote: >> It looks like there is machinery in `Scope` for storing internal variables. >> Could we not grant each tagged template a custom ID, in order for it to look >> up the appropriate callSiteObj in s

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-03 Thread 'Andreas Rossberg' via v8-users
On 3 November 2014 16:47, Caitlin Potter wrote: > It looks like there is machinery in `Scope` for storing internal variables. > Could we not grant each tagged template a custom ID, in order for it to look > up the appropriate callSiteObj in scope, and store a new internal value > there if one does

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-03 Thread Caitlin Potter
It looks like there is machinery in `Scope` for storing internal variables. Could we not grant each tagged template a custom ID, in order for it to look up the appropriate callSiteObj in scope, and store a new internal value there if one does not already exist? -- -- v8-users mailing list v8-

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-03 Thread Dmitry Lomov
On Sun, Nov 2, 2014 at 2:12 AM, 'Erik Arvidsson' via v8-users < v8-users@googlegroups.com> wrote: > FWIW, Chakra is implementing this too: > https://status.modern.ie/templatestringses6?term=template%20strings > > My main concern is the tagged template. We clearly do not want to ship > this without

[v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-02 Thread Caitlin Potter
Oh my god, did I really link to the wrong CL in that link... the text is right but the URL is wrong! Should be https://codereview.chromium.org/663683006/ On Saturday, 1 November 2014 02:59:14 UTC-4, Caitlin Potter wrote: > > > *Design Doc / Patch* > > https://codereview.chromium.org/663683006/ <

Re: [v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-01 Thread 'Erik Arvidsson' via v8-users
FWIW, Chakra is implementing this too: https://status.modern.ie/templatestringses6?term=template%20strings My main concern is the tagged template. We clearly do not want to ship this without doing the caching which is required to get the correct semantics. The spec is underspecified how this is su

[v8-users] Re: Intent to Implement ES6 Template Literals

2014-11-01 Thread Caitlin Potter
On Saturday, 1 November 2014 02:59:14 UTC-4, Caitlin Potter wrote: > > There are no other implementations currently. There is not currently a bug > to implement on SpiderMonkey, nor JSC. > > This was copy-pasted from my previous intent-to-implement thread, ignore this =) -- -- v8-users mailin