[PATCH] Don't put POLLHUP i .events

2012-10-01 Thread Tollef Fog Heen
POLLHUP is always checked for, and is output-only on Linux and OSX, so avoid putting it in the list of events we check for. --- bin/varnishtest/vtc_http.c|2 +- bin/varnishtest/vtc_varnish.c | 10 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/bin/varnishtest/

[PATCH 11/13] Generalize the ban reporting to the stevedores using their API. This way any stevedore interested in new bans can request to be notified (not just the persistent).

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/cache/cache.h|2 +- bin/varnishd/cache/cache_ban.c|6 -- bin/varnishd/storage/stevedore.c |9 + bin/varnishd/storage/storage.h|3 +++ bin/varnishd/storage/storage_persistent.c |7 +-- 5 files chan

[PATCH 10/13] smp_thread() stopping

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent.c | 43 ++--- bin/varnishd/storage/storage_persistent.h |2 ++ 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/bin/varnishd/storage/storage_persistent.c b/bin/varnishd/storage/storage_persistent.c index 744

[PATCH 09/13] Add a signal_close callback method to stevedores, which can be used to signal background threads to stop in preparation for the coming close callback.

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/stevedore.c |9 + bin/varnishd/storage/storage.h |2 ++ 2 files changed, 11 insertions(+) diff --git a/bin/varnishd/storage/stevedore.c b/bin/varnishd/storage/stevedore.c index cd1a316..fa5a683 100644 --- a/bin/varnishd/storage/stevedore.c +++ b/bin/varn

[PATCH 12/13] Also report dropped bans to the stevedores.

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/cache/cache.h |1 + bin/varnishd/cache/cache_ban.c |6 ++ bin/varnishd/storage/stevedore.c | 10 ++ bin/varnishd/storage/storage.h |3 +++ 4 files changed, 20 insertions(+) diff --git a/bin/varnishd/cache/cache.h b/bin/varnishd/cache/cache.h in

[PATCH 13/13] Add consistency checks between the ban lists at startup

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/bin/varnishd/storage/storage_persistent.c b/bin/varnishd/storage/storage_persistent.c index f38aba6..8f12c2e 100644 --- a/bin/varnishd/storage/storage_persistent.c

[PATCH 01/13] Add a EXP_NukeLRU() function to nuke an entire LRU structure at a time.

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/cache/cache.h|1 + bin/varnishd/cache/cache_expire.c | 59 + 2 files changed, 60 insertions(+) diff --git a/bin/varnishd/cache/cache.h b/bin/varnishd/cache/cache.h index 15db84c..7533782 100644 --- a/bin/varnishd/cache/cache.h +++

[PATCH 04/13] Sync the complete sign area on smp_sync_sign

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent_subr.c |2 +- include/persistent.h |2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/bin/varnishd/storage/storage_persistent_subr.c b/bin/varnishd/storage/storage_persistent_subr.c index f7c748e..9933

[PATCH 05/13] Round to page sizes on signature syncs

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent.h |1 + bin/varnishd/storage/storage_persistent_subr.c | 27 ++-- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/bin/varnishd/storage/storage_persistent.h b/bin/varnishd/storage/storage_persistent.h index

[PATCH 07/13] Don't exit on full silo

2012-10-01 Thread Martin Blix Grydeland
This then also breaks the previous expectation that cur_seg would always be non-NULL. Change the code to take this into account. --- bin/varnishd/storage/storage_persistent.c | 24 +--- bin/varnishd/storage/storage_persistent_silo.c | 71 2 files changed, 54 i

[PATCH 02/13] Create and use a smp_signspace structure to have range checking on the growing signed data structures.

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent.c | 23 +++--- bin/varnishd/storage/storage_persistent.h | 35 +++-- bin/varnishd/storage/storage_persistent_silo.c | 10 +-- bin/varnishd/storage/storage_persistent_subr.c | 90 4 files changed, 126 inserti

[PATCH 03/13] Add smp_copy_signspace() and smp_trunc_signspace() utility functions

2012-10-01 Thread Martin Blix Grydeland
smp_copy_signspace() will copy the sign data of one space onto another. smp_trunc_signspace() will truncate the signed space to len bytes and resign the space. --- bin/varnishd/storage/storage_persistent.h |3 +++ bin/varnishd/storage/storage_persistent_subr.c | 31

[PATCH 06/13] Free the LRU object and set free_offset when dropping empty segments in smp_close_seg()

2012-10-01 Thread Martin Blix Grydeland
Fixes: #1146 --- bin/varnishd/storage/storage_persistent_silo.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bin/varnishd/storage/storage_persistent_silo.c b/bin/varnishd/storage/storage_persistent_silo.c index 6ed80d2..d433cde 100644 --- a/bin/varnishd/storage/sto

[PATCH 08/13] Add an assert that segment rounding doesn't overstep our previous allocation calculations.

2012-10-01 Thread Martin Blix Grydeland
--- bin/varnishd/storage/storage_persistent_silo.c |1 + 1 file changed, 1 insertion(+) diff --git a/bin/varnishd/storage/storage_persistent_silo.c b/bin/varnishd/storage/storage_persistent_silo.c index 0014647..cc4a060 100644 --- a/bin/varnishd/storage/storage_persistent_silo.c +++ b/bin/va

Re: RFC: new vcl_lookup{} proposal

2012-10-01 Thread Martin Blix Grydeland
* Sorry about the early incomplete version of this email. I sent it unfinished by mistake * As we are moving more logic from varnishd into VCL, I believe some rethinking with how we deal with the default_vcl logic might be in order. This to make it easier to make the easy VCL changes and keep the

Re: RFC: new vcl_lookup{} proposal

2012-10-01 Thread Martin Blix Grydeland
As we are moving more logic from varnishd into VCL, I believe some rethinking with how we deal with the default_vcl logic might be in order. This to make it easier to make the easy VCL changes and keep the default logic around still. A common vcl error I have observed is where you want to match on