Re: IPv[46] parsing

2015-10-28 Thread Tollef Fog Heen
is empty). If string contains :: and [] → parse as v6 with port If string contains 7 :s and [], parse as v6 with port Yes, this means you can't use 127.1 and similar as valid IPs. Don't do that, then. IMO, etc. -- Tollef Fog Heen | Engineer fastly.com | @fastly | Linkedin ___

Re: On tests

2015-03-09 Thread Tollef Fog Heen
2015-03-09 12:25 GMT+01:00 Per Buer : > On Mon, Mar 9, 2015 at 11:49 AM, Poul-Henning Kamp > wrote: >> >> >Let me know if I should commit this and start replacement of the current >> >> >way tests are run. >> >> So my first question is: Why don't we just teach varnishtest to do this ? > > Becau

Re: [master] c816cc1 Remove statoverride on uninstall/purge.

2015-02-06 Thread Tollef Fog Heen
2015-02-05 13:51 GMT+01:00 Lasse Karstensen : > commit c816cc198a3bea643a9f8b54eaed81d8884cae23 > Author: Lasse Karstensen > Date: Thu Feb 5 13:49:40 2015 +0100 > > Remove statoverride on uninstall/purge. > > This is added during package installation, and was previously not > cleane

Re: varnish-dev Digest, Vol 96, Issue 14

2014-03-25 Thread Tollef Fog Heen
2014-03-24 13:18 GMT+01:00 Martin Blix Grydeland : > Agreed on the eye strain, though I chose to put it as the first field > followed by a colon specifically to mimic the way we log HTTP headers. This > because the log query language has a concept of a key-value record parsing > that can then a

Re: [PATCH] [EXPERIMENTAL] autocrap autohardening

2014-03-21 Thread Tollef Fog Heen
2014-03-19 20:45 GMT+01:00 Nils Goroll : > Here's an update of the patch I assume you've smoke-tested this, looks good to me from a quick skim. - Tollef ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mail

Re: [PATCH] create a hard dependency on some curses library

2014-03-21 Thread Tollef Fog Heen
2014-03-19 20:15 GMT+01:00 Nils Goroll : > what it really boils down to is Tollef's summary > > well, we require pcre, readline and rst2man to build.. I don't think > ncurses is excessive. Generally looks good to me. I think the XXX comments should be kept, they're still relevant.

Re: Via

2014-03-20 Thread Tollef Fog Heen
2014-03-20 8:37 GMT+01:00 Geoff Simmons : > I haven't found a way to read the RFC in such a way that a Via header > should be added -- all of my attempted parsings say that a hop should > appended to an existing header. Unless of course I've missed it, or > unless they use the word "append" in an

Re: [master] 6737d14 Ignore various autogenerated files

2014-02-25 Thread Tollef Fog Heen
2014-02-25 16:20 GMT+01:00 Per Buer : > It's clean now. Git has stopped complaining. Show we remove the two lines > from gitignore? > Yes, please. > - Tollfe >> > > Is this your USA-friendly name now? :-) > :-P Tollef actually works surprisingly well in English considering its roots. - Tolle

Re: [master] 6737d14 Ignore various autogenerated files

2014-02-25 Thread Tollef Fog Heen
2014-02-25 16:01 GMT+01:00 Per Buer : > On Tue, Feb 25, 2014 at 2:26 PM, Tollef Fog Heen wrote: > >> 2014-02-24 9:42 GMT+01:00 Per Buer : >> >>> # Various auto-tools artifacts >>> @@ -78,6 +79,8 @@ cscope.*out >>> /man/vsc2rst >>> /m

Re: [master] 6737d14 Ignore various autogenerated files

2014-02-25 Thread Tollef Fog Heen
2014-02-24 9:42 GMT+01:00 Per Buer : > # Various auto-tools artifacts > @@ -78,6 +79,8 @@ cscope.*out > /man/vsc2rst > /man/*.7 > /man/*.1 > +/bin/*/*.1 > +/bin/*/*.rst > None of those should be generated any longer. Which files do you have there, and do they reappear if you clean your sourc

Re: varnishctl?

2014-01-30 Thread Tollef Fog Heen
]] Dridi Boukelmoune > On Tue, Jan 28, 2014 at 8:07 AM, Tollef Fog Heen > wrote: > > ]] Dridi Boukelmoune > > > > > I find the idea compelling, but I've had issues with apachectl. > > > > Your problems seem to be "apachectl has bugs", an

Re: [PATCH] [EXPERIMENTAL] autocrap autohardening

2014-01-30 Thread Tollef Fog Heen
uppercase those too, please? -- Tollef Fog Heen Technical lead | Varnish Software AS 📞: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: varnishtest documentation

2014-01-30 Thread Tollef Fog Heen
top-level architectural overview: > > Thanks for the overview. That helps with a few things that I had not > understood before. I'll probably put together a pull request for > this architecture overview (I'll try to fit it into the existing > varnishtest page) and vtc commands. And

Re: [PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-30 Thread Tollef Fog Heen
]] Nils Goroll > >d9492da540430103b9dcd6844eb59b508c061d66 effectively breaks builds with gcc > >3.4. > > ... only when developer warnings are enabled. > > Patch attached. I think this looks reasonable, so feel free to commit. -- Tollef Fog Heen Technical lead | Var

Re: Set bereq.http.connection:close in vcl_pipe by default

2014-01-27 Thread Tollef Fog Heen
opposed to adding the header, but I think it should then be done in the C code running before vcl_pipe so you can remove it if you need to. Adding it to the built-in vcl_pipe means the only way to get rid of it is to return early, something we tell people to avoid for other VCL functions. -- Tolle

Re: varnishctl?

2014-01-27 Thread Tollef Fog Heen
]] Dridi Boukelmoune > Hi, > > On Mon, Jan 27, 2014 at 2:57 PM, Tollef Fog Heen > wrote: > > Hi all, > > > > This got triggered by bug #1415 which asks for init scripts to be able > > to verify you're not just breaking your cache on a restart. I ca

varnishctl?

2014-01-27 Thread Tollef Fog Heen
o extend varnishd to be able to reload the VCL somehow and make it able to read parameters from a file. I'm willing to work on 1. I think it'd be fairly easy to do and keeps the existing tools doing one thing well. Input, opinions, etc? -- Tollef Fog Heen Technical lead | Varnish Soft

Re: More on the HAProxy proxy protocol

2013-12-04 Thread Tollef Fog Heen
t; I'm somewhat tempted to make client.identity a STRING, rather than > an IP, to make it clear to people that running it through an ACL > is a bad idea. client.identity is already a string, and I don't think we should set it from X-F-F, but rather just client.ip. It can be triv

[PATCH 1/3] Define a few names in the pkg-config data

2013-07-31 Thread Tollef Fog Heen
--- varnishapi.pc.in |2 ++ 1 file changed, 2 insertions(+) diff --git a/varnishapi.pc.in b/varnishapi.pc.in index 7f5036a..059725e 100644 --- a/varnishapi.pc.in +++ b/varnishapi.pc.in @@ -9,7 +9,9 @@ datarootdir=@datarootdir@ datadir=@datadir@ pkgdatadir=${datadir}/@PACKAGE@ pkgdatainclud

[PATCH 2/3] Use /usr/bin/env instead of hard coding python location

2013-07-31 Thread Tollef Fog Heen
--- lib/libvcl/vmodtool.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libvcl/vmodtool.py b/lib/libvcl/vmodtool.py index 259f97f..d99d8c6 100755 --- a/lib/libvcl/vmodtool.py +++ b/lib/libvcl/vmodtool.py @@ -1,4 +1,4 @@ -#!/usr/local/bin/python +#!/usr/bin/env python

[PATCH 3/3] Install autoconf macros

2013-07-31 Thread Tollef Fog Heen
. +# +# Author: Tollef Fog Heen +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +#notice, this list of conditions and

Re: Reminder to change the default Varnish version in trac bugs from "trunk" to "unknown"

2013-07-02 Thread Tollef Fog Heen
;unknown" value by default to make it clear when the reporter > hasn't changed the field. I've added an "unknown" value to the list and made it the default now. Sorry about not getting around to this earlier. -- Tollef Fog Heen Technical l

[PATCH] Return an error on duplicated Host headers

2013-05-06 Thread Tollef Fog Heen
--- bin/varnishd/cache/cache.h |1 + bin/varnishd/cache/cache_http.c|2 +- bin/varnishd/cache/cache_http1_proto.c | 29 + 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/bin/varnishd/cache/cache.h b/bin/varnishd/cache/cache.

Re: [PATCH 5/8] Return 503 when Vary-headers references header names more than 127 (out limit) characters long.

2013-04-10 Thread Tollef Fog Heen
Are there real world examples of non-insane uses of headers longer > than 127 characters ? For the contents of headers? Sure, cookies spring to mind. The the names of header fields? Not that I know of- -- Tollef Fog Heen Technical lead | Varnish Soft

[PATCH] Set the waiter pipe as non-blocking and record overflows

2013-04-09 Thread Tollef Fog Heen
Fixes #1285 --- bin/varnishd/cache/cache.h|1 + bin/varnishd/waiter/cache_waiter.c| 14 ++ bin/varnishd/waiter/cache_waiter_epoll.c | 24 bin/varnishd/waiter/cache_waiter_kqueue.c | 15 ++- bin/varnishd/waiter/cach

[PATCH] Set the waiter pipe as non-blocking and record overflows

2013-04-08 Thread Tollef Fog Heen
Fixes #1285 --- I wonder if it would make sense to pull the "set this fd as non-blocking" into a libvarnish function. Tested (make check) on Linux with epoll and poll. Not tested on FreeBSD and Solaris. bin/varnishd/waiter/cache_waiter_epoll.c | 19 --- bin/varnishd/waiter

Re: full disclosure reports

2013-03-11 Thread Tollef Fog Heen
> Or god forbid some funny person sets a response code over 999. (oh is > that new disclosure?) Are you referring to #506, fixed in 2009? -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varni

Re: [PATCH] Fix for the typos

2013-03-11 Thread Tollef Fog Heen
enerated, so that bit went away automatically. -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: [PATCH] Make std.collect() also work for resp.http and bereq.http.

2013-02-22 Thread Tollef Fog Heen
]] Dag Haavi Finstad > See attached patch. Thx, applied. -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/li

[PATCH] Tickle old, idle workers to give up their VCLs

2013-02-20 Thread Tollef Fog Heen
--- bin/varnishd/cache/cache_pool.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/bin/varnishd/cache/cache_pool.c b/bin/varnishd/cache/cache_pool.c index 4e7bd7c..c19c1fe 100644 --- a/bin/varnishd/cache/cache_pool.c +++ b/bin/varnishd/cache/cache_pool.c @@ -364,6 +364,16 @@ po

Re: [PATCH] Get rid of ban_url/ban.url

2012-11-29 Thread Tollef Fog Heen
]] Poul-Henning Kamp > > In message <20121126082805.gc31...@err.no>, Tollef Fog Heen writes: > > >It hasn't really been marked as deprecated > > well, we removed it from the on-line help... Seems to still be listed on https://www.varnish-cache

Re: [PATCH] Get rid of ban_url/ban.url

2012-11-26 Thread Tollef Fog Heen
o, go for it... It hasn't really been marked as deprecated (so we could still allow it, just remove the docs for it) and then remove the implementation in the next version. ban() (or rather, purge()) got added to some 2.x version, at which point purge.url/ban.url was slightly deprecated. -- Tollef

[PATCH] Get rid of ban_url/ban.url

2012-11-23 Thread Tollef Fog Heen
ban.url is confusing as it takes a regular expression rather than a fixed string, so get rid of it in favour of people being explicit and using ban req.url ~ /foo --- bin/varnishd/cache/cache_ban.c | 16 bin/varnishd/mgt/mgt_param.c |2 +- bin/varnishtest/tests

[PATCH] Allow multiple identical backend addresses

2012-11-20 Thread Tollef Fog Heen
In some cases, lookups for a given host name returns the same address multiple times. Allow this, but ignore any duplicate addresses. --- lib/libvcl/vcc_backend.c | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/lib/libvcl/vcc_backend.

Re: PATCH: fix some warnings during configure/compilation

2012-11-19 Thread Tollef Fog Heen
]] Federico G. Schwindt > The diff below fixes one warning during configure and two during compilation > on OpenBSD (and maybe elsewhere): Thanks, committed. -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websit

Re: Trouble understanding why Varnish retries on backend timeouts

2012-11-12 Thread Tollef Fog Heen
org/lists/pipermail/varnish-dev/2011-August/006857.html We should probably apply this. Martin, do you want to resubmit it (possibly after cleaning it up)? -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! _

[PATCH] Add softban support

2012-10-31 Thread Tollef Fog Heen
Soft bans are like normal bans, but they are subject to grace per usual rules. --- bin/varnishd/cache/cache.h |1 + bin/varnishd/cache/cache_ban.c | 58 + bin/varnishd/cache/cache_vrt.c |6 ++-- bin/varnishtest/tests/s4.vtc | 47 +++

Re: PATCH: document beresp.http.header

2012-10-31 Thread Tollef Fog Heen
Thanks, applied -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: Varnish 2.x Debugging

2012-10-31 Thread Tollef Fog Heen
a look at man vcl. Cheers, -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: PATCH: remove non-ascii characters and don't manually split words.

2012-10-31 Thread Tollef Fog Heen
Thanks, applied -- Tollef Fog Heen Technical lead | Varnish Software AS t: +47 21 98 92 64 We Make Websites Fly! ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

[PATCH 1/2] Expose exp->entered via macros

2012-10-15 Thread Tollef Fog Heen
--- bin/varnishd/cache/cache.h|2 ++ bin/varnishd/cache/cache_expire.c |1 + 2 files changed, 3 insertions(+) diff --git a/bin/varnishd/cache/cache.h b/bin/varnishd/cache/cache.h index 6d4fe86..1c6a833 100644 --- a/bin/varnishd/cache/cache.h +++ b/bin/varnishd/cache/cache.h @@ -78

[PATCH 2/2] Add softban support

2012-10-15 Thread Tollef Fog Heen
Soft bans are like normal bans, but they are subject to grace per usual rules. --- bin/varnishd/cache/cache.h |1 + bin/varnishd/cache/cache_ban.c | 56 bin/varnishd/cache/cache_vrt.c |6 ++-- bin/varnishtest/tests/s4.vtc | 47

RFC: bans with grace (aka softbans)

2012-10-10 Thread Tollef Fog Heen
. Comments are welcome, -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

[PATCH] Don't put POLLHUP i .events

2012-10-01 Thread Tollef Fog Heen
POLLHUP is always checked for, and is output-only on Linux and OSX, so avoid putting it in the list of events we check for. --- bin/varnishtest/vtc_http.c|2 +- bin/varnishtest/vtc_varnish.c | 10 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/bin/varnishtest/

Re: Tracking patches

2012-09-28 Thread Tollef Fog Heen
7;m not sure I want to move the project to github and their pull ideas, but we should now at least be able to track patches on https://www.varnish-cache.org/patchwork/project/varnish-cache/list/ Sorry about this taking a very long time to get implemented. -- Tollef Fog Heen Technical lead, Varnish

Re: Minimum version of curl for libvmod-curl

2012-05-09 Thread Tollef Fog Heen
]] Delacroix, Gauthier Hi, sorry for not seeing your email earlier. > Which is the minimum version to use ? (I have 7.15.5 on CentOS 5) Seems like the timeout options were added in 7.16.2 -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92

Re: Patch set for aiding in vmod building against installed (and packaged) Varnish instances

2012-05-09 Thread Tollef Fog Heen
body else. -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: a typo?

2012-04-10 Thread Tollef Fog Heen
]] qwe 64 > varnish-3.0.2 > > include/http_headers.h line 66: > HTTPH("Content-Langugae",H_Content_Language,2, 0, 0, > 0, 0)/* RFC2616 14.12 */ > is it a typo? Indeed, it is, thanks, fixed now. -- Tollef Fog

Re: [PATCH] add a least-connection director

2012-04-10 Thread Tollef Fog Heen
]] Federico G. Schwindt Hi, > No, will check tonight. Was fine last time I checked. have you had any progress on this? I'd like to get this merged if possible. :-) Regards, -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21

Re: [PATCH] add a least-connection director

2012-03-29 Thread Tollef Fog Heen
0 CLI - Rd ping v1 48.3 vsl| 0 CLI - Wr 200 19 PONG 1333009648 1.0 v1 51.3 vsl| 0 CLI - Rd ping v1 51.3 vsl| 0 CLI - Wr 200 19 PONG 1333009651 1.0 v1 54.3 vsl| 0 CLI - Rd ping v1 54.3 vsl| 0 CLI

Re: Size issues in ncsa log with gzip

2012-02-21 Thread Tollef Fog Heen
f its "Content-Length" value ? > It seems obvious that varnish do not know the size of the gzipped > object, but could there be a way to "store" the real size with the > object itself ? Assuming your backend sends content-length you can store it as X-Content-Length and

Re: chunked response within first session

2012-02-21 Thread Tollef Fog Heen
]] Jammy > I noticed that in the fetch session the chunked responses would be aggregated > and returned. Yes this is normal. > Is there any concern about this behavior? Can we return chunked response even > if in the fetch session? Why would you want to do that? -- Tol

Re: deactivate obj updates

2012-02-13 Thread Tollef Fog Heen
shouldn't cause any significant churn, I believe. -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: [PATCH 1/3] Fix up some sess_workspace leftovers

2012-02-13 Thread Tollef Fog Heen
master, but no worries about that.) Thanks and sorry for the delay in getting this applied! -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org

vcl_error with streaming

2012-01-12 Thread Tollef Fog Heen
e and does not go through vcl_deliver, vcl_fetch or any other place. Does this sound roughly sane (and could Kristian and Martin please correct any inaccuracies)? -- Tollef Fog Heen Technical lead, Varnish Software t: +47 21 98 92 64 ___ varnish-dev ma

Re: Varnish 3.1 becoming 4.0 instead (?)

2011-12-15 Thread Tollef Fog Heen
]] Poul-Henning Kamp > In message <8762hpc1up@qurzaw.varnish-software.com>, Tollef Fog Heen > writes > : > > >> >As long as you can detect whether a 503 is internally generated or not, > >> >that's fine. > >> > >> That is a

Re: Varnish 3.1 becoming 4.0 instead (?)

2011-12-09 Thread Tollef Fog Heen
]] "Poul-Henning Kamp" > In message <87ty5bmfsv@qurzaw.varnish-software.com>, Tollef Fog Heen > writes > : > > >As long as you can detect whether a 503 is internally generated or not, > >that's fine. > > That is an interesting idea, but w

Re: Varnish 3.1 becoming 4.0 instead (?)

2011-12-08 Thread Tollef Fog Heen
when sessions do not > wait, and then worker->ws can then be eliminated and sess->ws > contain both req.* and resp.* (Hopefully in 4.0) Won't sess->ws always exist (and probably be where most vmods will store their data) or do you actually mean what you wrote? Chee

Re: [PATCH] (Updated) Solaris: Test for SO_{RCV, SND}TIMEO needs NET_LIBS

2011-10-13 Thread Tollef Fog Heen
roduction and, yes, AFAIK, the socket timeouts | now _do_ work on Solaris. | | phk, could you please include the patch? Applied -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://ww

Re: varnishncsa outage

2011-09-08 Thread Tollef Fog Heen
]] Jean-Baptiste Quenot | 2011/9/6 Tollef Fog Heen : | > | > Can you please capture varnishlog from a request which causes the crash? | > The backtrace above does unfortunately not help me. | | I'm sorry I can't afford to crash varnishncsa anymore. My boss is | getting angr

[PATCH] Switch default storage allocator to malloc, limited to 100MB

2011-09-06 Thread Tollef Fog Heen
--- bin/varnishd/varnishd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/bin/varnishd/varnishd.c b/bin/varnishd/varnishd.c index 5fb054a..8ff592c 100644 --- a/bin/varnishd/varnishd.c +++ b/bin/varnishd/varnishd.c @@ -349,7 +349,7 @@ main(int argc, char * const *argv)

[PATCH] Use predetermined -s file name by default

2011-09-06 Thread Tollef Fog Heen
If no -s argument was given, we would generate a random file name in the runtime directory. This file was never removed, something that would fill up the disk over time. Use a predetermined name instead. --- bin/varnishd/storage_file.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: varnishncsa outage

2011-09-06 Thread Tollef Fog Heen
That code isn't correct with user-specifiable fields, so it should probably just be removed. Regards, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: varnishncsa outage

2011-09-04 Thread Tollef Fog Heen
break; now why lp->df_m, which is the request method is null, I don't know. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: [PATCH] Fix time_firstbyte bug in varnishncsa

2011-08-30 Thread Tollef Fog Heen
the feature to log any response header, and it works | fine for logging the object age: Good to hear. :-) -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org

Re: varnishncsa 3.0.0 crash

2011-08-26 Thread Tollef Fog Heen
]] Jean-Baptiste Quenot | Do you believe this is fixed by https://www.varnish-cache.org/trac/ticket/944 ? Maybe, try 3.0.1 rc 1 and give feedback. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev

Re: [PATCH] Documentation fixes for 3.0-changes

2011-08-25 Thread Tollef Fog Heen
]] Andreas Plesner Jacobsen | On Wed, Aug 24, 2011 at 09:28:37AM +0200, Andreas Plesner Jacobsen wrote: | | > A few fixes for docs | | I now realize that I screwed up the nomenclature in doc/sphinx/tutorial/vcl.rst And thanks for this too; applied. :-) -- Tollef Fog Heen Varnish Softwar

Re: Document one more pitfall when upgrading

2011-08-25 Thread Tollef Fog Heen
]] Andreas Plesner Jacobsen | This could bite some users when upgrading large installations. Cheers, applied -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish

[PATCH] Lock panic buffer before mangling it

2011-08-19 Thread Tollef Fog Heen
If we were panic-ing in multiple threads at the same time, the panic buffer would be partially overwritten. Prevent this with a mutex --- bin/varnishd/cache_panic.c |5 + bin/varnishd/cache_shmlog.c |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/bin/varnishd/ca

vmod ABI checking

2011-08-18 Thread Tollef Fog Heen
load vmods against the wrong ABI. Do you have any thoughts about this? Patch is attached. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 diff --git a/.gitignore b/.gitignore index 095ca12..6cf0950 100644 --- a/.gitignore +++ b/.gitignore @@ -46,7 +46,7 @@ TAGS /include/vcl_retu

Re: Doc: Upgrading to 3.0

2011-08-09 Thread Tollef Fog Heen
ter adding hit_for_pass and fixing up the markup slightly. https://www.varnish-cache.org/docs/trunk/installation/upgrade.html for the online version; I'll merge it to 3.0 later. Best regards, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varn

Re: Proposed patch to fix #972

2011-08-05 Thread Tollef Fog Heen
check and disables if met when do_stream is | true. Maybe check sp->http->conds either in RES_Check_Conds or in cnt_fetchbody too? Apart from that, it looks reasonable to me. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev m

Re: varnishlog -o option

2011-07-14 Thread Tollef Fog Heen
]] Jean-Baptiste Quenot | But in EXAMPLES I can find it: | |The following command line reads that same log file and | displays requests for the front page:: | |$ varnishlog -r /var/log/varnish.log -c -o RxURL '^/$' Thanks, already fixed. -- Tollef Fog Heen Varnish

Re: Patch review for fix to #947 (assert on SIGHUP to varnishncsa)

2011-07-11 Thread Tollef Fog Heen
interrupt. Any comments | appreciated. Looks reasonable to me, please commit. Regards, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman

Re: varnishtop feature request: show _expensive_ urls

2011-07-11 Thread Tollef Fog Heen
e a useful tool for tracking certain types of problems, at least, yes. Cheers, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: Wrong version of server in RPM?

2011-06-28 Thread Tollef Fog Heen
ng version, or the right | version with the wrong version stamp? It was actually the wrong version. I've built 32 bit versions too now and uploaded a -2 RPM to the repo now. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-d

Re: Should manpages be mandatory for building varnish 3.0.0-beta1 ?

2011-05-27 Thread Tollef Fog Heen
doubt is if manpages are mandatory. I'd rather suggest you use the tarballs we have. http://repo.varnish-cache.org/source/ has tarballs for 2.1.x and 3.0 beta1, http://repo.varnish-cache.org/snapshots/ has snapshots for git master. -- Tollef Fog Heen Varni

Re: add vmod-std to the build

2011-05-27 Thread Tollef Fog Heen
oblems to solve, really. | I guess it all depends on how private you want to keep some of the header | files. Yup, basically. Cheers, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org

Re: add vmod-std to the build

2011-05-25 Thread Tollef Fog Heen
]] Per Buer | I've added a man page for the std module to the sphinx reference docs. If | someone could sprinkle some automake magic on top it would be great. Seems like Martin did this yesterday. -- Tollef Fog Heen Varnish Software t: +47 21 98

Re: Spurious TODO in varnishncsa.c 3.0 beta1

2011-05-25 Thread Tollef Fog Heen
]] Jean-Baptiste Quenot | For the sake of completeness, there is a TODO in varnishncsa.c: | | * TODO:- Log in any format one wants | | But this is actually implemented with the -F option. Most of it is implemented, yes. I've updated the text now, thanks. -- Tollef Fog

Re: When changing purge->ban in 3.0, should we also expose the VRT_ban_string functionality from VCL instead of relying on magic parsing the difference

2011-04-29 Thread Tollef Fog Heen
]] "Poul-Henning Kamp" | In message <8762pxfyhi@qurzaw.varnish-software.com>, Tollef Fog Heen writes | : | >| I'm sort of hessitant to mandate the one-string format, because it | >| will force some people to collect into one string, components which | >| the B

Re: When changing purge->ban in 3.0, should we also expose the VRT_ban_string functionality from VCL instead of relying on magic parsing the difference

2011-04-28 Thread Tollef Fog Heen
f this, does it cause any real-world problems? I agree it's not optimal, but you probably don't have a zillion bans a second so its performance is not critical and having a consistent UI is, IMO, pretty important. -- Tollef Fog Heen Varnish So

[PATCH] support for multiple -o arguments to varnish tools

2011-04-27 Thread Tollef Fog Heen
n", opt); + return (-1); + } + + o = strdup(opt); + AN(o); + regex = index(o, ':'); + *regex = '\0'; + regex++; + + m->tag = name2tag(o); + if (m->tag == -1) { + fprintf(stderr, "Illegal tag %s specified\n", o); + free(o); + return (-1); + } + /* Get tag, regex

#900 - suggested fix

2011-04-15 Thread Tollef Fog Heen
Hi, I've attached my suggested fix for #900. As a side effect, it allows you to embed binary data in arbitrary strings, so you can serve PNG or GIF images from vcl_error. Comments very welcome, both on the approach and what we should allow. Regards, -- Tollef Fog Heen Varnish Software t

Re: TCP_Check() compatibility for NetBSD

2011-04-14 Thread Tollef Fog Heen
et in trac.) Regards, -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: Patch review for adding command line macro definitions to varnishtest

2011-03-21 Thread Tollef Fog Heen
e exit(2); with no space? -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

[PATCH] Add lastpanic CLI command, dumping the last panic string

2011-03-10 Thread Tollef Fog Heen
--- bin/varnishd/cache_cli.c |1 + bin/varnishd/mgt_child.c | 31 +++ bin/varnishd/mgt_cli.c |1 + bin/varnishd/mgt_cli.h |1 + include/cli.h|6 ++ 5 files changed, 40 insertions(+), 0 deletions(-) diff --git a/bin/varnishd/cache_c

lastpanic CLI command

2011-03-10 Thread Tollef Fog Heen
The attached patch implements a lastpanic CLI command that dumps the contents of the panic string for the last panic. Review is most welcome. ___ varnish-dev mailing list varnish-dev@varnish-cache.org http://www.varnish-cache.org/lists/mailman/listinfo

Re: Workspace overflow on ia32

2011-03-09 Thread Tollef Fog Heen
with: commit 5f8041ac0745ba30e9190a69ec7b5d8ac2d4c1ec Author: Tollef Fog Heen Date: Tue Mar 8 13:06:01 2011 +0100 Reduce http_resp_size to 8k on 32 bit http_resp_size is allocated on the thread_pool_workspace. This means we will hit assert errors if http_resp_size is larger tha

Re: Updated varnish patches for cygwin 1.7.8

2011-03-08 Thread Tollef Fog Heen
od.py $(top_srcdir)/lib/libvmod_std/vmod.vcc | | EXTRA_DIST = vmod.py vmod.vcc | | CLEANFILES = $(builddir)/vcc_if.c $(builddir)/vcc_if.h | + | +if CYGWIN_COMPILATION | +install-exec-hook: | + $(LN_S) -f cygvmod_std-1.dll .libs/libvmod_std.so.1 | +endif What? You shouldn't symlink stuff into

Re: a few difficulties with trunk

2011-03-03 Thread Tollef Fog Heen
': |./vcl.1P9zoqAU.c:879: warning: implicit declaration of function 'atoi' You probably need C{ #include } near the top of the vcl file, to make sure you have the atoi function declaration around. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___

Re: varnishnsca from 3.0-pre dumps core

2011-03-03 Thread Tollef Fog Heen
]] "Bjoern A. Zeeb" Hi, | not much info yet on when, why or how it happens. It's varnish 3-pre | from 2011-02-21. If you could compile varnish with debugging symbols and get us a complete backtrace that'd be useful. Regards, -- Tollef Fog Heen Varnish Softwar

[PATCH 2/2] Drop version from libvmod_std

2011-02-22 Thread Tollef Fog Heen
There is no reason for libvmod_std to have a version number, so drop it and adjust test cases accordingly. --- bin/varnishtest/tests/m0.vtc |2 +- bin/varnishtest/tests/m1.vtc |2 +- bin/varnishtest/tests/m2.vtc |2 +- lib/libvcl/vcc_vmod.c|2 +- lib/libvmod

[PATCH 1/2] Move all libs but libvarnishapi to a private directory, drop soname number

2011-02-22 Thread Tollef Fog Heen
As we don't want anybody linking against libvarnish, libvcl and the other libraries, move those to pkglibdir. In addition, to further emphasize that they do not have a stable ABI, drop the version from the soname. --- lib/libvarnish/Makefile.am |4 ++-- lib/libvarnishcompat/Makefile.am

Build system cleanups

2011-02-22 Thread Tollef Fog Heen
I've got a couple of fixes for the build system, but I'd like to run those past -dev before committing them. The purpose is to be clearer about what interfaces we do and don't support. ___ varnish-dev mailing list varnish-dev@varnish-cache.org http://w

Re: vcl_timeout in varnish 2.1.5

2011-02-18 Thread Tollef Fog Heen
the work you need when an object is expired, depending on what you're trying to do. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64 ___ varnish-dev mailing list varnish-dev@varnish-cache.org http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: [PATCH] Normalizing the Host: header

2011-02-18 Thread Tollef Fog Heen
a list of various legal names to the canonical name, so in the general case: no. | Remember that DNS names can contain ideograms in asia these days... They're still just ascii under the hood, escaped by xn-- and the crazy IDN scheme. -- Tollef Fog Heen Varnis

Re: tiny [PATCH] to make e00022.vtc work on 32bit compiles

2011-02-03 Thread Tollef Fog Heen
]] Nils Goroll | From 6a77525a777b18eab821c9be27b0a0c43412484b Mon Sep 17 00:00:00 2001 | From: Nils Goroll | Date: Wed, 2 Feb 2011 17:15:54 +0100 | Subject: [PATCH] need more room for temporary gzip space on stack Thanks, applied! -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64

Re: obj.cacheable discontinuity and lifetime sw policy

2011-01-31 Thread Tollef Fog Heen
2.1.6? We won't change VCL or parameters in backwards-incompatible ways in minor versions. So this change (and similar ones) won't go into 2.1.6, but can (and in this case will) go into 3.0. -- Tollef Fog Heen Varnish Software t: +47 21 98 92 64

Re: Is request time available in VCL?

2011-01-26 Thread Tollef Fog Heen
]] Jean-Baptiste Quenot | I'd like to add a X-Varnish-Time header in the response to indicate | the same number, for service health checks. Is this time information | available in VCL? No, it is not. Regards, -- Tollef Fog Heen Varnish Software t: +47 21 98

  1   2   >