Re: [PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-30 Thread Tollef Fog Heen
]] Nils Goroll > >d9492da540430103b9dcd6844eb59b508c061d66 effectively breaks builds with gcc > >3.4. > > ... only when developer warnings are enabled. > > Patch attached. I think this looks reasonable, so feel free to commit. -- Tollef Fog Heen Technical lead | Varnish Software AS 📞: +47 21

Re: [PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-20 Thread Federico Schwindt
On Mon, Jan 20, 2014 at 6:37 PM, Nils Goroll wrote: > [..] > > I was looking at your diff I don't understand the >> -Wno-missing-field-initializers vs -Wno-extra. If the compiler doesn't >> support >> the former why add the -Wno-extra instead of just not adding >> -Wno-missing... ? >> > > Hm, yo

Re: [PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-20 Thread Nils Goroll
Hi Federico, On 01/20/14 12:13 PM, Federico Schwindt wrote: I was looking at your diff I don't understand the -Wno-missing-field-initializers vs -Wno-extra. If the compiler doesn't support the former why add the -Wno-extra instead of just not adding -Wno-missing... ? Hm, your question seems t

Re: [PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-20 Thread Federico Schwindt
Hi, I was looking at your diff I don't understand the -Wno-missing-field-initializers vs -Wno-extra. If the compiler doesn't support the former why add the -Wno-extra instead of just not adding -Wno-missing... ? Why are you disabling -Wextra in that case? The linker check seems wrong to me. The c

[PATCH] fix build with --enable-developer-warnings and gcc3.4

2014-01-09 Thread Nils Goroll
L" on Solaris / gcc 4.3.3 Nils >From bde10016e2a7543181f3a8534cbe13c94904d9b6 Mon Sep 17 00:00:00 2001 From: Nils Goroll Date: Thu, 9 Jan 2014 19:03:12 +0100 Subject: [PATCH] fix build with --enable-developer-warnings and gcc3.4 & gcc 4.3.3 on Solaris (and others maybe) MIME-Version: 1.0 C