Re: Adding -b (buffer size) parameter to varnishtest

2015-09-21 Thread Federico Schwindt
Committed. Thanks for the patch Carlos! On Thu, Sep 10, 2015 at 3:50 PM, Carlos Abalde wrote: > > > On 10 Sep 2015, at 15:00, Poul-Henning Kamp wrote: > > > > > > In message f53dbp-kogj7cepb1t_vzjdpftgsacu6ptdw8gb...@mail.gmail.com> > > , Dridi Boukelmoune writes: > >> On Thu, Sep 10

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-11 Thread Poul-Henning Kamp
In message , Federico Schwindt writes: >I've run into this many times and I've hacked varnishtest so I'd like to >see this in. I'm very much for the patch, (with the VNUM change I requested). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP sin

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-11 Thread Dridi Boukelmoune
> At commit 1628f0b, there are 469 test cases. 34 produce more than 50KB log. > Of those 34, there are 7 that use more than 100KB: I think it is interesting for VMOD writers or even Varnish users that want to test their VCL+backends to be able to raise this value. Especially when you want to repro

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-11 Thread Federico Schwindt
All these logs use mockup servers. If you are using varnishtest against real servers the length of resulting headers are going to be much larger. Same thing will happen with a real or close to real client. I've run into this many times and I've hacked varnishtest so I'd like to see this in. Also I

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-11 Thread Poul-Henning Kamp
In message <20150911125942.gb...@immer.varnish-software.com>, Lasse Karstensen writes: One Idea I have mulled was to have a "good" keyword in varnishtest scripts which would zero the log at that points. The idea is that scripts would do something like: # First subtest .

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-11 Thread Lasse Karstensen
On Thu, Sep 10, 2015 at 01:26:28PM +0200, Carlos Abalde wrote: > When implementing in VCL complex logic (not necessarily related with caching > contents -e.g. access control, rate limiting, etc.-) varnishtest is a > powerful tool to automate VCL testing. These type of tests sometimes are > compl

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-10 Thread Carlos Abalde
> On 10 Sep 2015, at 15:00, Poul-Henning Kamp wrote: > > > In message > > , Dridi Boukelmoune writes: >> On Thu, Sep 10, 2015 at 1:26 PM, Carlos Abalde >> wrote: >>> Hi, >>> >>> When implementing in VCL complex logic (not necessarily related with >>> caching contents -e.g. access

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-10 Thread Poul-Henning Kamp
In message , Dridi Boukelmoune writes: >On Thu, Sep 10, 2015 at 1:26 PM, Carlos Abalde wrote: >> Hi, >> >> When implementing in VCL complex logic (not necessarily related with caching >> contents -e.g. access control, rate limiting, etc.-) varnishtest is a >> powerful tool to automate

Re: Adding -b (buffer size) parameter to varnishtest

2015-09-10 Thread Dridi Boukelmoune
On Thu, Sep 10, 2015 at 1:26 PM, Carlos Abalde wrote: > Hi, > > When implementing in VCL complex logic (not necessarily related with caching > contents -e.g. access control, rate limiting, etc.-) varnishtest is a > powerful tool to automate VCL testing. These type of tests sometimes are > compl

Adding -b (buffer size) parameter to varnishtest

2015-09-10 Thread Carlos Abalde
Hi, When implementing in VCL complex logic (not necessarily related with caching contents -e.g. access control, rate limiting, etc.-) varnishtest is a powerful tool to automate VCL testing. These type of tests sometimes are complex and they are not easy to split in smaller pieces. In some extr