Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Poul-Henning Kamp
In message , Federico Schwindt writes: >Can you elaborate? How is Upgrade related to OPTIONS? > >Also (and this might require more clarifications on the VIP itself), I welcome all of you to amend & discuss in the VIP itself, it is meant to be our record of the decision for later... --

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Dridi Boukelmoune
> I'm not sure I get you point about the upgrade field as it's optional. Like I said, I don't think H2 allows upgrades. The other question was about backends doing a protocol switch, which means the client asked for an Upgrade and got it. There's no way to go from vcl_backend_response to vcl_pipe

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Guillaume Quintard
On Apr 6, 2016 17:14, "Dridi Boukelmoune" wrote: > As the VIP says, no matter how pipe turns out in v5, but how does H2 > deal with protocol upgrades? I think it doesn't (eg. websockets) > It doesn't. If you came through ALPN, you could have gone directly to the required protocol. Same thing if y

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Dridi Boukelmoune
On Wed, Apr 6, 2016 at 5:02 PM, Federico Schwindt wrote: > Can you elaborate? How is Upgrade related to OPTIONS? It isn't, only the Upgrade header is important. You can use OPTIONS as a neutral request to try a protocol switch. But the question remains for status codes like 101 (Switching Protoco

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Federico Schwindt
Can you elaborate? How is Upgrade related to OPTIONS? Also (and this might require more clarifications on the VIP itself), WebSockets support still requires VCL changes, so we'll be expanding the changes to vcl_recv{} but either way won't work out of the box. On Wed, Apr 6, 2016 at 3:54 PM, Dridi

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Dridi Boukelmoune
On Wed, Apr 6, 2016 at 2:34 PM, Federico Schwindt wrote: > For the record, added my comment to the VIP at > https://github.com/varnishcache/varnish-cache/wiki/VIP8:-No-pipe-in-builtin.vcl-in-V5. Your comment on OPTIONS is valid, but we should also consider protocol upgrades. Maybe the test should

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Kristian Grønfeldt Sørensen
On ons, 2016-04-06 at 08:27 +, Poul-Henning Kamp wrote: > Can we make builtin::vcl_recv{} look like this in Varnish5 ? > > sub vcl_recv { > if (req.method == "PRI" ||  /* HTTP/2.0 */ >   req.method == "CONNECT" || >   req.method == "OPTIONS" || >   req.method == "TRACE"

Re: Varnish5 builtin VCL without pipe

2016-04-06 Thread Federico Schwindt
For the record, added my comment to the VIP at https://github.com/varnishcache/varnish-cache/wiki/VIP8:-No-pipe-in-builtin.vcl-in-V5 . On Wed, Apr 6, 2016 at 9:27 AM, Poul-Henning Kamp wrote: > Can we make builtin::vcl_recv{} look like this in Varnish5 ? > > sub vcl_recv { > if (req.method

Varnish5 builtin VCL without pipe

2016-04-06 Thread Poul-Henning Kamp
Can we make builtin::vcl_recv{} look like this in Varnish5 ? sub vcl_recv { if (req.method == "PRI" || /* HTTP/2.0 */ req.method == "CONNECT" || req.method == "OPTIONS" || req.method == "TRACE") { return (synth(405)); } if (req.method != "GET" && req.