-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/26/2015 15:25, Michal Necasek wrote:
> Sorry, I wasn't clear. By "what is the semantic difference" I meant
> "under what circumstances will the conditional behave differently".
> There must be some difference because otherwise what would be the
Sorry, I wasn't clear. By "what is the semantic difference" I meant "under
what circumstances will the conditional behave differently". There must be some
difference because otherwise what would be the point of a warning?
Remember that programmers can have a hard time reading compilers' minds
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/26/2015 05:08, Frank Mehnert wrote:
> Hi,
>
> On Friday 13 March 2015 16:56:47 Jung-uk Kim wrote:
>> include/VBox/com/array.h - fixes for null-pointer dereferences.
>
> that's difficult. I know that compilers and static code checking
> tools
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/26/2015 14:03, Michal Necasek wrote:
>
> The question isn't whether a compiler can warn. The question is,
> why should it?
Although this specific code has absolutely no problem, compilers are
not smart enough to read authors' mind yet. ;-)
>
The question isn't whether a compiler can warn. The question is, why should it?
What you quoted doesn't contradict what Frank said. There is a very well
defined pointer to bool conversion. So what's the problem? Or in other words,
what is the semantic difference between
if (ptr)
and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/26/2015 04:51, Frank Mehnert wrote:
> Hi,
>
> On Friday 13 March 2015 16:56:56 Jung-uk Kim wrote:
>> This fix an implicit conversion from pointer to bool.
>
> why is this patch necessary? An expression like
>
> if (pointer) { }
>
> is compl
Hi,
On Friday 13 March 2015 16:57:21 Jung-uk Kim wrote:
> sysctlbyname(3) for FreeBSD requires size_t type for the last
> argument, not a pointer.
>
> https://www.freebsd.org/cgi/man.cgi?query=sysctlbyname&format=html
Applied.
Thanks for the patch and the pointer to the documentation!
Frank
--
Hi,
On Friday 13 March 2015 16:56:47 Jung-uk Kim wrote:
> include/VBox/com/array.h
> - fixes for null-pointer dereferences.
that's difficult. I know that compilers and static code checking tools
complain but the intention behind these statements is to return NULL
in case we are trying to access a
Hi,
On Friday 13 March 2015 16:56:56 Jung-uk Kim wrote:
> This fix an implicit conversion from pointer to bool.
why is this patch necessary? An expression like
if (pointer)
{
}
is completely valid and no compiler should warn about it. It tests if
the pointer has a value different from NUL
On Friday 13 March 2015 16:57:28 Jung-uk Kim wrote:
> This simply fixes typos, i.e., '||' was misused in place of '<<'.
Applied. Actually not a bug but the fix still makes sense.
Thanks!
Frank
--
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG
On Friday 13 March 2015 16:58:02 Jung-uk Kim wrote:
> Although it is not really a bug, Clang complains there may be a problem.
Applied.
Thanks!
Frank
--
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weinstadt, Germany
Hi,
On Friday 13 March 2015 16:58:12 Jung-uk Kim wrote:
> This switch/case statement for AMD K7 processors does not return
> correct CPUIDs.
applied.
Thanks!
Frank
--
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weins
12 matches
Mail list logo
