Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-12-07 Thread Michael Thayer
Hello Sedat, Have you tried the latest test builds? https://www.virtualbox.org/wiki/Testbuilds Regards Michael 07.12.18 15:26, Sedat Dilek wrote: > Hi, > > what is the status of the patch proposal(s)? > > Next weekend there will be Linux v4.20-rc6 and in approx. 2 weeks > Linux 4.20 final wil

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-21 Thread Larry Finger
On 11/21/18 3:12 AM, Michael Thayer wrote: 21.11.18 02:24, Larry Finger wrote: Michael, I really like your approach to testing for features in a manner that will be less affected by distros backporting API changes. Unfortunately, code patched using your version fails to build under kernel 4.20.

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-21 Thread Larry Finger
On 11/21/18 1:23 AM, Aleksey Ilyushin wrote: Hello Larry, Thanks a lot for your patch. I do have an issue with it though. I think ‘get_link_ksettings’ callback is supposed to return the link settings in the new format, so ‘vboxNetAdpEthGetSettings’ should allocate the old structure, fill it o

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-21 Thread Michael Thayer
21.11.18 02:24, Larry Finger wrote: > Michael, > > I really like your approach to testing for features in a manner that > will be less affected by distros backporting API changes. Unfortunately, > code patched using your version fails to build under kernel 4.20.0-rcX. > As I noted, the get_setting

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Aleksey Ilyushin
Hello Larry, Thanks a lot for your patch. I do have an issue with it though. I think ‘get_link_ksettings’ callback is supposed to return the link settings in the new format, so ‘vboxNetAdpEthGetSettings’ should allocate the old structure, fill it out, then call a function that does the opposite

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Larry Finger
On 11/20/18 6:37 AM, Michael Thayer wrote: 08.11.18 21:27, Larry Finger wrote: Hi, There are a number of changes in kernel 4.20 that affect building the VB modules. These are as follows: 1. In struct ethtool_ops, the get_settings member is renamed get_link_ksettings, and the callback method is

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Michael Thayer
08.11.18 21:27, Larry Finger wrote: > Hi, > > There are a number of changes in kernel 4.20 that affect building the VB > modules. These are as follows: > > 1. In struct ethtool_ops, the get_settings member is renamed > get_link_ksettings, and the callback method is changed. To satisfy the > new m

[vbox-dev] Fixes for API changes in kernel 4.20

2018-11-08 Thread Larry Finger
Hi, There are a number of changes in kernel 4.20 that affect building the VB modules. These are as follows: 1. In struct ethtool_ops, the get_settings member is renamed get_link_ksettings, and the callback method is changed. To satisfy the new method, routine convert_link_ksettings_to_legacy