Hi,
On 05-07-17 17:57, Michael Thayer wrote:
Hello Hans,
05.07.2017 15:55, Hans de Goede wrote:
[...]
On 05-07-17 12:14, Michael Thayer wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp.]
I believe your reading of the code was correct and mine not. As per my
last message though
Hello Hans,
06.07.2017 11:08, Hans de Goede wrote:
[Discussion of whether to implement the new behaviour of the
CANCEL_ALL_WAITEVENTS IoCtl in the in-kernel vboxguest.]
By the way, feel free to submit patches to bring our code more in line
with what you intend to submit to the kernel, if that will
Hi,
On 06-07-17 08:12, Michael Thayer wrote:
Hello Hans,
05.07.2017 21:47, Hans de Goede wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp and behaviour
changes in r67796, r67798 and r67802.]
Looks good, thanks I'm still going to go for compatibility
with the old behavior though,
Hello Hans,
05.07.2017 21:47, Hans de Goede wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp and behaviour
changes in r67796, r67798 and r67802.]
> Looks good, thanks I'm still going to go for compatibility
> with the old behavior though, to ensure existing guest addition
> installs
Hi,
On 05-07-17 17:57, Michael Thayer wrote:
Hello Hans,
05.07.2017 15:55, Hans de Goede wrote:
[...]
On 05-07-17 12:14, Michael Thayer wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp.]
I believe your reading of the code was correct and mine not. As per my
last message though
Hello Hans,
05.07.2017 15:55, Hans de Goede wrote:
[...]
> On 05-07-17 12:14, Michael Thayer wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp.]
I believe your reading of the code was correct and mine not. As per my
last message though, see r67796[1], r67798[2] and r67802[3]. As I
Hi,
On 05-07-17 12:14, Michael Thayer wrote:
Hello Hans,
05.07.2017 11:18, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
I've been looking at the userspace code myself and this bit:
src/VBox/Additions/x11/VBoxClient/seamless.cpp:
int SeamlessMain:
Hello Hans,
05.07.2017 11:18, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
> I've been looking at the userspace code myself and this bit:
>
> src/VBox/Additions/x11/VBoxClient/seamless.cpp:
>
> int SeamlessMain::selfTest()
> {
> int rc = VERR_INT
Hi,
On 04-07-17 16:57, Michael Thayer wrote:
Hello Hans,
04.07.2017 14:24, Hans de Goede wrote:
Hi,
On 04-07-17 11:46, Michael Thayer wrote:
Hello Hans,
04.07.2017 08:55, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
So some remarks about this,
Hello Hans,
04.07.2017 14:24, Hans de Goede wrote:
> Hi,
>
> On 04-07-17 11:46, Michael Thayer wrote:
>> Hello Hans,
>>
>> 04.07.2017 08:55, Hans de Goede wrote:
>> [Discussion of inconsistent wait event cancelling code in VBoxGuest.]
>>> So some remarks about this, I was thinking that *maybe* th
Hi,
On 04-07-17 11:46, Michael Thayer wrote:
Hello Hans,
04.07.2017 08:55, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
So some remarks about this, I was thinking that *maybe* the old
behavior is on purpose, imagine the following:
1) cancel, no wa
Hello Hans,
04.07.2017 08:55, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
> So some remarks about this, I was thinking that *maybe* the old
> behavior is on purpose, imagine the following:
>
> 1) cancel, no waiters, pSession->fPendingCancelWaitEvents
Hi Michael,
Thank you for looking into this.
On 04-07-17 08:14, Michael Thayer wrote:
Hello Hans,
03.07.2017 20:49, Michael Thayer wrote:
[Discussion of incorrect looking wait code in VBoxGuest.cpp.]>
I did not get any response when I asked around about this. Reading the
code (quite a bit of
Hello Hans,
03.07.2017 20:49, Michael Thayer wrote:
[Discussion of incorrect looking wait code in VBoxGuest.cpp.]>
> I did not get any response when I asked around about this. Reading the
> code (quite a bit of work, as you presumably discovered too; fortunately
> the user-space part is a bit eas
Hello Hans,
03.07.2017 17:21, Hans de Goede wrote:
> Hi,
>
> So while working on cleaning up the vboxguest driver for mainline
> linux kernel submission (*) I noticed some inconsistent behavior
> wrt vgdrvIoCtl_CancelAllWaitEvents vs vgdrvIoCtl_WaitEvent.
>
> If there are no waiters then vgdrvIo
Hi,
So while working on cleaning up the vboxguest driver for mainline
linux kernel submission (*) I noticed some inconsistent behavior
wrt vgdrvIoCtl_CancelAllWaitEvents vs vgdrvIoCtl_WaitEvent.
If there are no waiters then vgdrvIoCtl_CancelAllWaitEvents
sets pSession->fPendingCancelWaitEvents a
16 matches
Mail list logo
