Re: [vbox-dev] Minor changes to e1000 device to support Phar Lap ETS

2014-04-07 Thread Aleksey Ilyushin
Jeff, Are you sure there is no need to set MDIC.E bit to indicate an error when the driver attempts to read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely sets MDIC.R as if the operation was successful. Regards, Aleksey On 06 Apr 2014, at 06:53, Jeff Westfahl wrote: > Her

Re: [vbox-dev] Minor changes to e1000 device to support Phar Lap ETS

2014-04-07 Thread Jeff Westfahl
Aleksey, Yes, setting MDIC_ERROR in addition to MDIC_READY is probably better behavior. I tested our drivers and they continue to work with both of these bits set, so no complaints about that here. Would you like me to resubmit the patch with this change? Regards, Jeff Westfahl Aleksey Ilyus