cing a new
eviction_valuable callback which the vboxvideo driver does not define:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a2ab19fed9d1dc5a7a2ced44f4b289885c522a8f
This commit adds a definition for this callback, fixing the crash.
Signed-off-by: Hans de Goede
---
src/VBox
Hi All,
Here is a small bugfix for the vboxvideo drm driver.
You hereby have my and Red Hat's permission to use
this patch under the MIT license.
Regards,
Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listin
Hi All,
Here is a set of patches further cleaning up the vboxvideo driver in
preparation for upstream submission. Total line-count of files needed
to build the vboxvideo driver before these changes: 16763, after: 7837 :)
You hereby have my and Red Hat's permission to use these patches under the
M
Use the functions from linux/genalloc.h instead of the vbox custom
HGSMIMalloc implementation.
Signed-off-by: Hans de Goede
---
src/VBox/Additions/common/VBoxVideo/HGSMIGuest.cpp | 5 +
src/VBox/Additions/linux/drm/HGSMIBuffers.h| 54 ++
src/VBox/Additions/linux/drm
Signed-off-by: Hans de Goede
---
src/VBox/Additions/linux/drm/HGSMIBuffers.h | 10 --
src/VBox/Additions/linux/drm/vbox_drv.h | 2 +-
src/VBox/Additions/linux/drm/vbox_irq.c | 4 ++--
src/VBox/Additions/linux/drm/vbox_main.c| 26 +-
src/VBox
Signed-off-by: Hans de Goede
---
src/VBox/Additions/linux/drm/VBoxVideoIPRT.h | 28 +++-
src/VBox/Additions/linux/drm/files_vboxvideo_drv | 4
2 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/VBoxVideoIPRT.h
b/src/VBox
Hi,
I could not get manual mounting of vboxsf mounts to work under Linux
(Fedora) the problem turned out to be that the guest-additions installer
(the .run file) creates a /sbin/mount.vboxsf symlink to
/opt/VBox.../other/mount.vboxsf which does not exist correcting
this to point to:
/opt/VBox.../
Hi,
I cannot get a Fedora 26 guest to boot with either distro-provided or
self-built 4.12-rc# kernels, the distro-provided 4.11 kernel works fine.
After selecting a 4.12# kernel in the grub menu the vm shows an empty text
screen with a cursor in the top left corner and then just hangs.
Anyone
Hi,
On 24-05-17 16:02, Michael Thayer wrote:
24.05.2017 15:16, Hans de Goede wrote:
[...]
I cannot get a Fedora 26 guest to boot with either distro-provided or
self-built 4.12-rc# kernels, the distro-provided 4.11 kernel works fine.
After selecting a 4.12# kernel in the grub menu the vm shows
Hi,
On 25-05-17 11:57, Hans de Goede wrote:
Hi,
On 24-05-17 18:13, Michael Thayer wrote:
24.05.2017 16:02, Michael Thayer wrote:
24.05.2017 15:16, Hans de Goede wrote:
[...]
I cannot get a Fedora 26 guest to boot with either distro-provided or
self-built 4.12-rc# kernels, the distro
Hi,
On 29-05-17 12:23, Hans de Goede wrote:
Hi,
On 25-05-17 11:57, Hans de Goede wrote:
Hi,
On 24-05-17 18:13, Michael Thayer wrote:
24.05.2017 16:02, Michael Thayer wrote:
24.05.2017 15:16, Hans de Goede wrote:
[...]
I cannot get a Fedora 26 guest to boot with either distro-provided or
Hi,
On 29-05-17 15:12, Frank Mehnert wrote:
Hi Hans,
On Montag, 29. Mai 2017 13:27:33 CEST Hans de Goede wrote:
On 29-05-17 12:23, Hans de Goede wrote:
On 25-05-17 11:57, Hans de Goede wrote:
On 24-05-17 18:13, Michael Thayer wrote:
24.05.2017 16:02, Michael Thayer wrote:
24.05.2017 15:16
Hi,
On 29-05-17 17:28, Frank Mehnert wrote:
On Montag, 29. Mai 2017 16:58:28 CEST Frank Mehnert wrote:
Hi Hans,
On Montag, 29. Mai 2017 16:22:09 CEST Hans de Goede wrote:
[...]
Ok, can you try install a 4.12 kernel, e.g.:
https://koji.fedoraproject.org/koji/buildinfo?buildID=892258
Hi,
On 01-06-17 14:08, Frank Mehnert wrote:
On Dienstag, 30. Mai 2017 09:14:31 CEST Hans de Goede wrote:
On 29-05-17 17:28, Frank Mehnert wrote:
On Montag, 29. Mai 2017 16:58:28 CEST Frank Mehnert wrote:
Hi Hans,
On Montag, 29. Mai 2017 16:22:09 CEST Hans de Goede wrote:
[...]
Ok, can you
Hi,
On 01-06-17 15:42, Frank Mehnert wrote:
Hi Hans,
On Donnerstag, 1. Juni 2017 14:22:29 CEST Hans de Goede wrote:
Again, this is not a VirtualBox bug although this panic will probably not
happen on real hardware.
[...]
No as for the disagree-ing with this not being a VirtualBox bug,
even
Hi,
On 31-05-17 21:53, Michael Thayer wrote:
Hello Hans,
17.05.2017 16:59, Hans de Goede wrote:
Hi All,
Here is a set of patches further cleaning up the vboxvideo driver in
preparation for upstream submission. Total line-count of files needed
to build the vboxvideo driver before these
Hi,
On 01-06-17 16:11, Frank Mehnert wrote:
Hi Hans,
On Donnerstag, 1. Juni 2017 15:59:10 CEST Hans de Goede wrote:
Hi,
On 01-06-17 15:42, Frank Mehnert wrote:
Hi Hans,
On Donnerstag, 1. Juni 2017 14:22:29 CEST Hans de Goede wrote:
Again, this is not a VirtualBox bug although this panic
Fix:
drivers/staging/vboxvideo/vbox_main.c: In function ‘vbox_hw_init’:
drivers/staging/vboxvideo/vbox_main.c:278:5: warning: ISO C90 forbids mixed
declarations and code [-Wdeclaration-after-statement]
int ret;
^~~
Signed-off-by: Hans de Goede
---
src/VBox/Additions/linux/drm
]
void *p = VBoxHGSMIBufferAlloc(pCtx, sizeof(VBVAQUERYMODEHINTS)
^~~~
Signed-off-by: Hans de Goede
---
src/VBox/Additions/common/VBoxVideo/Modesetting.cpp | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/VBox/Additions/common/VBoxVideo/Modesetting.cpp
b/src
Hi Alex,
On 05/26/2017 03:21 AM, Alex Pavel wrote:
Hello! I have been looking again at how to implement the passing of a config
file to our Ignition first boot provisioner, which would allow us to fully,
officially support VirtualBox. For reference, see
https://www.virtualbox.org/pipermail/vb
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_irq.c | 244 +---
1 file changed, 133 insertions(+), 111 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_irq.c
b/src/VBox/Additions/linux/drm/vbox_irq.c
index 7fdf8660..c9b4079f 100644
--- a/src/VBox
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_drv.h | 267
1 file changed, 133 insertions(+), 134 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_drv.h
b/src/VBox/Additions/linux/drm/vbox_drv.h
index d21cded6..0d411b18 100644
--- a/src/VBox
Hi,
Here is the first batch of patches to change the various vbox_*.? files
in the linux drm/kms driver to the kernel coding style.
You hereby have my and Red Hat's permission to use these patches under
the MIT license.
Regards,
Hans
___
vbox-dev mail
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_drv.c | 318
1 file changed, 161 insertions(+), 157 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_drv.c
b/src/VBox/Additions/linux/drm/vbox_drv.c
index 00924fe8..b7af0061 100644
--- a/src/VBox
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_fb.c | 618 +
1 file changed, 315 insertions(+), 303 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_fb.c
b/src/VBox/Additions/linux/drm/vbox_fb.c
index cf538c1a..0519bd61 100644
--- a/src/VBox/Additions
Fix:
CHECK: Alignment should match open parenthesis
#123: FILE: drivers/staging/vboxvideo/vbox_hgsmi.c:123:
offset = gen_pool_virt_to_phys(guest_pool,
(unsigned long)buf - sizeof(HGSMIBUFFERHEADER));
Signed-off-by: Hans de Goede
---
src/VBox/Additions/linux/drm
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_main.c | 705 ---
1 file changed, 370 insertions(+), 335 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_main.c
b/src/VBox/Additions/linux/drm/vbox_main.c
index aea5ddb9..2bf6bc2c 100644
--- a/src/VBox
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_mode.c | 1281 --
1 file changed, 667 insertions(+), 614 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_mode.c
b/src/VBox/Additions/linux/drm/vbox_mode.c
index b7504dd0..28d7b5dc 100644
--- a/src/VBox
Hi,
Here are the last 2 patches to complete the conversion of the linux drm/kms
driver files to the kernel coding style.
You hereby have my and Red Hat's permission to use these under the MIT
license.
I'm going to submit a first version of vboxvideo for inclusion into
drivers/staging later today
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_ttm.c | 627
1 file changed, 321 insertions(+), 306 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_ttm.c
b/src/VBox/Additions/linux/drm/vbox_ttm.c
index 5099ba06..186da83c 100644
--- a/src/VBox
: Hans de Goede
---
src/VBox/Additions/linux/drm/vbox_prime.c | 44 +++
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/src/VBox/Additions/linux/drm/vbox_prime.c
b/src/VBox/Additions/linux/drm/vbox_prime.c
index 5c47ec6a..7216b642 100644
--- a/src/VBox
Jun 2017 11:58:30 +0200
From: Hans de Goede
To: Greg Kroah-Hartman , Daniel Vetter ,
Jani Nikula , Sean Paul , David Airlie
CC: Hans de Goede , dri-de...@lists.freedesktop.org,
de...@driverdev.osuosl.org
Hi All,
Recently I've been working on cleaning up the vboxvideo driver with the
inte
Hi,
On 09-06-17 12:07, Greg Kroah-Hartman wrote:
On Fri, Jun 09, 2017 at 11:58:31AM +0200, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in Virtual Box virtual machines to drivers/staging.
Why drivers/staging? This driver is already
Hi Linus,
Sorry for escalating this right up to you, but this issue
does not seem to be getting any attention and I'm not sure
which subsys maintainer to poke about this.
The problem is that the 4.12-rc# kernels fail to boot on
VirtualBox guests hosted on any machine with a Sky Lake
(and probabl
Hi,
On 09-06-17 12:40, Michael Thayer wrote:
Hello,
09.06.2017 12:21, Hans de Goede wrote:
Hi,
On 09-06-17 12:07, Greg Kroah-Hartman wrote:
On Fri, Jun 09, 2017 at 11:58:31AM +0200, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in
Hi,
On 09-06-17 11:58, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in Virtual Box virtual machines to drivers/staging.
Why drivers/staging? This driver is already being patched into the kernel
by several distros, thus it is good to get
Hi,
On 12-06-17 09:27, Dave Airlie wrote:
On 12 June 2017 at 16:56, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in Virtual Box virtual machines to drivers/staging.
Why drivers/staging? This driver is already being patched into the
Hi,
On 12-06-17 13:44, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it's KMS
only, and it would be good to have someone review that properly.
I believe it does not use the atomic API
Hi,
On 12-06-17 18:03, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
Hi,
On 12-06-17 13:44, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it'
Hi all,
On 14-06-17 11:34, Michael Thayer wrote:
Hello Sean,
13.06.2017 20:03, Sean Paul wrote:
[Discussion of vboxvideo driver clean-up.]
First, thank you for your submission.
Thank you for your feedback.
[Discussion of the OS-independent code in the driver submission.]
I took a quick s
Hi,
On 14-06-17 15:20, Michael Thayer wrote:
Hello Hans,
09.06.2017 09:48, Hans de Goede wrote:
[...]
Here are the last 2 patches to complete the conversion of the linux drm/kms
driver files to the kernel coding style.
You hereby have my and Red Hat's permission to use these under th
Hi,
On 14-06-17 15:40, Michael Thayer wrote:
Hello Hans,
14.06.2017 15:30, Hans de Goede wrote:
[Discussion of vboxvideo and vboxguest driver clean-up.]
As I already mentioned in previous mails on this, for the vboxguest driver
my plan is to simply do a fork and remove anything related to the
Hi,
On 22-06-17 07:46, Michael Thayer wrote:
Hello Hans,
Sorry for the long delay. I am working on too many things in parallel
(though I suspect you have a few too!)
No problem.
14.06.2017 16:52, Michael Thayer wrote:
Hello Hans,
14.06.2017 15:36, Hans de Goede wrote:
[Discussion of
Hi,
I've been testing vbox 3d pass-through, and if I use metacity as a window
manger then running glxgears -info shows:
GL_RENDERER = Chromium
GL_VERSION= 2.1 Chromium 1.9
GL_VENDOR = Humper
So things seem to be working, but gnome3 / gnome-shell does not work ?
Regards,
Hans
___
Hi,
On 23-06-17 10:44, Michael Thayer wrote:
Hello Hans,
22.06.2017 11:49, Hans de Goede wrote:
[...]
I've been testing vbox 3d pass-through, and if I use metacity as a window
manger then running glxgears -info shows:
GL_RENDERER = Chromium
GL_VERSION= 2.1 Chromium 1.9
GL_V
Hi,
On 22-06-17 14:03, Dan Carpenter wrote:
> This is obviously much better and easier to review. I ended up
> reviewing it like I would normal code instead of staging code. My main
> thing is could you please re-write the module init error handling so
> that each function does its own error ha
Hi,
On 26-06-17 11:24, Michael Thayer wrote:
Hello Hans,
23.06.2017 11:52, Hans de Goede wrote:
Hi,
On 23-06-17 10:44, Michael Thayer wrote:
Hello Hans,
22.06.2017 11:49, Hans de Goede wrote:
[...]
I've been testing vbox 3d pass-through, and if I use metacity as a
window
manger
Hi,
On 15-06-17 12:29, Michael Thayer wrote:
Hello Hans,
Continuing this in a new thread without all the other recipients.
14.06.2017 17:03, Hans de Goede wrote:
Hi,
On 14-06-17 15:40, Michael Thayer wrote:
Hello Hans,
14.06.2017 15:30, Hans de Goede wrote:
[Discussion of vboxvideo and
Hi,
On 26-06-17 18:24, Daniel Vetter wrote:
On Mon, Jun 26, 2017 at 06:06:19PM +0200, Hans de Goede wrote:
Hi,
On 23-06-17 11:31, Daniel Vetter wrote:
On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card
Hi,
On 27-06-17 11:34, Michael Thayer wrote:
Hello Hans,
26.06.2017 18:12, Hans de Goede wrote:
[Discussion of 3D problems in Fedora VirtualBox guests and ld.so.conf
trickery used to put 3D libraries in place, but not completing in time
for the display manager.]
Ok, I understand, this is easy
Hi,
On 06/27/2017 01:46 PM, Michael Thayer wrote:
Hello Hans,
27.06.2017 11:38, Hans de Goede wrote:
Hi,
On 27-06-17 11:34, Michael Thayer wrote:
Hello Hans,
26.06.2017 18:12, Hans de Goede wrote:
[Discussion of 3D problems in Fedora VirtualBox guests and ld.so.conf
trickery used to put 3D
Hi,
On 06/27/2017 05:50 PM, Michael Thayer wrote:
Hello Hans,
27.06.2017 15:17, Hans de Goede wrote:
[...]
On 06/27/2017 01:46 PM, Michael Thayer wrote:
[Discussion of 3D problems in Fedora VirtualBox guests, of ld.so.conf
trickery used to put 3D libraries in place, but not completing in
://github.com/0day-ci/linux/commits/Hans-de-Goede/staging-vboxvideo-Add-vboxvideo-to-drivers-staging/20170627-035353
config: x86_64-randconfig-n0-06270721 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Hi,
So while working on cleaning up the vboxguest driver for mainline
linux kernel submission (*) I noticed some inconsistent behavior
wrt vgdrvIoCtl_CancelAllWaitEvents vs vgdrvIoCtl_WaitEvent.
If there are no waiters then vgdrvIoCtl_CancelAllWaitEvents
sets pSession->fPendingCancelWaitEvents a
Hi Michael,
Thank you for looking into this.
On 04-07-17 08:14, Michael Thayer wrote:
Hello Hans,
03.07.2017 20:49, Michael Thayer wrote:
[Discussion of incorrect looking wait code in VBoxGuest.cpp.]>
I did not get any response when I asked around about this. Reading the
code (quite a bit of
Hi,
On 04-07-17 11:46, Michael Thayer wrote:
Hello Hans,
04.07.2017 08:55, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
So some remarks about this, I was thinking that *maybe* the old
behavior is on purpose, imagine the following:
1) cancel, no
Hi,
On 01-07-17 21:53, Michael Thayer wrote:
Hello Hans,
27.06.2017 20:46, Hans de Goede wrote:
[...]
On 06/27/2017 05:50 PM, Michael Thayer wrote:
[...]
27.06.2017 15:17, Hans de Goede wrote:
[Discussion of 3D problems with Fedora 25 and 26 guests.]
Back to 3d passthrough any idea why
Hi,
On 04-07-17 16:57, Michael Thayer wrote:
Hello Hans,
04.07.2017 14:24, Hans de Goede wrote:
Hi,
On 04-07-17 11:46, Michael Thayer wrote:
Hello Hans,
04.07.2017 08:55, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
So some remarks about this
Hi,
On 05-07-17 12:14, Michael Thayer wrote:
Hello Hans,
05.07.2017 11:18, Hans de Goede wrote:
[Discussion of inconsistent wait event cancelling code in VBoxGuest.]
I've been looking at the userspace code myself and this bit:
src/VBox/Additions/x11/VBoxClient/seamless.cpp:
int Seamles
Hi,
On 05-07-17 17:57, Michael Thayer wrote:
Hello Hans,
05.07.2017 15:55, Hans de Goede wrote:
[...]
On 05-07-17 12:14, Michael Thayer wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp.]
I believe your reading of the code was correct and mine not. As per my
last message
Hi,
On 06-07-17 08:12, Michael Thayer wrote:
Hello Hans,
05.07.2017 21:47, Hans de Goede wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp and behaviour
changes in r67796, r67798 and r67802.]
Looks good, thanks I'm still going to go for compatibility
with the old behavior t
Hi,
VbglPhysHeapAlloc seems to be yet another mem-allocator
which chunks up memory returned by RTMemContAlloc, which
returns physical contiguous memory below 4GB.
I don't see any reason why we cannot use kmalloc directly
for that with a GFP_DMA32 flag.
One other thing which RTMemContAlloc seems
Hi,
On 06-07-17 11:44, Knut St. Osmundsen wrote:
Hi Hans.
On 2017-07-06 11:13 AM, Hans de Goede wrote:
Hi,
VbglPhysHeapAlloc seems to be yet another mem-allocator
which chunks up memory returned by RTMemContAlloc, which
returns physical contiguous memory below 4GB.
Need for keeping the code
at it should be easy to adopt this
patch for upstream.
Regards,
Hans
>From 996996a67913eb5e2cd2f4711cb3db565cd26e9b Mon Sep 17 00:00:00 2001
From: Hans de Goede
Date: Mon, 10 Jul 2017 12:01:55 +0200
Subject: [PATCH 1/2] Stop calling VbglGRPerform ourselves just to get the
host-version
Stop
Hi,
On 10-07-17 12:08, Hans de Goede wrote:
Hi all,
During my vboxguest Linux cleanup work I made a small
detour to the vboxsf driver.
I noticed that although it depends on vboxguest to make
hgcm calls, it still comes with its own copy of
GenericRequest, Physheap, Init and VMMDev.c
It seems
Hi Larry,
On 10-07-17 21:37, Larry Finger wrote:
On 07/10/2017 10:12 AM, Michael Thayer wrote:
Hello Hans,
10.07.2017 12:29, Hans de Goede wrote:
Hi,
On 10-07-17 12:08, Hans de Goede wrote:
Hi all,
During my vboxguest Linux cleanup work I made a small
detour to the vboxsf driver.
I
Hi all,
I just upgraded a vbox guest to 4.13, the good news is
everything works fine, but one thing which I noticed, which
would be nice to fix is this new error message:
[0.00] [Firmware Bug]: TSC_DEADLINE disabled due to Errata; please
update microcode to version: 0xb2 (or later)
Thi
Hi,
On 05-07-17 17:57, Michael Thayer wrote:
Hello Hans,
05.07.2017 15:55, Hans de Goede wrote:
[...]
On 05-07-17 12:14, Michael Thayer wrote:
[Discussion of CANCEL_ALL_WAITEVENTS use in seamless.cpp.]
I believe your reading of the code was correct and mine not. As per my
last message
Hi,
I would like to test the (Linux guest) memory balloon code.
Is there anything I can do to explicitly make the host request
the guest to give up some memory through the balloon ?
Regards,
Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
http
Hi Michal,
On 26-07-17 17:18, Michal Necasek wrote:
Hi Hans,
The message is harmless. It's triggered because VirtualBox currently does not
expose the host CPU microcode revision to guest operating systems. I don't
think we want to do that without fully understanding what sorts of assum
RTErrConvertToErrno and RTErrConvertFromErrno.
Signed-off-by: Hans de Goede
---
src/VBox/Runtime/common/err/RTErrConvertFromErrno.cpp | 9 +
src/VBox/Runtime/common/err/RTErrConvertToErrno.cpp | 9 +
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/VBox/Runtime
commit removes the positive VERR_* style vbox-runtime codes
and makes vgdrvLinuxIOCtl always return standard Linux errno values.
Signed-off-by: Hans de Goede
---
src/VBox/Additions/common/VBoxGuest/VBoxGuest-linux.c | 7 ++-
src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3Lib.cpp | 4
Hi,
You may want to do something similar to this for vbox upstream:
https://github.com/jwrdegoede/vboxguest/commit/8a79961c661e3fba88c0e50447b2344e0c811d1a
Note in my tree this applies on top of:
https://github.com/jwrdegoede/vboxguest/commit/8c232c972f7b2dfbfc863a1aaeb0b44fdfcf82d0
Which I do
Hi,
On 04-08-17 12:45, Peter Rosin wrote:
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are
no longer used. Remove the dead code that was not doing anything
sensible anyway.
Signed-off-by: Peter Rosin
Thank you, patch looks good to me:
Acked-by: Hans de Goede
Regards
Hi,
On 25-07-17 12:01, Andreas Löffler wrote:
Hello Hans,
please have a look at the manual, section 4.9.1 "Memory ballooning" and
commands like
VBoxManage controlvm "VM name" guestmemoryballoon
VBoxManage modifyvm "VM name" --guestmemoryballoon
There is also a frontend called VBoxBalloonCt
thus the return code fun.
Right, I would prefer not to do this, note that HGCM_CALL which seems to
be one of the most used ioctls already does this.
Regards,
Hans
On 2017-08-01 5:19 PM, Hans de Goede wrote:
Returning VERR_* style vbox-runtime codes as positive values is an ugly
hack and unlik
Hi,
On 07-08-17 16:16, Michael Thayer wrote:
Hello Hans and Knut,
Would a new ioctl to query the last IPRT code for an open session be an
option in case the caller does need the extra information?
Thank you for the suggestion, but IMHO that is worse (uglier) then returning
the vbox status err
Hi,
On 07/25/2017 11:06 AM, Michael Thayer wrote:
> 13.07.2017 16:42, Michael Thayer wrote:
>> 10.07.2017 12:29, Hans de Goede wrote:
>> [Patch to shared folder code proposed by Hans to reduce the line count
>> of the Linux driver.]
>>
>> I reviewed the patch
Hi,
On 07/25/2017 11:06 AM, Michael Thayer wrote:
13.07.2017 16:42, Michael Thayer wrote:
10.07.2017 12:29, Hans de Goede wrote:
[Patch to shared folder code proposed by Hans to reduce the line count
of the Linux driver.]
I redid the patch again, after realising that the non-physical-page
Hi,
On 08/07/2017 07:06 PM, Knut St. Osmundsen wrote:
Hi Hans,
sorry but I'm not convinced this is really useful and improving the code. We
will fix this properly in a cross platform manner eventually, I hope.
No problem, I've already reverted the changes in the vboxguest version
I'm working
Hi,
On 08-08-17 16:23, Hans de Goede wrote:
Hi,
On 07/25/2017 11:06 AM, Michael Thayer wrote:
> 13.07.2017 16:42, Michael Thayer wrote:
>> 10.07.2017 12:29, Hans de Goede wrote:
>> [Patch to shared folder code proposed by Hans to reduce the line count
>> of the Lin
Hi All,
I've just submitted a first RFC version of the vboxguest and
vboxsf to the upstream linux kernel:
https://lkml.org/lkml/2017/8/11/400
https://lkml.org/lkml/2017/8/11/398
https://lkml.org/lkml/2017/8/11/399
I've Cc-ed Knut and Michael, but not vbox-dev because the
mainline kernel devs do
On some operating-systems the driver can tell whether an ioctl is a
32bit compat callback or not without looking at the ioctl-nr, at a flag
argument to pass this info along and use it for Linux to not need
separate ioctl codes for 32 and 64 bit.
Signed-off-by: Hans de Goede
---
include/VBox
Note to linux-kernel readers: This Cc-ed to linux-kernel because it is
relevant for the "[RFC 0/2] Add Virtual Box vboxguest and vboxsf guest
drivers to the mainline kernel" thread.
Hi Michael, Knut,
My first submission of the vboxguest driver for inclusion into
the Linux kernel has lead to some
On 14-08-17 09:27, Hans de Goede wrote:
Note to linux-kernel readers: This Cc-ed to linux-kernel because it is
relevant for the "[RFC 0/2] Add Virtual Box vboxguest and vboxsf guest
drivers to the mainline kernel" thread.
Hi Michael, Knut,
My first submission of the vboxguest
asons, then yes
now would be the time to do that. But you don't have to do it just on
my account.
Regards,
Hans
On 2017-08-14 9:30 AM, Hans de Goede wrote:
On 14-08-17 09:27, Hans de Goede wrote:
Note to linux-kernel readers: This Cc-ed to linux-kernel because it is
relevant for
bit builds.
Signed-off-by: Hans de Goede
---
include/VBox/VBoxGuest.h | 6 ++
src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp | 6 --
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
index 221b1a76
VBOXGUEST_IOCTL_CODE_ directly for all ioctls.
Signed-off-by: Hans de Goede
---
include/VBox/VBoxGuest.h | 50
1 file changed, 17 insertions(+), 33 deletions(-)
diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
index b2650bf8..6f9d5c32
consistent and use VBOXGUEST_IOCTL_CODE_
for all ioctls which do not have a 32 bit compat counter-part.
Signed-off-by: Hans de Goede
---
include/VBox/VBoxGuest.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/VBox/VBoxGuest.h b/include/VBox/VBoxGuest.h
inde
Hi Knut, Michael,
While taking another look at the ioctl number definitions I noticed
that most ioctls were defined using VBOXGUEST_IOCTL_CODE_ (note the _
at the end). So I started out writing a patch to make all ioctls
which do not have a specific 32 bit version use VBOXGUEST_IOCTL_CODE_
instead
Hi,
On 14-08-17 14:19, Hans de Goede wrote:
Hi,
On 14-08-17 13:43, Knut St. Osmundsen wrote:
Hi Hans,
the other platforms also have KPIs or similar constructs for figuring
out whether the client process issuing the I/O controls is a 32-bit or
64-bit one. However, using the
Hi,
On 10-08-17 16:11, Hans de Goede wrote:
Hi,
On 08-08-17 16:23, Hans de Goede wrote:
Hi,
On 07/25/2017 11:06 AM, Michael Thayer wrote:
> 13.07.2017 16:42, Michael Thayer wrote:
>> 10.07.2017 12:29, Hans de Goede wrote:
>> [Patch to shared folder code proposed by Hans to
Hi,
On 25-08-17 10:29, Michael Thayer wrote:
Hello Hans,
21.08.2017 14:49, Hans de Goede wrote:
[...]
First of all thank you for the answers to the above questions (see
archives).
I've just found one more piece of code where I wonder if that should
be kept. VbglR0SfMapFolder first
The size argument to VBGL_IOCTL_CODE_SIZE should be
VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
always failing with EINVAL. Which in turn fixes seamless mode not
working under Linux.
Signed-off-by: Hans de Goede
---
include/VBox/VBoxGuest.h | 2 +-
1 file changed, 1
Hi,
On 27-09-17 08:46, Gianfranco Costamagna wrote:
Hello, we tried in Ubuntu to use the new shiny vboxvideo mainline kernel driver
with the new shiny CONFIG_DRM_VBOXVIDEO config key, and we had to quickly
disable
it to use the old working kernel module.
Reason: it breaks with wayland.
see:
Hi,
On 28-09-17 15:00, Sérgio Basto wrote:
On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:
I just tried Fedora kernel 4.13.1-303.fc27, which has the vboxvideo
driver enabled,
This is enabled in Fedora kernels or vanilla kernels , do you mean
since 4.13.1 vbox guestaditionals drives
Hi,
On 29-09-17 19:38, Sérgio Basto wrote:
On Fri, 2017-09-29 at 19:27 +0200, Hans de Goede wrote:
Hi,
On 28-09-17 15:00, Sérgio Basto wrote:
On Wed, 2017-09-27 at 18:16 +0200, Hans de Goede wrote:
I just tried Fedora kernel 4.13.1-303.fc27, which has the
vboxvideo
driver enabled,
This is
The size argument to VBGL_IOCTL_CODE_SIZE should be
VBGL_IOCTL_WAIT_FOR_EVENTS_SIZE. This fixes VBGL_IOCTL_WAIT_FOR_EVENTS
always failing with EINVAL. Which in turn fixes seamless mode not
working under Linux.
Signed-off-by: Hans de Goede
---
include/VBox/VBoxGuest.h | 2 +-
1 file changed, 1
Hi,
On 11-10-17 07:26, Michael Thayer wrote:
Hello Gianfranco,
02.10.2017 12:11, Gianfranco Costamagna wrote:
Thanks for the heads-up. I am gradually adjusting our in-tree code to
match vboxvideo in staging, so at some point, when things stop turning
up to stop me, I will probably hit the cru
Hi,
On 12-10-17 11:17, Michael Thayer wrote:
Hello Both,
11.10.2017 17:41, Hans de Goede wrote:
Hi,
On 11-10-17 07:26, Michael Thayer wrote:
Hello Gianfranco,
02.10.2017 12:11, Gianfranco Costamagna wrote:
Thanks for the heads-up. I am gradually adjusting our in-tree code to
match
1 - 100 of 116 matches
Mail list logo
