Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-19 Thread Matt Brookings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Manvendra Bhangui wrote: How often does the code actually reference the UID/GID? Could you have a function to look it up and cache it in a static once found? A quick check and it looks like it's only referenced when adding a user or updating

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-18 Thread Tom Collins
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Aug 17, 2009, at 4:03 PM, Matt Brookings wrote: Itamar Reis Peixoto wrote: storing uid / gid in a config file will be light Lighter than accessing an authentication database, agreed. Like I said, I'm hoping to add configuration API to

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-18 Thread Itamar Reis Peixoto
How often does the code actually reference the UID/GID?  Could you have a function to look it up and cache it in a static once found? sounds great, the best solution at this moment. A quick check and it looks like it's only referenced when adding a user or updating the tcp.smtp.cdb file.  

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-18 Thread Manvendra Bhangui
On Tue, 2009-08-18 at 18:34 -0500, Tom Collins wrote: How often does the code actually reference the UID/GID? Could you have a function to look it up and cache it in a static once found? A quick check and it looks like it's only referenced when adding a user or updating the

[vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Itamar Reis Peixoto
currently vpopmail user and vchkpw group's need's to be created before running ./configure. this is not good for packaging it as rpm, because in rpm the user and group are created in %post section (after vpopmail installed) #define VPOPMAILGID 503 #define VPOPMAILUID 507 any chance to improve

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Matt Brookings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: currently vpopmail user and vchkpw group's need's to be created before running ./configure. this is not good for packaging it as rpm, because in rpm the user and group are created in %post section (after vpopmail

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Itamar Reis Peixoto
I agree parsing /etc/passwd every time is expensive a config file file will be welcome. On Mon, Aug 17, 2009 at 1:18 PM, Matt Brookingsm...@inter7.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: currently vpopmail user and vchkpw group's need's to be

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread T.J. Drennan
Itamar Reis Peixoto wrote: currently vpopmail user and vchkpw group's need's to be created before running ./configure. this is not good for packaging it as rpm, because in rpm the user and group are created in %post section (after vpopmail installed) #define VPOPMAILGID 503 #define

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Tren Blackburn
...@inter7.com To: vchkpw@inter7.com vchkpw@inter7.com Sent: Mon Aug 17 09:18:19 2009 Subject: Re: [vchkpw] vpopmail UID/GID hardcoded in config.h -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: currently vpopmail user and vchkpw group's need's to be created before running

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Matt Brookings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tren Blackburn wrote: And since no one else has mentioned this...some of us don't use /etc/passwd for authentication. So searching /etc/passwd would not work anyway. Isn't there a C function call to check user/group id? Or at least a universal

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Itamar Reis Peixoto
my suggestion is related about which user and group vpopmail run's not about authentication. no authentication is involved in this On Mon, Aug 17, 2009 at 5:52 PM, Matt Brookingsm...@inter7.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tren Blackburn wrote: And since no one

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Matt Brookings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: my suggestion is related about which user and group vpopmail run's not about authentication. no authentication is involved in this That may be the case, but the fact is, your system-level authentication backend

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Itamar Reis Peixoto
storing uid / gid in a config file will be light On Mon, Aug 17, 2009 at 5:57 PM, Matt Brookingsm...@inter7.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: my suggestion is related about which user and group vpopmail run's not about authentication. no

Re: [vchkpw] vpopmail UID/GID hardcoded in config.h

2009-08-17 Thread Matt Brookings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Itamar Reis Peixoto wrote: storing uid / gid in a config file will be light Lighter than accessing an authentication database, agreed. Like I said, I'm hoping to add configuration API to vpopmail that will replace all the configure-time options