[vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Martin Gansser
Hi, i am trying to compile vdr-2.4.0 for Fedora 30 on the Fedora rpm build server, but this fails with the following error message [1]: g++ -O3 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Klaus Schmidinger
On 9/28/18 10:21 AM, Martin Gansser wrote: ... dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope if (ioctl(fd_audio, AUDIO_GET_PTS, &pts) == -1) { ^ dvbhdffdevice.c:569:33: note: suggested alternative: 'VIDEO_

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Martin Gansser
ok, the Fedora30 package [1] kernel-headers-4.19.0-0.rc5.git2.1.fc30.x86_64.rpm contains the file /usr/include/linux/dvb/audio.h, but definition #define AUDIO_GET_PTS _IOR('o', 19, __u64) fehlt. [1] https://kojipkgs.fedoraproject.org//packages/kernel-headers/4.19.0/0.rc5.git2.1.fc30

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Klaus Schmidinger
On 9/28/18 11:04 AM, Martin Gansser wrote: ok, the Fedora30 package [1] kernel-headers-4.19.0-0.rc5.git2.1.fc30.x86_64.rpm contains the file /usr/include/linux/dvb/audio.h, but definition #define AUDIO_GET_PTS _IOR('o', 19, __u64) fehlt. [1] https://kojipkgs.fedoraproject.org//pac

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Alexander Grothe
It seems this definition has been removed upstream, because it was considered to be "unused": https://github.com/torvalds/linux/commit/d21c249b26311dd193b100e65fc9e7ae96233d40#diff-56193b27b16cac28881a16f295c6ff3cL133 Am Fr., 28. Sep. 2018 um 11:22 Uhr schrieb Klaus Schmidinger < klaus.schmidin...

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Martin Gansser
I have opened a fedora ticket [1] https://bugzilla.redhat.com/show_bug.cgi?id=1633979 thanks Martin   Gesendet: Freitag, 28. September 2018 um 12:02 Uhr Von: "Alexander Grothe" An: "VDR Mailing List" Betreff: Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this sc

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Klaus Schmidinger
On 9/28/18 12:02 PM, Alexander Grothe wrote: It seems this definition has been removed upstream, because it was considered to be "unused": https://github.com/torvalds/linux/commit/d21c249b26311dd193b100e65fc9e7ae96233d40#diff-56193b27b16cac28881a16f295c6ff3cL133 Signed-off-by: Mauro Carvalho

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Alexander Grothe
He tried to remove AUDIO_GET_PTS in 2011: https://github.com/torvalds/linux/commit/fa24198897ff0e8d34876be0e61f9b35d3c0d467 and had to revert it: https://github.com/torvalds/linux/commit/7a2b66b1bd26d717763985bad401410665fa0672 Alexander Am 28.09.2018 um 14:53 schrieb Klaus Schmidinger: On 9

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Jasmin J.
Hi! This is obsolete since Kernel 4.8: https://www.kernel.org/doc/html/v4.8/media/uapi/dvb/audio-get-pts.html So VDR would already have needed to be changed quite some time ago. I guess it is time to do it now. In this particular case I would also suggest to create a patch for VDR 2.4.0, so th

Re: [vdr] dvbhdffdevice.c:569:33: error: 'AUDIO_GET_PTS' was not declared in this scope

2018-09-28 Thread Klaus Schmidinger
On 9/28/18 8:05 PM, Jasmin J. wrote: Hi! This is obsolete since Kernel 4.8: https://www.kernel.org/doc/html/v4.8/media/uapi/dvb/audio-get-pts.html Any idea why it was necessary to break these things? So VDR would already have needed to be changed quite some time ago. I guess it is time t