Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-09-15 Thread Klaus Schmidinger
On 20.05.2012 13:55, Matti Lehtimäki wrote: On 05/20/2012 02:45 PM, Klaus Schmidinger wrote: On 20.05.2012 13:41, Matti Lehtimäki wrote: On 05/20/2012 02:15 PM, Klaus Schmidinger wrote: One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event.

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-09-15 Thread Matti Lehtimäki
On 09/15/2012 04:57 PM, Klaus Schmidinger wrote: While adopting this patch I found that we need to set the timer's 'event' pointer to the actual event here, and that the start time should always be set to the event's start time (even if VPS is not used) in order to keep the event from getting

[vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Matti Lehtimäki
Hi I made a patch to allow special case for instant recordings to only record the present event. This is done by defining Instant rec. time to 0. There is still the question what should be done if event is non-existent or otherwise not obtained? Should the VDR default Instant rec. time be

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Klaus Schmidinger
On 20.05.2012 11:30, Matti Lehtimäki wrote: Hi I made a patch to allow special case for instant recordings to only record the present event. This is done by defining Instant rec. time to 0. Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Matti Lehtimäki
On 05/20/2012 12:37 PM, Klaus Schmidinger wrote: Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS time, the timer's start time should be set to the VPS time, and the timer's ttVps flag should be set. Hi Attached is a new version of the

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Klaus Schmidinger
On 20.05.2012 13:09, Matti Lehtimäki wrote: On 05/20/2012 12:37 PM, Klaus Schmidinger wrote: Nice idea. However, please also take VPS into account. If Setup.UseVps is set, and the event has a VPS time, the timer's start time should be set to the VPS time, and the timer's ttVps flag should be

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Matti Lehtimäki
On 05/20/2012 02:15 PM, Klaus Schmidinger wrote: One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started yesterday ;-) Indeed that was missing. I think setting the day is relevant

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Klaus Schmidinger
On 20.05.2012 13:41, Matti Lehtimäki wrote: On 05/20/2012 02:15 PM, Klaus Schmidinger wrote: One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and the event started yesterday ;-) Indeed that was

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Matti Lehtimäki
On 05/20/2012 02:45 PM, Klaus Schmidinger wrote: On 20.05.2012 13:41, Matti Lehtimäki wrote: On 05/20/2012 02:15 PM, Klaus Schmidinger wrote: One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event. Just in case it is past midnight already and

Re: [vdr] [PATCH] Allow instant recording to record only present event

2012-05-20 Thread Klaus Schmidinger
On 20.05.2012 13:55, Matti Lehtimäki wrote: On 05/20/2012 02:45 PM, Klaus Schmidinger wrote: On 20.05.2012 13:41, Matti Lehtimäki wrote: On 05/20/2012 02:15 PM, Klaus Schmidinger wrote: One more thing comes to mind: you also need to make sure that the 'day' is set to the day of the EPG event.