Re: [vdr] cppcheck: VDR 1.7.18: [timers.c:53]: (error) snprintf size is out of bounds

2011-06-15 Thread Klaus Schmidinger
On 15.06.2011 19:37, Udo Richter wrote: Am 15.06.2011 18:34, schrieb Klaus Schmidinger: On 15.06.2011 15:30, Paul Menzel wrote: if (Instant&& channel) snprintf(file, sizeof(file), "%s%s", Setup.MarkInstantRecord ? "@" : "", *Setup.NameInstantRecord ? Setup.NameInsta

Re: [vdr] cppcheck: VDR 1.7.18: [timers.c:53]: (error) snprintf size is out of bounds

2011-06-15 Thread Gerald Dachs
Am Wed, 15 Jun 2011 18:34:59 +0200 schrieb Klaus Schmidinger : > ...this should be > >sizeof(file) - 1 > > Thanks for the bug report. This is no bug. The size parameter includes the '\0' byte. Gerald ___ vdr mailing list vdr@linuxtv.org http://w

Re: [vdr] cppcheck: VDR 1.7.18: [timers.c:53]: (error) snprintf size is out of bounds

2011-06-15 Thread Udo Richter
Am 15.06.2011 18:34, schrieb Klaus Schmidinger: > On 15.06.2011 15:30, Paul Menzel wrote: >>if (Instant&& channel) >> snprintf(file, sizeof(file), "%s%s", >> Setup.MarkInstantRecord ? "@" : "", *Setup.NameInstantRecord ? >> Setup.NameInstantRecord : channel->Name()); > >

Re: [vdr] cppcheck: VDR 1.7.18: [timers.c:53]: (error) snprintf size is out of bounds

2011-06-15 Thread Klaus Schmidinger
On 15.06.2011 15:30, Paul Menzel wrote: Dear VDR folks, Cppcheck 1.49 [1] reports the following error when run against VDR 1.7.18. [timers.c:53]: (error) snprintf size is out of bounds Looking at `timers.c` in `CTimer` `*file = 0` and afterward written to if I am not mistaken. This

[vdr] cppcheck: VDR 1.7.18: [timers.c:53]: (error) snprintf size is out of bounds

2011-06-15 Thread Paul Menzel
Dear VDR folks, Cppcheck 1.49 [1] reports the following error when run against VDR 1.7.18. [timers.c:53]: (error) snprintf size is out of bounds Looking at `timers.c` in `CTimer` `*file = 0` and afterward written to if I am not mistaken. […] cTimer::cTimer(bool Instant,