Re: [vdsm] [Users] questions about vdsm supervdsmserver

2013-04-26 Thread Itamar Heim
you'll probably get more answers on vdsm-devel (cc'd). bcc'd users to avoid dupes. On 04/26/2013 09:59 AM, bigclouds wrote: hi,all. i have 2 questions about supervdsmserver, 1.why it is created separately as a daemon? its many function have never been used, and its function can be done by ca

Re: [vdsm] [Users] questions about vdsm supervdsmserver

2013-04-28 Thread Yaniv Bronheim
Hey bigclouds, Supervdsm allows vdsm to run root commands, like mount, dmidecode, lsblk, scan folders that are unprivileged for vdsm user, and more. Due to this method we avoid executing root commands using execv with sudo, that way we don't create subprocess for each operation. We have to have

Re: [vdsm] [Users] questions about vdsm supervdsmserver

2013-05-01 Thread bigclouds
hi, Yaniv Bronheim: i have read your new code of supervdsmserver, i think it is fine,please let us confirm two questions 1.supervdsm.py will kill serive when relanuch, who respond to start service again? i suggest "let supervdsmd.init take care of its start and stop" is a normal way 2.line

Re: [vdsm] [Users] questions about vdsm supervdsmserver

2013-05-02 Thread Yaniv Bronheim
Hey, Thanks for the review bigclouds. For next time, it is much easier and better to write your comments on the gerrit page itself. Just make a user and you can start contributing by reviewing patches :) For your comments: 1. respawn is a bash script that takes care of restarting supervdsmServe