Hi,
Since there is no coverage report on tests in vdsm, if a PEP 8 patch
passes the tests, we still not sure if there is no mistake in it.
Viewing the diff reports on all the changes consumes a lot of time, and
some small but fatal mistakes(like misspelling variable name) can easily
be ignored by
I haven't used the tool yet, but saw your mail with the examples.
I think its a very nice tool and very helpful. Why don't you submit this
tool to python project itself ?
It think it deserves it.
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.
On Thu, Jun 07, 2012 at 12:03:30PM +0800, Zhou Zheng Sheng wrote:
> Hi,
>
> Since there is no coverage report on tests in vdsm, if a PEP 8 patch
> passes the tests, we still not sure if there is no mistake in it.
> Viewing the diff reports on all the changes consumes a lot of time, and
> some smal
On 2012-6-7 21:26, Adam Litke wrote:
On Thu, Jun 07, 2012 at 12:03:30PM +0800, Zhou Zheng Sheng wrote:
Hi,
Since there is no coverage report on tests in vdsm, if a PEP 8 patch
passes the tests, we still not sure if there is no mistake in it.
Viewing the diff reports on all the changes consumes
On Thu, Jun 07, 2012 at 11:13:14PM +0800, Shu Ming wrote:
> On 2012-6-7 21:26, Adam Litke wrote:
> >On Thu, Jun 07, 2012 at 12:03:30PM +0800, Zhou Zheng Sheng wrote:
> >>Hi,
> >>
> >>Since there is no coverage report on tests in vdsm, if a PEP 8 patch
> >>passes the tests, we still not sure if ther
On Sun, Jun 10, 2012 at 11:15:48AM +0300, Dan Kenigsberg wrote:
> On Thu, Jun 07, 2012 at 11:13:14PM +0800, Shu Ming wrote:
> > On 2012-6-7 21:26, Adam Litke wrote:
> > Yes, I agree with you. Also, we should merge this tool into vdsm as
> > a helper for PEP8 clean work.
>
> Thanks, Zhou Zheng! I h
On 06/11/2012 02:06 PM, Ewoud Kohl van Wijngaarden wrote:
On Sun, Jun 10, 2012 at 11:15:48AM +0300, Dan Kenigsberg wrote:
On Thu, Jun 07, 2012 at 11:13:14PM +0800, Shu Ming wrote:
On 2012-6-7 21:26, Adam Litke wrote:
Yes, I agree with you. Also, we should merge this tool into vdsm as
a helper
