Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Zhou Zheng Sheng has posted comments on this change. Change subject: pep8 fixes for storage/blockVolume.py .. Patch Set 2: Verified The patch passes tests in vdsm, and pydiff reports no changes in code logic. -- To view, visit

Change in vdsm[master]: Make vdsm/define.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/define.py PEP8 clean .. Patch Set 4: I would prefer that you didn't submit this There is a misspelling in one of the strings as I mentioned in the l

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 3: Verified The patch passes vdsm tests, and pydiff reports no differences found in code logic. -- To view, visit

Change in vdsm[master]: Make vdsm/storage/hba.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/storage/hba.py PEP8 clean .. Patch Set 3: Verified The patch passes tests in vdsm and pydiff reports no differences found in code logic. -- To vie

Change in vdsm[master]: Make vdsm/hooks.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/hooks.py PEP8 clean .. Patch Set 3: Verified Test patch set 3 using the same method in patch set 1. Patch set 3 passes the tests. -- To view, visi

Change in vdsm[master]: Close and remove the temporary file before raising a excepti...

Wenyi Gao has posted comments on this change. Change subject: Close and remove the temporary file before raising a exception .. Patch Set 2: Verified I built and installed the rpm packate then ran on Fedora16. No abnormal beha

Change in vdsm[master]: Make vdsm/define.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/define.py PEP8 clean .. Patch Set 4: (1 inline comment) pydiff report: $ pydiff define*.py 3 difference(s) first file: defineo.py second file: defi

Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

Zhou Zheng Sheng has posted comments on this change. Change subject: Properly parse configurations in function "do_create" in vdsClient .. Patch Set 1: Two example nested values: drive=pool:3ace0f74-a9fa-11e1-bb33-00247edb474

Change in vdsm[master]: make event loop handle EINTR on poll

Royce Lv has posted comments on this change. Change subject: make event loop handle EINTR on poll .. Patch Set 2: Verified tested: 1.vdsm/libvirt connection succeed 2.vdsm event callback called 3.os.setuid/setgid/setgroup will

Change in vdsm[master]: make event loop handle EINTR on poll

Royce Lv has uploaded a new change for review. Change subject: make event loop handle EINTR on poll .. make event loop handle EINTR on poll some system call and signal will interrupt poll, making event loop stops and fails to re

Change in vdsm[master]: config qemu-sanlock to ignore readonly lease for default

Mark Wu has posted comments on this change. Change subject: config qemu-sanlock to ignore readonly lease for default .. Patch Set 1: I would prefer that you didn't submit this You also need bump the required libvirt version to

Change in vdsm[master]: deployUtil: Do not use static home for root user

Mark Wu has posted comments on this change. Change subject: deployUtil: Do not use static home for root user .. Patch Set 1: Looks good to me, but someone else must approve Interesting. Have we seen any system not using '/root

Change in vdsm[master]: deployUtil: Do not use static home for root user

Douglas Schilling Landgraf has posted comments on this change. Change subject: deployUtil: Do not use static home for root user .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5112 To unsubscribe, visit http:

Change in vdsm[master]: deployUtil: Do not use static home for root user

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: deployUtil: Do not use static home for root user .. deployUtil: Do not use static home for root user Fix for systems which do not use /root as home

Change in vdsm[master]: config qemu-sanlock to ignore readonly lease for default

Royce Lv has posted comments on this change. Change subject: config qemu-sanlock to ignore readonly lease for default .. Patch Set 1: Verified tested agaist: libvirt:libvirt-0.9.12-1.fc16.x86_64 vdsm:vdsm-4.9.6-0.269.git3e44fe0

Change in vdsm[master]: Add passwd command to vdsm tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm tool .. Patch Set 11: (1 inline comment) File vdsm-tool/passwd.py Line 47: print

Change in vdsm[master]: Add passwd command to vdsm tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm tool .. Patch Set 11: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Change storageServer to handle numeric connection values

Dan Kenigsberg has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) ...

Change in vdsm[master]: Change storageServer to handle numeric connection values

Yair Zaslavsky has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 5: Verified Verified , similar scenario as before. Patchset 5 changes: (Following Dan's c

Change in vdsm[master]: Add passwd command to vdsm-tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 10: (1 inline comment) File vdsm-tool/passwd.py Line 36: except IO

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 10: (1 inline comment) File vdsm-tool/passwd.py Line 36: e

Change in vdsm[master]: Add passwd command to vdsm-tool

Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 10: (1 inline comment) File vdsm-tool/passwd.py Line 36: except IO

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 10: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Change storageServer to handle numeric connection values

Yair Zaslavsky has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 4: (2 inline comments) File vdsm/stor

Change in vdsm[master]: Change storageServer to handle numeric connection values

Dan Kenigsberg has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) ...

Change in vdsm[master]: Change storageServer to handle numeric connection values

Yair Zaslavsky has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 4: Patchset 4 : Verified. Changes: (Following Dan's comments) - a. Added some spaces b. R

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

Change in vdsm[master]: Make vdsm/guestIF.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/guestIF.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 3: (1 inline comment) File vdsm/clientIF.py Line

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Me

Change in vdsm[master]: Make vdsm/define.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/define.py PEP8 clean .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-

Change in vdsm[master]: Make before_vm_start.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make before_vm_start.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4800 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

Change in vdsm[master]: Make BindingXMLRPC.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make BindingXMLRPC.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

Change in vdsm[master]: Make before_vm_start.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make before_vm_start.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4798 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

Change in vdsm[master]: Make SecureXMLRPCServer.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make SecureXMLRPCServer.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4797 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Make before_vm_start.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: Make before_vm_start.py PEP8 clean .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4800 To unsubscribe, v

Change in vdsm[master]: Make devicemapper.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make devicemapper.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

Change in vdsm[master]: Make vdsm/hooks.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/hooks.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: Make volume.py for PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make volume.py for PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-M

Change in vdsm[master]: Make vdsm/storage/hba.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/storage/hba.py PEP8 clean .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

Change in vdsm[master]: Make vdsm/define.py PEP8 clean

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Make vdsm/define.py PEP8 clean .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4536 To uns

Change in vdsm[master]: Make vdsm/guestIF.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: Make vdsm/guestIF.py PEP8 clean .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4803 To unsubscribe, visi

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Bing Bu Cao has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 3: (1 inline comment) File vdsm/define.py Line 74: >>> f092812.

Change in vdsm[master]: Change storageServer to handle numeric connection values

Yair Zaslavsky has posted comments on this change. Change subject: Change storageServer to handle numeric connection values .. Patch Set 2: Verified Verified both positive and negative flows - Positive flow - added nfs with ver

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Shu Ming has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 3: (1 inline comment) File vdsm/define.py Line 74: >>> f092812...

Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Bing Bu Cao has posted comments on this change. Change subject: pep8 fixes for storage/blockVolume.py .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5091 To unsubscribe

Change in vdsm[master]: config qemu-sanlock to ignore readonly lease for default

Bing Bu Cao has posted comments on this change. Change subject: config qemu-sanlock to ignore readonly lease for default .. Patch Set 1: (1 inline comment) File vdsm/vdsmd.in

Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Deepak C Shetty has posted comments on this change. Change subject: pep8 fixes for storage/blockVolume.py .. Patch Set 2: Verified I verified by using make check. -- To view, visit http://gerrit.ovirt.org/5091 To unsubscribe,

Change in vdsm[master]: Make safer to get vdsm section version in configuration file...

Bing Bu Cao has posted comments on this change. Change subject: Make safer to get vdsm section version in configuration files .. Patch Set 1: I would prefer that you didn't submit this I think whether reconfigure or not just ju

Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Zhou Zheng Sheng has posted comments on this change. Change subject: pep8 fixes for storage/blockVolume.py .. Patch Set 1: I would prefer that you didn't submit this There is a pep 8 whitelist in Makefile.am. You'd better add t

Change in vdsm[master]: adjust betterPopenTest.py

Bing Bu Cao has posted comments on this change. Change subject: adjust betterPopenTest.py .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http

Change in vdsm[master]: Better documentation for cpuPinning

Doron Fediuck has posted comments on this change. Change subject: Better documentation for cpuPinning .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5071 To unsubscribe

Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

Bing Bu Cao has posted comments on this change. Change subject: Properly parse configurations in function "do_create" in vdsClient .. Patch Set 1: Can you give me an example of the nested value you mentioned? I want to test yo

Change in vdsm[master]: Add a MOM functional test case for KSM

ShaoHe Feng has posted comments on this change. Change subject: Add a MOM functional test case for KSM .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5070 To unsubscrib

Change in vdsm[master]: Fixing pep8 in vdsm/hooks.py

Zhou Zheng Sheng has posted comments on this change. Change subject: Fixing pep8 in vdsm/hooks.py .. Patch Set 2: Verified Test patch set 2 using the same method in patch set 1. Patch set 2 passes the tests. -- To view, visit

Change in vdsm[master]: Properly parse configurations in function "do_create" in vds...

Zhou Zheng Sheng has uploaded a new change for review. Change subject: Properly parse configurations in function "do_create" in vdsClient .. Properly parse configurations in function "do_create" in vdsClient Before the patch: T

Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Deepak C Shetty has posted comments on this change. Change subject: pep8 fixes for storage/blockVolume.py .. Patch Set 1: Verified I verified by running make check before and after the changes. -- To view, visit http://gerrit.

Change in vdsm[master]: pep8 fixes for storage/blockVolume.py

Deepak C Shetty has uploaded a new change for review. Change subject: pep8 fixes for storage/blockVolume.py .. pep8 fixes for storage/blockVolume.py An attempt to clean blockVolume.py from pep8 errors. Change-Id: I270b8182be7fb

Change in vdsm[master]: Fixing pep8 in vdsm/define.py

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Fixing pep8 in vdsm/define.py .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: Change storageServer to parse some params as strings

Ayal Baron has posted comments on this change. Change subject: Change storageServer to parse some params as strings .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Add passwd command to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Add passwd command to vdsm-tool .. Patch Set 9: (1 inline comment) File vdsm-tool/passwd.py Line 45:

Change in vdsm[master]: Add a MOM functional test case for KSM

Xu He Jie has posted comments on this change. Change subject: Add a MOM functional test case for KSM .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: Changing origin of memShared stats to /sys/kernel/mm/ksm/pag...

Xu He Jie has posted comments on this change. Change subject: Changing origin of memShared stats to /sys/kernel/mm/ksm/pages_sharing .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerr

Re: [oVirt Jenkins] vdsm_unit_tests - Build # 176 - Failure!

On Fri, Jun 01, 2012 at 03:34:25PM +0300, Dan Kenigsberg wrote: > On Fri, Jun 01, 2012 at 05:16:28AM -0400, Laszlo Hornyak wrote: > > Hi, > > > > I ran this test a couple of times but but did not fail. Possibly a random > > error in the test environment? > > > > Yep. dd trying to fsync /dev/nul