Change in vdsm[master]: Fix: chlist as a volume object list in Image.merge().

2012-06-21 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Fix: chlist as a volume object list in Image.merge(). .. Fix: chlist as a volume object list in Image.merge(). Change-Id: I9d57d5e39a169e5d275a943dd4840d69f12e5781

Change in vdsm[master]: Fix: chlist as a volume object list in Image.merge().

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix: chlist as a volume object list in Image.merge(). .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: Add vdsm_reg/config.py to .gitignore

2012-06-21 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Add vdsm_reg/config.py to .gitignore .. Add vdsm_reg/config.py to .gitignore Change-Id: I01772c7a6a4057f80890581eaeba879ab0038939 Signed-off-by: Mark Wu

Change in vdsm[master]: Add vdsm_reg/config.py to .gitignore

2012-06-21 Thread mars
Bing Bu Cao has posted comments on this change. Change subject: Add vdsm_reg/config.py to .gitignore .. Patch Set 1: Looks good to me, but someone else must approve I think it is very interesting and wonder why/when the

Change in vdsm[master]: Add vdsm_reg/config.py to .gitignore

2012-06-21 Thread mars
Bing Bu Cao has posted comments on this change. Change subject: Add vdsm_reg/config.py to .gitignore .. Patch Set 1: Sorry for the comment,it is so weired. -- To view, visit http://gerrit.ovirt.org/5570 To unsubscribe, visit

Change in vdsm[master]: Remove the parameter of clientIF instance from API

2012-06-21 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Remove the parameter of clientIF instance from API .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/4603 To unsubscribe, visit

Change in vdsm[master]: Internal volumes must be RW in domain version 3

2012-06-21 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 17: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit

Change in vdsm[master]: Move actual VM creation function to clientIF.py

2012-06-21 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move actual VM creation function to clientIF.py .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/4808 To unsubscribe, visit

Change in vdsm[master]: Add a VDSM verb to change MOM policy

2012-06-21 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Add a VDSM verb to change MOM policy .. Patch Set 1: (1 inline comment) File vdsm/vdsmMOM.py Line 53: #

Re: your mail

2012-06-21 Thread Dan Kenigsberg
On Wed, Jun 20, 2012 at 04:07:28PM -0400, Jenkins oVirt Server wrote: That's not so informative ;-) ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches

Re: your mail

2012-06-21 Thread Eyal Edri
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Eyal Edri ee...@redhat.com Cc: aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, dougsl...@redhat.com, ewars...@redhat.com Sent: Thursday, June 21, 2012 10:42:53 AM Subject: Re: your mail On Wed, Jun 20, 2012

Change in vdsm[master]: Remove the traceback from the getVSize warning

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Remove the traceback from the getVSize warning .. Patch Set 9: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5294 To

Change in vdsm[master]: Remove the traceback from the getVSize warning

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Remove the traceback from the getVSize warning .. Patch Set 10: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5294 To

Change in vdsm[master]: Move the SANLock SDM lease to a different offset

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Move the SANLock SDM lease to a different offset .. Patch Set 17: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3840 To

Change in vdsm[master]: Add the hasHostId method to the cluster locks

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Add the hasHostId method to the cluster locks .. Patch Set 16: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3927 To unsubscribe,

Change in vdsm[master]: Internal volumes must be RW in domain version 3

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Internal volumes must be RW in domain version 3 .. Internal volumes must be RW in domain version 3 Signed-off-by: Federico Simoncelli

Change in vdsm[master]: Internal volumes must be RW in domain version 3

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 17: I do not see Eduardo jumping with joy now :-( -- To view, visit http://gerrit.ovirt.org/2786

Change in vdsm[master]: Move the SANLock SDM lease to a different offset

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Move the SANLock SDM lease to a different offset .. Move the SANLock SDM lease to a different offset Signed-off-by: Federico Simoncelli

Change in vdsm[master]: Add the hasHostId method to the cluster locks

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add the hasHostId method to the cluster locks .. Add the hasHostId method to the cluster locks Signed-off-by: Federico Simoncelli fsimo...@redhat.com

Change in vdsm[master]: Remove the traceback from the getVSize warning

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove the traceback from the getVSize warning .. Remove the traceback from the getVSize warning The check used in getVSize to skip the log warnings

Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Fix attachSD and masterMigrate for domain version 3 .. Patch Set 16: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4037 To

Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3

2012-06-21 Thread Haim Ateya
Haim Ateya has posted comments on this change. Change subject: Fix attachSD and masterMigrate for domain version 3 .. Patch Set 16: Verified -- To view, visit http://gerrit.ovirt.org/4037 To unsubscribe, visit

Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix attachSD and masterMigrate for domain version 3 .. Fix attachSD and masterMigrate for domain version 3 Signed-off-by: Federico Simoncelli

Re: [oVirt Jenkins] vdsm_unit_tests - Build # 222 - Still Failing!

2012-06-21 Thread Dan Kenigsberg
On Thu, Jun 21, 2012 at 04:36:15AM -0400, Jenkins oVirt Server wrote: BUILD FAILURE Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/222/ Project: vdsm_unit_tests Date of build: Thu, 21 Jun 2012 04:31:35 -0400 Build duration: 4 min 39 sec CHANGE SET Revision

Change in vdsm[master]: Monitor the host id in domainMonitor

2012-06-21 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Monitor the host id in domainMonitor .. Patch Set 15: (4 inline comments) File

Re: [oVirt Jenkins] vdsm_unit_tests - Build # 222 - Still Failing!

2012-06-21 Thread Federico Simoncelli
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Eduardo Warszawski ewars...@redhat.com, Eyal Edri ee...@redhat.com Cc: aba...@redhat.com, vdsm-patches@lists.fedorahosted.org, fsimo...@redhat.com Sent: Thursday, June 21, 2012 10:56:39 AM Subject: Re: [oVirt Jenkins]

Change in vdsm[master]: Add sanlock-python to the BuildRequires

2012-06-21 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: Add sanlock-python to the BuildRequires .. Add sanlock-python to the BuildRequires Signed-off-by: Federico Simoncelli fsimo...@redhat.com Change-Id:

Change in vdsm[master]: Remove unused qemuImg.py.

2012-06-21 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Remove unused qemuImg.py. .. Remove unused qemuImg.py. Change-Id: Ib3ff2fe876a838306a15b6773aa810c8102e30fa Signed-off-by: Eduardo ewars...@redhat.com --- M

Change in vdsm[master]: Remove unused qemuImg.py.

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Remove unused qemuImg.py. .. Patch Set 1: I would prefer that you didn't submit this I love removing code, but haven't we had high expectations of this module?

Change in vdsm[master]: Fix: chlist as a volume object list in Image.merge().

2012-06-21 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: Fix: chlist as a volume object list in Image.merge(). .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: Fix: chlist as a volume object list in Image.merge().

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix: chlist as a volume object list in Image.merge(). .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: Remove the parameter of clientIF instance from API

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Remove the parameter of clientIF instance from API .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4603 To unsubscribe,

Change in vdsm[master]: Remove the parameter of clientIF instance from API

2012-06-21 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove the parameter of clientIF instance from API .. Remove the parameter of clientIF instance from API Currently, the API clients(like the xmlrpc

Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...

2012-06-21 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 4: Due to bug of libvirt, this patch will not be fully functional until my

Change in vdsm[master]: Remove unused qemuImg.py.

2012-06-21 Thread ewarszaw
Eduardo has posted comments on this change. Change subject: Remove unused qemuImg.py. .. Patch Set 1: This code is not in use. Deserve great expectations? -- To view, visit http://gerrit.ovirt.org/5582 To unsubscribe, visit

Change in vdsm[master]: BZ#833752 - Fix chlist as a volume object list in Image.merg...

2012-06-21 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: BZ#833752 - Fix chlist as a volume object list in Image.merge(). .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5569 To unsubscribe, visit

Change in vdsm[master]: Do not acquire leases on shared volumes

2012-06-21 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: Do not acquire leases on shared volumes .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5521 To

Change in vdsm[master]: virtEnabledInCpuAndBios: return status/proper msg

2012-06-21 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: virtEnabledInCpuAndBios: return status/proper msg .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/3549 To unsubscribe, visit

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: BZ#832199: selinux - move selinux from init to spec .. BZ#832199: selinux - move selinux from init to spec To reduce the time during the init,

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: few years ago, vdsm was asked not to touch host configuration before it is explicitly

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: (2 inline comments) File vdsm.spec.in

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread mburns
Michael Burns has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: I don't see a reason that this change would cause problems in this case. The only possible

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: (2 inline comments) File

Change in vdsm[master]: virtEnabledInCpuAndBios: return status/proper msg

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virtEnabledInCpuAndBios: return status/proper msg .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: BZ#833752 - Fix chlist as a volume object list in Image.merg...

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#833752 - Fix chlist as a volume object list in Image.merge(). .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread agl
Adam Litke has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: (1 inline comment) Looks fine once you fix the indentation error that Dan pointed out.

Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) thank you

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: Looks good to me, approved (1 inline comment) Since we have Mike's ack, I'm good with

Change in vdsm[master]: Add vdsm_reg/config.py to .gitignore

2012-06-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add vdsm_reg/config.py to .gitignore .. Patch Set 1: Looks good to me, approved we should have a test comparing `git ls-files | grep .in` with .gitignore --