Change in vdsm[master]: [WIP]normalize startup: seperate supervdsm framework err and...

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: [WIP]normalize startup: seperate supervdsm framework err and function err .. Patch Set 3: (1 inline comment)

Change in vdsm[master]: [WIP]normalize startup: seperate supervdsm framework err and...

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP]normalize startup: seperate supervdsm framework err and function err .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_te

Change in vdsm[master]: [WIP]normalize startup: seperate supervdsm framework err and...

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP]normalize startup: seperate supervdsm framework err and function err .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/

Change in vdsm[master]: [WIP]normalize startup: seperate supervdsm framework err and...

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP]normalize startup: seperate supervdsm framework err and function err .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_m

Change in vdsm[master]: Improve dom xml gereration

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 5: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Improve dom xml gereration

2013-01-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 5: (1 inline comment) It can pass the libvirtvmTests.py test. File vdsm/l

Change in vdsm[master]: converge IPC file manipulation function in svdsm

2013-01-05 Thread lvroyce
Royce Lv has abandoned this change. Change subject: converge IPC file manipulation function in svdsm .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/10184 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: Improve dom xml gereration

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/610/ : SUCCESS http://jenkins

Change in vdsm[master]: Improve dom xml gereration

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/610/ (2/2) -- To view, visit http

Change in vdsm[master]: Improve dom xml gereration

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve dom xml gereration .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/575/ (1/2) -- To view, visit http://gerrit.ovir

Change in vdsm[master]: Some pep8 indentation fixes

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Some pep8 indentation fixes .. Patch Set 1: I would prefer that you didn't submit this I'm afraid that these problems are fixed commit 9b9208b. When I submit

Change in vdsm[master]: Related to 846307 - Simplifying clientIF._cleanOldFiles().

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles(). .. Patch Set 10: (1 inline comment) Commit Mes

Change in vdsm[master]: Related to 846307 - Simplifying clientIF._cleanOldFiles().

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles(). .. Patch Set 10: I would prefer that you didn't submit this (2 inline comments) A cleaner solution

Change in vdsm[master]: Change log message from warning to debug

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Change log message from warning to debug .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ..

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 2: Looks good to me, approved verified with python-pep8-1.4. thanks! -- To view, visit http://gerrit.ovirt.or

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. PEP 8: fix ignored errors E12{6,7,8} Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Signed-off-by: Zhou Z

Change in vdsm[master]: refactor supervdsm proxy call logic

2013-01-05 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: refactor supervdsm proxy call logic .. Patch Set 2: Verified Tested: vdsm killed, vdsm will restart and start new svdsm; supervdsm killed, vdsm restart new supervdsm

Change in vdsm[master]: refactor supervdsm proxy call logic

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactor supervdsm proxy call logic .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/574/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: refactor supervdsm proxy call logic

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactor supervdsm proxy call logic .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/574/ (1/2) -- To view, visit http://ge

Change in vdsm[master]: refactor supervdsm proxy call logic

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactor supervdsm proxy call logic .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/609/ (2/2) -- To view, v

Change in vdsm[master]: remote serial console via HTTP streaming handler

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: remote serial console via HTTP streaming handler .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10381 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: The original string literal in constants.py.in is right. This patch should not modify it. I update the p

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 2: Verified Pass autobuild.sh. gitpydiff finds no changes on all the files except blockVolume.py . The chan

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/573/ : SUCCESS http://jenkins.ov

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: Pass autobuild.sh. gitpydiff finds no changes on all the files except blockVolume.py . The change is abo

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/608/ (2/2) -- To view,

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/573/ (1/2) -- To view, visit http://g

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: Verified Pass autobuild.sh. gitpydiff finds no changes on all the files except constants.py.in and block

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/572/ : SUCCESS http://jenkins.ov

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/607/ (2/2) -- To view,

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

2013-01-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/572/ (1/2) -- To view, visit http://g

Change in vdsm[master]: Starting svdsm on startup

2013-01-05 Thread lvroyce
Royce Lv has posted comments on this change. Change subject: Starting svdsm on startup .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9691 To unsubscribe, visit http://