Antoni Segura Puimedon has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17772
To unsubscribe, visit http://gerrit.ov
Antoni Segura Puimedon has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1:
(1 comment)
File lib/vdsm/netin
Antoni Segura Puimedon has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1: Code-Review-1
(1 comment)
File
Mark Wu has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/17830
To unsubscribe, visit http://gerrit.o
Mark Wu has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1:
(1 comment)
I agree with that id is not a good variable name in python, but it's also ok
because w
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt configure: drop "--copy" option from "sed" invocation
..
Patch Set 1: Code-Review-1
--copy was required for bind-mouted files on ovirt-node. Please cons
Assaf Muller has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 11: -Verified
Found an issue with a very specific flow. Removing the verified flag.
--
To view
Assaf Muller has uploaded a new change for review.
Change subject: Management network is now kept in main routing table
..
Management network is now kept in main routing table
Only the management network should add its default r
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixing return value of function 'start' in init script
..
Fixing return value of function 'start' in init script
During fixing lock mechanism (http://g
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing return value of function 'start' in init script
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17828
To unsubscribe, visit http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fixing return value of function 'start' in init script
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3819/ : S
Ohad Basan has posted comments on this change.
Change subject: Fixing return value of function 'start' in init script
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/17828
To unsubscribe, visit http://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: Fixing return value of function 'start' in init script
..
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17828
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
..
Patch Set 2: -Code-Review
(1 comment)
File vdsm/vm.py
Line 3
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: return start retval if success instead of always 1
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3818/ :
Ohad Basan has posted comments on this change.
Change subject: vdsm: fix a bug that prevents vdsm from starting
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17828
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3817/ : SUCCE
Giuseppe Vallarelli has posted comments on this change.
Change subject: refactoring: rename variable in getVlanID function
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17830
To unsubscribe, visit http:/
Giuseppe Vallarelli has uploaded a new change for review.
Change subject: refactoring: rename variable in getVlanID function
..
refactoring: rename variable in getVlanID function
In the function getVlanID we're using id as a var
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: fix a bug that prevents vdsm from starting
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3816/ : SUCCESS
Ohad Basan has uploaded a new change for review.
Change subject: vdsm: fix a bug that prevents vdsm from starting
..
vdsm: fix a bug that prevents vdsm from starting
Change-Id: If9a9e89594f136d8e7b41b713e43d64f3702d454
Signed-of
Petr Šebek has posted comments on this change.
Change subject: Don't reconfigure vlan devs unless necessary.
..
Patch Set 4:
(1 comment)
File vdsm/netmodels.py
Line 186:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: [WIP]Get size information of gluster volume
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tes
Aravinda VK has uploaded a new change for review.
Change subject: gluster: [WIP]Get size information of gluster volume
..
gluster: [WIP]Get size information of gluster volume
Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Antoni Segura Puimedon has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 11: Code-Review+1
Thanks!
--
To view, visit http://gerrit.ovirt.org/17575
To unsubsc
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3814/ : SU
Sandro Bonazzola has posted comments on this change.
Change subject: Lock init script when vdsmd starts up until the service is
stopped
..
Patch Set 11:
This patch doesn't work for me. On Fedora 19 I can't start vdsmd service
Assaf Muller has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://ger
Giuseppe Vallarelli has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4:
Hi Alon, I think you might need to customize the pylint for the specific
project. Clearly there might b
Alon Bar-Lev has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4:
I tried this lint in the past, there were many false positives. I retried just
now it with this configuration
Sandro Bonazzola has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17772
To unsubscribe, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3813/ : SUCCESS
http://jenki
Giuseppe Vallarelli has posted comments on this change.
Change subject: lint: providing a default pylintrc
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/17772
To unsubscribe, visit http://gerrit.ovirt.or
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt configure: drop "--copy" option from "sed" invocation
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17813
To unsubscribe, vis
Yeela Kaplan has posted comments on this change.
Change subject: Rename *Volume.extend method to *Volume.enlarge
..
Patch Set 1:
Why?
--
To view, visit http://gerrit.ovirt.org/17802
To unsubscribe, visit http://gerrit.ovirt.o
Zhou Zheng Sheng has abandoned this change.
Change subject: make our udev rules take effect later than default Ubuntu lvm
rules
..
Abandoned
This change will be moved to Ubuntu packaging rules.
--
To view, visit http://gerri
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Load softdog if hardware watchdog is not available
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu.
This patch logically depends on http://g
Zhou Zheng Sheng has posted comments on this change.
Change subject: libvirt configure: drop "--copy" option from "sed" invocation
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu.
--
To view, visit http://gerrit.ov
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu by running xmlrpc functional tests.
To test this patch, we need some extra c
Zhou Zheng Sheng has posted comments on this change.
Change subject: xmlrpcTests: Detect Ubuntu initramfs when booting VM
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu by running xmlrpc functional tests.
--
To vi
Zhou Zheng Sheng has posted comments on this change.
Change subject: xmlrpcTests: Mount configfs automatically
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu by running xmlrpc functional tests.
--
To view, visit h
Zhou Zheng Sheng has posted comments on this change.
Change subject: SecureXMLRPCServer: Work with Official M2Crypto Release
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu by running xmlrpc functional tests.
--
To
Zhou Zheng Sheng has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 4: Verified+1
Test on Fedora, RHEL and Ubuntu.
The new patch
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13: Verified+1
Test on Fedora, RHEL and Ubuntu.
The new patch set is reba
44 matches
Mail list logo
