Sergey Gotliv has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21555
To unsubscribe, visit http://gerrit.ovirt.
Sergey Gotliv has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21556
To unsubscribe, visit http://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 2:
(6 comments)
Can you explain what do we need this strange concept of "safe" or "secured"
class/met
Nir Soffer has posted comments on this change.
Change subject: Introduce util.isOvirtNode()
..
Patch Set 2:
(1 comment)
File vdsm/storage/misc.py
Line 506:
Line 507: fo
Dan Kenigsberg has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 3: Code-Review+2
(1 comment)
File lib/vdsm/util
Dan Kenigsberg has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 4: Code-Review-1
(1 comment)
Nit
File test
Dan Kenigsberg has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 3: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/22114
To unsubscribe, visit h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
elements.
..
vdsm hooks: Add missing "snapshot=no" attribute to "disk" elements.
Missing sna
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
elements.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscri
Dan Kenigsberg has posted comments on this change.
Change subject: Introduce util.isOvirtNode()
..
Patch Set 2: Code-Review-1
(1 comment)
File lib/vdsm/utils.py
Line 1059: @
Alon Bar-Lev has posted comments on this change.
Change subject: Introduce util.isOvirtNode()
..
Patch Set 2:
(1 comment)
File lib/vdsm/utils.py
Line 1059: @memoized
Line 10
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refactor out the metadata access from StoragePool
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5960/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5959/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: add setMasterDomain to StoragePool
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5956/ : SUCCESS
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5957/ : SUCCESS
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5958/ : SUCCESS
http://jenkin
Federico Simoncelli has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 1: Code-Review-1
(1 comment)
File vdsm/st
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: add inquireClusterLock method to StorageDomain
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5952/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove scsiKey from connectStoragePool
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5953/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5954/ : SUCCESS
http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5955/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: avoid masking uuid in StoragePool methods
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5950/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove the getFormat method
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5948/ : SUCCESS
http://jenkins.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5951/ : SUCCESS
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5949/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5947/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5946/ : SUCCESS
http
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: refactor out the metadata access from StoragePool
..
sp: refactor out the metadata access from StoragePool
Change-Id: I75493d1db60e51cccd5231b516f963c
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: consolidate getMasterVersion in one method
..
sp: consolidate getMasterVersion in one method
Change-Id: I8a055c9eb21cc5681d1f9afde5e7eab899aa65c0
Sign
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
sp: _refreshDomainLinks must not change the metadata
Change-Id: I2ecf801d58b34c1c811e311e3779887a4
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
elements.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5
Amador Pahim has posted comments on this change.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
elements.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe, v
Federico Simoncelli has posted comments on this change.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
ellements.
..
Patch Set 2:
(1 comment)
Code is ok but I'd prefer to see the commit message fixe
Federico Simoncelli has posted comments on this change.
Change subject: vdsm hooks: Add missing "snapshot=no" attribute to "disk"
ellements.
..
Patch Set 2: Code-Review+1
(1 comment)
Code is ok but I'd prefer to see the commi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ip monitor: replace pairwise with grouper
..
ip monitor: replace pairwise with grouper
pairwise takes an iterator or elements '123456789' and generates
Dan Kenigsberg has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 3: Code-Review+2
Thanks for noticing the pairwise noise.
--
To view, visit http://gerrit.ovirt.org/2209
Antoni Segura Puimedon has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22092
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5944/ : SUCCESS
http
Dan Kenigsberg has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 2:
(1 comment)
File tests/utilsTests.py
Line 100:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5942/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: forcebridge: attach a vNIC to a bridge outside ovirt
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5941
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduce util.isOvirtNode()
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5943/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5939/ : SUCCESS
http://jenkin
Nir Soffer has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 7:
(3 comments)
Looks good
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/593
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5937/ : SUCCESS
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5940/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: forcebridge: attach a vNIC to a bridge outside ovirt
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5933/ : SUCCESS
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5936/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5935/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/593
Hello Humble Devassy Chirammal,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22124
to review the following change.
Change subject: hook: forcebridge: attach a vNIC to a bridge outside ovirt
..
ho
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 6:
(2 comments)
Dan Kenigsberg has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 1: Code-Review-1
(2 comments)
File tests/mi
Nir Soffer has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6:
(4 comments)
Commit Message
Line 3: AuthorDa
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6:
(7 comments)
Commit Message
Line
Antoni Segura Puimedon has abandoned this change.
Change subject: netinfo: Introduce linkPool
..
Abandoned
redone in another patch.
--
To view, visit http://gerrit.ovirt.org/22057
To unsubscribe, visit http://gerrit.ovirt.org
Antoni Segura Puimedon has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22084
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 3:
(1 comment)
Partial review.
Co
Nir Soffer has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6:
(9 comments)
I like the direction, needs some refinement.
..
Francesco Romani has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit http://gerrit.
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 7:
(1 comment)
File configure.ac
Line 43: AC_PROG
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 8: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5929/ : SUCCESS
h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: janitorial: replace file() with open()
..
vm: janitorial: replace file() with open()
As per docs, open() is preferred to file():
http://docs.python
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
abandon please
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscribe, visit http://gerrit.ovirt.org
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5928/ :
Francesco Romani has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22034
To unsubscribe, visit http://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
(1 comment)
Commit Message
Line 22: jobs, where there is no s
Federico Simoncelli has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 1:
(2 comments)
File tests/main.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5927/ :
73 matches
Mail list logo
