Nir Soffer has posted comments on this change.
Change subject: vdsm: storage replace/remove too generic except handlers
..
Patch Set 2:
Good idea, will review later
--
To view, visit http://gerrit.ovirt.org/17751
To
Arik Hadas has uploaded a new change for review.
Change subject: create VMs in a bulk
..
create VMs in a bulk
Change-Id: Ifd50b9fc694ec7c84b3b39f3d11edb1495842244
Signed-off-by: Arik Hadas aha...@redhat.com
---
M vdsm/API.py
M
oVirt Jenkins CI Server has posted comments on this change.
Change subject: create VMs in a bulk
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6118/ : SUCCESS
Jiří Moskovčák has posted comments on this change.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22424
To unsubscribe, visit
Vered Volansky has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22359
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22424
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Changed BrokerLink log level to prevent log flooding
- vdsm imports the BrokerLink lib with
Nir Soffer has uploaded a new change for review.
Change subject: build: Forbid bare exepct
..
build: Forbid bare exepct
Using bare except is bad practice and is never required. We should
disallow this in new code. This patch
Antoni Segura Puimedon has posted comments on this change.
Change subject: build: Forbid bare exepct
..
Patch Set 1:
(1 comment)
Commit Message
Line 3: AuthorDate:
Nir Soffer has posted comments on this change.
Change subject: build: Forbid bare exepct
..
Patch Set 1:
The implementation is little simplistic, which will cause this commit to be
rejected by jenkins :-)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: build: Forbid bare exepct
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6119/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: build: Forbid bare exepct
..
Patch Set 1:
(1 comment)
File Makefile.am
Line 78: SKIP_PYFLAKES_ERR
Nir Soffer has posted comments on this change.
Change subject: build: Forbid bare exepct
..
Patch Set 1: Verified+1
(1 comment)
File Makefile.am
Line 78: SKIP_PYFLAKES_ERR
Antoni Segura Puimedon has posted comments on this change.
Change subject: build: Forbid bare except
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: build: Forbid bare except
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6120/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: avoid masking uuid in StoragePool methods
..
sp: avoid masking uuid in StoragePool methods
For some unknown reason during an unrelated refactoring
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1: Code-Review+1
ACPI can trigger a reboot too, but we can keep that for later…no need to change
now
--
To
Yaniv Bronhaim has posted comments on this change.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
Patch Set 3: Code-Review+2
please take care of ack on
Nir Soffer has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
Smarten the check so it breaks only when you add forbidden code.
--
To view, visit http://gerrit.ovirt.org/22456
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6121/ : SUCCESS
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath looked for 'path'
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22324
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22456
To unsubscribe, visit
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
[WIP] vdsm: add support for PCI passthrough
required functionality:
* report PCI devices available on host [x]
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Report fake capabilities
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19396
To unsubscribe, visit
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6122/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
disregarding the fact that creating false positive that breaks the build is
extremely easy.
Having a documentation
Saggi Mizrahi has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2: Code-Review+1
This is not a problem in remoteFileHandler so I wouldn't label it as such.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6123/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4:
(1 comment)
File lib/vdsm/tool/upgrade.py
Line 61:
Vered Volansky has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 4: -Code-Review
Huntxu, did you verify against other-than-gluster Storage Domains? Do we
Maor Lipchuk has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 4: Code-Review+1
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
jenkins job with that is redundant, currently we don't check syntax during the
make, that's why we have pep8 and
Assaf Muller has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4:
(1 comment)
File lib/vdsm/tool/upgrade.py
Line 61:
Federico Simoncelli has uploaded a new change for review.
Change subject: hsm: refresh pool connection on connectStoragePool
..
hsm: refresh pool connection on connectStoragePool
This patch ensures that connectStoragePool would
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(2 comments)
File vdsm/ppc64HardwareInfo.py
Line 55:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6124/ : SUCCESS
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8: -Verified
(1 comment)
File vdsm/ppc64HardwareInfo.py
Saggi Mizrahi has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
It does need testing, the file is a black box for us as you
said previously. We can change the
Sergey Gotliv has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22467
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 4: Code-Review+1
(1 comment)
File lib/vdsm/tool/upgrade.py
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(1 comment)
File vdsm/ppc64HardwareInfo.py
Line 55: def
Federico Simoncelli has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 2: Verified+1
Verified running connectStoragePool on an already connected pool.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6125/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6126/ : SUCCESS
Vered Volansky has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22131
To unsubscribe, visit
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 8:
(2 comments)
File vdsm/ppc64HardwareInfo.py
Line 55: def
Yaniv Bronhaim has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1: Code-Review-1
we don't have --pidfile option as part of daemonAdapter, it needs to follow a
patch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6127/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: init: add --pidfile option in vdsmd.service
..
Patch Set 1:
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 9:
(1 comment)
File vdsm/storage/sp.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6128/ : SUCCESS
Vered Volansky has posted comments on this change.
Change subject: sp: remove unused transaction in createMaster
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6129/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 11: Verified+1
connectStoragePool is successful and there's no automatic storage pool
Adam Litke has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21424
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: tests: Add simple mocking library
..
Abandoned
Lets go in way Saggi suggests. This may require more code but it has some
technical advantages, and it will keep Saggi
Nir Soffer has posted comments on this change.
Change subject: build: Forbid bare except:
..
Patch Set 3:
Sagi: we can add smarter check, for example, parse git show output to detect
the edited file, and apply this rule only
Ayal Baron has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 1:
(6 comments)
File vdsm/storage/sp.py
Line 879:
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6130/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 8: Verified+1
Verified with starting and stopping the SPM (lver is incremented) and with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6131/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 3:
This version remove the drive['device'] == 'disk' change. This check seems to
be unneeded and wrong, and will be
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6132/ :
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
I suggest again to rebase this on http://gerrit.ovirt.org/22370, which simplify
the handling
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
The commit message is totally wrong now, and I'm not sure this it the best way
to avoid the
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5: Code-Review+1
I think it is time to move forward with this patch.
--
To view, visit
Nir Soffer has abandoned this change.
Change subject: tests: Add miniaml issciadm tests
..
Abandoned
Nobody seems interested in this.
--
To view, visit http://gerrit.ovirt.org/19856
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Setting force to true overwrites the configuration in libvirt configurer
This
Yaniv Bronhaim has posted comments on this change.
Change subject: Disable configuration overwriting if service is configured
..
Patch Set 3:
the other way around sounds more right to me - specific meaning for force in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Patch Set 1:
Build Successful
Alon Bar-Lev has posted comments on this change.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Patch Set 1:
(1 comment)
File
Assaf Muller has posted comments on this change.
Change subject: netinfo.getRouteDeviceTo: return a device name
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22358
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 3: Code-Review+1
My review is mainly on code style, comments, etc. I can't verify the
Adam Litke has posted comments on this change.
Change subject: sp: remove unused transaction in createMaster
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo.getRouteDeviceTo: return a device name
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6134/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: set reconfigureOnForce attribute to ModuleConfigurer
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22492
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
Patch Set 3: Verified-1
the bug doesn't have rhevm-3.3 flag on it. do we need it to ovirt-3.3 ?
--
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 4:
(4 comments)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6136/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Patch Set 1:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: set reconfigureOnForce attribute to ModuleConfigurer
..
Patch Set 2:
(2 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set reconfigureOnForce attribute to ModuleConfigurer
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6139/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 2:
On pyflakes-0.4.0-2.el6.noarch I see the error that jenkins is complaining on
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 3:
Failure unrelated to patch.
libvirtError: authentication failed: polkit:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6138/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 1:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set reconfigureOnForce attribute to ModuleConfigurer
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6140/ : SUCCESS
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-tool: add node registration tool
..
vdsm-tool: add node registration tool
ovirt-node-registration.py is a tool to register a node into
Yaniv Bronhaim has posted comments on this change.
Change subject: Setting force to true overwrites the configuration in libvirt
configurer
..
Patch Set 1:
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6135/ :
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22494
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: add node registration tool
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6137/ : SUCCESS
1 - 100 of 113 matches
Mail list logo
