Nir Soffer has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 4: Code-Review-1
(6 comments)
See comments
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6654/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: set self._dom to None after destroying vm
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6653/ : SUCCESS
h
Jarod.w has posted comments on this change.
Change subject: vm: set self._dom to None after destroying vm
..
Patch Set 3: Verified+1
Test passed on:
libvirt: 1.0.5.7
qemu: 1.5.3.0-2.355
--
To view, visit http://gerrit.ovirt.o
Jarod.w has posted comments on this change.
Change subject: vm: set self._dom to None after destroying vm
..
Patch Set 2:
(1 comment)
Commit Message
Line 5: CommitDate: 2014
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: Log unhandled exception for new Thread
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6652/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: Log unhandled exception for new thread
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6650/ : FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Log unhandled exception for new Thread
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6651/ : FAILUR
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bindingXMLRPC: Log unhandled exception for new Thread
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/664
Maor Lipchuk has uploaded a new change for review.
Change subject: vm: Log unhandled exception for new Thread
..
vm: Log unhandled exception for new Thread
Adding a traceback log for unhandled exceptions when execute
_startUnder
Maor Lipchuk has uploaded a new change for review.
Change subject: misc: Log unhandled exception for new thread
..
misc: Log unhandled exception for new thread
Adding a traceback log for unhandled exceptions when execute
_emit a
Maor Lipchuk has uploaded a new change for review.
Change subject: bindingXMLRPC: Log unhandled exception for new Thread
..
bindingXMLRPC: Log unhandled exception for new Thread
Adding a traceback log for unhandled exceptions wh
Maor Lipchuk has uploaded a new change for review.
Change subject: ifcfg: Log unhandled exception for new Thread
..
ifcfg: Log unhandled exception for new Thread
Ading a traceback log for unhandled exceptions,
when openning a ne
Nir Soffer has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 3:
(2 comments)
Commit Message
Line 4: Commit:
Nir Soffer has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 3:
(5 comments)
Can be done with much less work from vm/clientIF.
..
Nir Soffer has posted comments on this change.
Change subject: clientIF: replace type() with isinstance()
..
Patch Set 1: Code-Review-1
(3 comments)
This does not fix anything.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: Return recovery error until hsm is ready
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6648/ : SUCC
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: Return recovery error until hsm is ready
..
Patch Set 6: Verified+1 Code-Review+2
I find Nir's responses satisfactory. Fixing commit message, copying
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: Return recovery error until hsm is ready
..
bootstrap: Return recovery error until hsm is ready
When constructing HSM, a background thread i
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: Rescan multipath before loading lvm cache
..
hsm: Rescan multipath before loading lvm cache
lvm cache was loaded before multipath rescan, loading
Federico Simoncelli has posted comments on this change.
Change subject: hsm: Rescan multipath before loading lvm cache
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21567
To unsubscribe, visit http://
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Unify checks for vdsm image
..
vm: Unify checks for vdsm image
When testing if dict or vm.Drive object are vdsm image, we have to do
an ugly type c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: Fix exception re-raising in RollbackContext
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6647/ : SUCCE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Rename migration_timeout to migration_downtime_delay
Previously the migration_timeout value was
Adam Litke has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 3: Verified+1
Updated this patch to address Federico's concerns. Also, I've added a new
functio
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Avoid going into 'Paused' status during long lasting migrations
If a migration is ta
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Introduce a maximum time limit a migration may take
..
Introduce a maximum time limit a migration may take
There are cases where migrations can take to
Federico Simoncelli has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit http://gerrit.ovirt.or
Dan Kenigsberg has submitted this change and it was merged.
Change subject: misc: Fix exception re-raising in RollbackContext
..
misc: Fix exception re-raising in RollbackContext
Former code assumed that exc_value argument is a
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21181
To unsubscr
Dan Kenigsberg has posted comments on this change.
Change subject: misc: Fix exception re-raising in RollbackContext
..
Patch Set 10: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, vis
Yaniv Bronhaim has posted comments on this change.
Change subject: Gluster API verbs will now be callable again
..
Patch Set 2: Code-Review-1
where is the automation script? the commit msg must specify public bug. please
do..
Dan Kenigsberg has posted comments on this change.
Change subject: Gluster API verbs will now be callable again
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23045
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: avoid redundant domain produce() in createStoragePool
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6646/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6645/
Vitor de Lima has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit http:
Daniel Erez has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 3:
(1 comment)
File vdsm/storage/hsm.py
Line 29
Dan Kenigsberg has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21786
To unsubscribe, visit http://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: refresh metadata on hsm when listing domains
..
sp: refresh metadata on hsm when listing domains
Previously to get the most updated domains list we
Nir Soffer has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5: Code-Review+1
Looks good.
--
To view, visit http://gerrit.ovirt.org/21786
To unsubscribe, visit h
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 3:
(3 comments)
File vdsm/clientIF.py
L
Ayal Baron has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: add inquireClusterLock method to StorageDomain
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6644/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: securable: refactor the securable implementation
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6643/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit htt
Nir Soffer has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5:
And there seems to be a rebase here, making it hard to review changes between
patch set 4 and 5.
Nir Soffer has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5: Code-Review-1
Federico, is this only commit message change? looks like the code also changed
(I ju
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6639/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: receive domains map in connectStoragePool
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6641/ : SUCCESS
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: improve pool creation error handling
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6640/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refactor out the metadata access from StoragePool
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/664
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6638/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13: Verified+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21786
To unsubscribe, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6637/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6635/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6636/ : SUCCESS
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6634/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 10: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/663
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6633/ : SU
Nir Soffer has posted comments on this change.
Change subject: securable: refactor the securable implementation
..
Patch Set 3:
Can you address comments from the previous patch, and explain whats new in this
patch set?
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
Federico Simoncelli has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 6: Verified+1
Minor name change.
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscri
Federico Simoncelli has posted comments on this change.
Change subject: sp: refresh metadata on hsm when listing domains
..
Patch Set 5: Verified+1
Commint message changes.
--
To view, visit http://gerrit.ovirt.org/21786
To u
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 12:
(1 comment)
File vdsm/vm.py
Line 7
Vinzenz Feenstra has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6630/ : SUC
Vinzenz Feenstra has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 10:
(1 comment)
File vdsm/vm.py
Line 2
Dan Kenigsberg has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 10:
(1 comment)
File vdsm/vm.py
Line 255
Vinzenz Feenstra has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 8:
(1 comment)
File vdsm/vm.py
Line 25
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 8: Code-Review-1
(1 comment)
File vdsm/v
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 11: Code-Review+2
(1 comment)
Minor textual glitch.
.
Dan Kenigsberg has posted comments on this change.
Change subject: Extend setupNetworks API to accept defaultRoute
..
Patch Set 1: Code-Review-1
(4 comments)
File lib/vdsm/t
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 2:
(3 comments)
File vdsm/guestIF.py
Line 1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6628/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: additional parsing of host UUID in verb
glusterVolumesList
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_ge
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: set self._dom to None after destroying vm
..
Patch Set 2:
(1 comment)
Minor typo in the commit message. Glad to see this error going away.
Thanks!
Vinzenz Feenstra has posted comments on this change.
Change subject: clientIF: replace type() with isinstance()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23056
To unsubscribe, visit http://gerrit.
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 10:
(3 comments)
Commit Mes
Vinzenz Feenstra has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit http://
Vinzenz Feenstra has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/21963
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Replaced all too generic except: handlers in vm.py
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17740
To unsubscribe, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6626/ : SUCCESS
Daniel Erez has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 2:
(1 comment)
File vdsm/storage/hsm.py
Line 30
Daniel Erez has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 2:
Yes, the point was indeed to update the size only when running a VM since
monitoring it might be
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: update size of LUN volume in prepareVolume
..
Patch Set 2:
(1 comment)
I miss the big picture. It seems to me that the lun size is fetched only when
Francesco Romani has posted comments on this change.
Change subject: clientIF: replace type() with isinstance()
..
Patch Set 1: Verified+1
Verified using those tests:
http://gerrit.ovirt.org/#/c/22928/5/tests/clientifTests.py;
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long lasting migrations
..
Patch Set 10:
(3 comments)
Commit Messa
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: move _updateTimestamp to API.py
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6625/ : SUCCESS
http:/
Assaf Muller has posted comments on this change.
Change subject: Gluster API verbs will now be callable again
..
Patch Set 2: Verified+1
Same patch merged in master.
--
To view, visit http://gerrit.ovirt.org/23045
To unsubscr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: move _updateTimestamp to API.py
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6624/ : SUCCESS
http:/
Assaf Muller has posted comments on this change.
Change subject: cleanup: move _updateTimestamp to API.py
..
Patch Set 5: Code-Review+1
Oh, didn't notice that patch set 4 moved it back to static (Patch set 3 moved
it to module
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: replace type() with isinstance()
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/23056
To unsubscribe, visit http://gerrit.ov
Assaf Muller has posted comments on this change.
Change subject: cleanup: move _updateTimestamp to API.py
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23050
To unsubscribe, visit http://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: Gluster API verbs will now be callable again
..
Patch Set 3: Code-Review+2
Oh, so you DID move it to the module level, after having convinced everybody
that @s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Gluster API verbs will now be callable again
..
Gluster API verbs will now be callable again
Fix regression introduced in #22837.
When wrapping Gluste
1 - 100 of 111 matches
Mail list logo
