Douglas Schilling Landgraf has posted comments on this change.
Change subject: lvm: Disable usage of lv_metad daemon
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25408
To unsubscribe, visit http://ge
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
A test for move a static value for constant? I don't get it.
--
To view, visit http://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: vm iface stats: fix arithmetic
..
Patch Set 2: Verified+1
built ovirt-3.3 with this patch, and verified that
vdsClient -s 0 getAllVmStats|grep netw
still fli
Dan Kenigsberg has posted comments on this change.
Change subject: vm iface stats: fix arithmetic
..
Patch Set 1: Verified+1
vdsClient -s 0 getAllVmStats|grep netw
reports network statistics
--
To view, visit http://gerrit.o
Dan Kenigsberg has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 4: Verified+1
Built vdsm with git7959d6e, installed it, and saw that
vdsClient -s 0 getAllVmStats|grep
Dan Kenigsberg has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 19: Verified-1
Please notice the repeated failure of your new tests - do not set Verified
whil
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26123/2//COMMIT_MSG
Commit Message:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 1: Code-Review+1
Please verify the patch.
--
To view, visit http://gerrit.ovirt.org/2
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(8 comments)
Hello Yeela, few comments.
http://gerrit.ovirt.org/#/c/26123/2
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
I got from cherry-pick:
Automatic cherry-pick failed. After re
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6876/ : SUCCESS
h
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2: Verified+1
Move profile to /var/run/vdsm, protecting from symlink attacks.
Verified by running with and
Nir Soffer has posted comments on this change.
Change subject: Improve logging on some filesystem operations
..
Patch Set 2:
(10 comments)
I agree with Allon, that we better have the logs *before* the operation, and
not after
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(3 comments)
Very very partial review.
Note the persistent pep8 errors
l
Dan Kenigsberg has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 7: Code-Review-1
el6's pyflakes seems to dislike the added code
./vdsm/API.py:30: redefinition of unused 'pickle'
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6875/ : FAIL
mooli tayer has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerri
mooli tayer has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 18: Verified+1
Verified both tests and normal vdsm-tool usage:
[root@dumbo RPMS]# vdsm-tool confi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6874/ :
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Verified+1
multipath is configurated when using vdsm-tool, under the same conditions as
be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6873/ : SUCCESS
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/25927/8/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_ho
Yeela Kaplan has uploaded a new change for review.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Move multipath configuration to vdsm-tool configurator
Previously multipathe is recofigured on each vds
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add logging to fs operations in supervdsmServer
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6871/ : SUCCE
Barak Azulay has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 8:
(1 comment)
Vinzenz - please take a look on the guest info data being randomized.
http://gerrit.ovirt.org/#/c/
Xavi Francisco has uploaded a new change for review.
Change subject: Add logging to fs operations in supervdsmServer
..
Add logging to fs operations in supervdsmServer
The motivation of this patch is to increase the logging of s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6870/ :
Nir Soffer has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1:
I'll test if signal handler works, but surly 2 second wait for shutdown is too
little.
--
To vie
Nir Soffer has posted comments on this change.
Change subject: profiling: Add whole application profile
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26113/1/vdsm/vdsm
File vdsm/vdsm:
Line 88: if config.getb
Dan Kenigsberg has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1:
There used to be nasty constraints on the time it takes to do `vdsmd restart`.
If it takes too
Antoni Segura Puimedon has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26070
To unsubscribe, visit http://gerrit.ov
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: Optimize namedtuple definition in pidStat
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26097
To unsubscribe, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6869/ : FAILURE
http://jenkins.ov
Dan Kenigsberg has posted comments on this change.
Change subject: profiling: Add whole application profile
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26113/1/vdsm/vdsm
File vdsm/vdsm:
Line 88:
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 7: Verified+1
re-ticking Verified after some data has being provided.
--
To view, visit http://gerrit.ovirt.org/
Tal Nisan has posted comments on this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26109/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Barak Azulay has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 5:
In addition the bug in the bug-url is on the ebngine-core
--
To view, visit http://gerrit.ovirt.org/25926
To unsu
Barak Azulay has posted comments on this change.
Change subject: sampling: Collect kdump status
..
Patch Set 5: Code-Review-1
This should not be reported as a part of the stats, but as a part of
capabilities. once configured i
Nir Soffer has posted comments on this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26109/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6868/ : SUCCESS
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6867/ : SUCCESS
http://je
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
tested on ISCSI (block storage).
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, visit http
Francesco Romani has posted comments on this change.
Change subject: profiling: Add whole application profile
..
Patch Set 1: Code-Review+1
Definitely more polished and more refined solution of what I did so far
Looks fine, and
Francesco Romani has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1:
That could easily explain why some profile data was sometimes missing from my
test. Good fin
Nir Soffer has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1: Verified+1
Verified by running and stopping vdsm.
--
To view, visit http://gerrit.ovirt.org/26111
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1: Verified+1
Verified by running and stopping vdsm.
--
To view, visit http://gerrit.ovirt.org/26112
To unsubscri
Nir Soffer has posted comments on this change.
Change subject: profiling: Add whole application profile
..
Patch Set 1: Verified+1
Verified running with and without the profiler and displaying profiler rsults
using pstats.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add whole application profile
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6866/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6865/ : SUCCESS
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sysvinit: Give vdsm enough time to write profile
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6864/ : SUCC
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Add whole application profile
..
profiling: Add whole application profile
The built in Python profilers are good for single thread profile but
given the
Nir Soffer has uploaded a new change for review.
Change subject: clientIF: Clean up shutdown process
..
clientIF: Clean up shutdown process
clientIF.serve used to check if shutdown process has started once every
3 seconds, leadi
Nir Soffer has uploaded a new change for review.
Change subject: sysvinit: Give vdsm enough time to write profile
..
sysvinit: Give vdsm enough time to write profile
Previously vdsm was killed brutally if it did exit 2 seconds a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6863/ : SUCCESS
http://je
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6862/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6861/ : SUCCESS
http://jenkins
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 5: Verified+1
after patch set 3, only changes to functional test to ensure cleanup of VM
being
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 4: Verified+1
verified manually + functional test patch set 3 together with 25276
verified with functional
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6860/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6859/ : SUCCESS
http:
Dan Kenigsberg has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 2: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/26070/2//COMMIT_MSG
Commit Message:
Line 5: CommitDa
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6858/ : SUCCE
Tal Nisan has uploaded a new change for review.
Change subject: Fix a reference before assignment bug in Hsm.py
..
Fix a reference before assignment bug in Hsm.py
https://bugzilla.redhat.com/show_bug.cgi?id=1080106
Signed-off-by
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 3: Verified+1
verification:
* verified together with 25725
* new functional test pass OK
* done
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6856/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6857/ : SUCC
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Lin
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25275/2/vdsm/vm.py
File vdsm/vm.py:
Line 2378: se
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6855/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6854/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6853/ : SUCCESS
http://je
Francesco Romani has posted comments on this change.
Change subject: utils: Optimize namedtuple definition in pidStat
..
Patch Set 1: Code-Review+1
good finding!
--
To view, visit http://gerrit.ovirt.org/26097
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Optimize namedtuple definition in pidStat
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26097
To unsubscribe, visit http://ger
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
please check if it possible to rebase it over
http://gerrit.ovirt.org/#/c/25263/ (which will be merge r
Yaniv Bronhaim has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 17: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25263/17/tests/toolTests.py
File tes
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Optimize namedtuple definition in pidStat
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26097
To unsubscribe, visit http://ger
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 366: ['
I a
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26055/4/lib/vdsm/tool/configurator.py
File lib/vdsm/to
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ov
81 matches
Mail list logo
