Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Change cpopen import .. Patch Set 1: please verify -- To view, visit http://gerrit.ovirt.org/26204 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Change cpopen import .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26204 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: clientIF: Remove unused _memLock

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Remove unused _memLock .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6936/ : SUCCESS http://jenk

Change in vdsm[master]: clientIF: Remove unused _memLock

2014-03-29 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: clientIF: Remove unused _memLock .. clientIF: Remove unused _memLock _memLock was used by memTestAndCommit(), which was removed in 6fcfb09456 on May 2011. Change-

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 4: (1 comment) Note about "faster" http://gerrit.ovirt.org/#/c/26070/4/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: (1 comment) How to remove the boilerplate using permutations. http://gerrit.ovirt.org/#/c/26070/5/tests/utilsTe

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 674

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 674: if

Change in vdsm[master]: network: Introduce the network package

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: Introduce the network package .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6925/ : SUCCESS http:

Change in vdsm[master]: Create GuestAgent instance in __init__ and connect later

2014-03-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Create GuestAgent instance in __init__ and connect later .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26142 To unsubscribe,

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26070/5/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: utils: Change cpopen import .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26204 To unsubscribe, visit http://gerrit.ovirt.org

Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS

2014-03-29 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: make virtTests run on RHEL/CentOS .. Patch Set 2: Code-Review+1 Thanks for the formatting change ;-) -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: virt: migration: move threads in a separate module

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 7: (2 comments) Possible improvement. http://gerrit.ovirt.org/#/c/25970/7/vdsm/virt/vm.py File vds

Change in vdsm[master]: virt: migration: move threads in a separate module

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 7: Code-Review+1 Assuming that you did not change the moved code. -- To view, visit http://gerrit.

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: Code-Review+1 (2 comments) Nice http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: init: Normalize shutdown timeout

2014-03-29 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 3: Code-Review+1 code is ok, I still think that in heavily loaded systems 10 seconds is very short. -- To view, v

Change in vdsm[master]: init: Normalize shutdown timeout

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6935/ : SUCCESS http://jenk

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 5: Rebased over dependent patch. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit htt

Change in vdsm[master]: clientIF: Clean up shutdown process

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Clean up shutdown process .. Patch Set 3: Rebased over dependent patch. -- To view, visit http://gerrit.ovirt.org/26112 To unsubscribe, visit http://ger

Change in vdsm[master]: init: Normalize shutdown timeout

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 3: Verified+1 Remove the duplication and make the sysvinit version more clear using autoconf variable. Verified that

Change in vdsm[master]: clientIF: Clean up shutdown process

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Clean up shutdown process .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6933/ : SUCCESS http://j

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6934/ : SUCCESS h

Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Change cpopen import .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26204 To unsubscribe, visit http://gerrit.ovirt.org/settings G

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 674: if

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6932/ : SUCCESS http://je

Change in vdsm[master]: util: fix execCmd to accept tuples

2014-03-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/26070/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 53: import

Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Change cpopen import .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6931/ : SUCCESS http://jenkins.o

Change in vdsm[master]: utils: Change cpopen import

2014-03-29 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: utils: Change cpopen import .. utils: Change cpopen import Change cpopen import so utils wouldn't use a local copy of CPopen. Change-Id: I128940e76da926e1073

Change in vdsm[master]: vdsm: Catch the destkopLock AttributeError on Migration

2014-03-29 Thread vfeenstr
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Catch the destkopLock AttributeError on Migration .. Abandoned http://gerrit.ovirt.org/26142 will solve this nicer -- To view, visit http://gerrit.ovirt.org/14