Dan Kenigsberg has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26413/2/vdsm/storage/fileSD.py
File vdsm/storage/file
Dan Kenigsberg has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26412/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 54: IDS
Dan Kenigsberg has posted comments on this change.
Change subject: unified pers: fix restoration when moving from ifcfg pers
..
Patch Set 2: Code-Review+2
same as master
--
To view, visit http://gerrit.ovirt.org/26373
To unsu
Dan Kenigsberg has posted comments on this change.
Change subject: Do not allow empty network names (bridged nor bridgeless)
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26367
To unsubscribe, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 11: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/25877/11//COMMIT_MSG
Commit Message:
Line 5
Dan Kenigsberg has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25275/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1969:
Dan Kenigsberg has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 6: Code-Review-1
(5 comments)
very partial review
http://gerrit.ovirt.org/#/c/25276/6/tests/func
Dan Kenigsberg has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26426/1//COMMIT_MSG
Commit Message:
Line 15:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: lib cleanups for pep-1.5.x
..
pep8: lib cleanups for pep-1.5.x
lib/* is now pep8 1.5.x clean.
Change-Id: I145fb9520219678d24d17698af618b44071ecb
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: lib cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26425
To unsubscribe, visit http://gerrit.ovirt.org/se
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: storage cleanups for pep-1.5.x
..
pep8: storage cleanups for pep-1.5.x
storage/* is now pep8 1.5.x clean.
Change-Id: I49d4e4e59101ea54759a700644
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: storage cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26424
To unsubscribe, visit http://gerrit.ovirt.or
Federico Simoncelli has posted comments on this change.
Change subject: fileSD: enable mailbox on file domains
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/26412
* http://gerrit.ovirt.org/26413
* http://
Federico Simoncelli has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/26412
* http://gerrit.ovirt.org/2641
Federico Simoncelli has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/26412
* http://gerrit.ovirt.org/26413
* http://g
Federico Simoncelli has posted comments on this change.
Change subject: volumeTests: add BlockDomainMetadataSlotTest
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/25988
* http://gerrit.ovirt.org/26265
* h
Federico Simoncelli has posted comments on this change.
Change subject: blockSD: rename mapMetaOffset to getVolumeMetadataSlot
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/25988
* http://gerrit.ovirt.org
Federico Simoncelli has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 3: Verified+1
Verified with:
* http://gerrit.ovirt.org/25988
* http://gerrit.ovirt.or
Federico Simoncelli has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.p
Federico Simoncelli has posted comments on this change.
Change subject: pep8: storage cleanups for pep-1.5.x
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26424
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Explicitly close libvirt connections at exist
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7074/ : FAILURE
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Explicitly close libvirt connections at exist
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: rename mapMetaOffset to getVolumeMetadataSlot
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7072/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7070/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volumeTests: add BlockDomainMetadataSlotTest
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7071/ : FAILURE
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7069/ : FAILURE
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: enable mailbox on file domains
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7068/ : FAILURE
http://je
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7067/ : F
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: use constants for counter bounds
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24194/1/vdsm/sampling.py
File vdsm/sampling.py:
Line 43:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
..
vm tests: avoid leaving /tmp/blechs.recovery behind
There's code that expects P_VDSM_VAR_RUN to
Dan Kenigsberg has posted comments on this change.
Change subject: vm tests: avoid leaving /tmp/blechs.recovery behind
..
Patch Set 1: Verified+1 Code-Review+2
./run_tests.sh functional/vmTests.py no longer creates zillion .rec
Dan Kenigsberg has posted comments on this change.
Change subject: oop: remove unused properties
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26174/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 20
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/454/ :
SUCCESS
--
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm_reg: remove engine.py.in
..
vdsm_reg: remove engine.py.in
engine.py.in was stored in vdsm_reg as part of ovirt-node
TUI registration stuff. Curren
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2:
jenkins failure not related to patch
./vdsm/network/sourceroute.py:159: list comprehension redefines '
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm_reg: remove engine.py.in
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26411
To unsubscribe, visit http://gerrit.ovirt.
Antoni Segura Puimedon has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26426/1/vdsm/clientIF.py
File vdsm/clie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Allow moving of sparse images to a block domains
..
Allow moving of sparse images to a block domains
When attempting to move a sparse image from a file
Dan Kenigsberg has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/25778/8/vdsm/storage/image.py
File vdsm/storage/image.
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25275/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1969:
Amador Pahim has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit htt
Dan Kenigsberg has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25275/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Lin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7066
Francesco Romani has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/26426/1/vdsm/clientIF.py
File vdsm/clientIF.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add logging on some filesystem operations
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7065/ : FAILURE
http:/
Michal Skrivanek has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7:
not sure if "playback" is useful, but it's missing from the list. I don't need
i
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/API.py
File vdsm/API.py:
Line 379: def h
Amador Pahim has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7:
(4 comments)
http://gerrit.ovirt.org/#/c/22178/7/vdsm_hooks/spiceoptions/before_vm_s
Francesco Romani has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26426/1/vdsm/clientIF.py
File vdsm/clientIF.p
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8: Code-Review-1
(10 comments)
Mostly minor things and a few questions
http://gerrit.ovirt.org/#/c/19
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7064/ : FAILURE
http:/
Antoni Segura Puimedon has posted comments on this change.
Change subject: recovery: clean the VM recovery procedure
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26426/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Francesco Romani has uploaded a new change for review.
Change subject: recovery: clean the VM recovery procedure
..
recovery: clean the VM recovery procedure
This tiny patch cleans up and optimizes the VM recovery detection.
Whi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: lib cleanups for pep-1.5.x
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7063/ : FAILURE
http://jenkins.
Francesco Romani has posted comments on this change.
Change subject: pep8: lib cleanups for pep-1.5.x
..
Patch Set 1: Verified+1
Verified using gitpydiff and running unit tests
--
To view, visit http://gerrit.ovirt.org/26425
Francesco Romani has uploaded a new change for review.
Change subject: pep8: lib cleanups for pep-1.5.x
..
pep8: lib cleanups for pep-1.5.x
lib/* is now pep8 1.5.x clean.
Change-Id: I145fb9520219678d24d17698af618b44071ecbf4
Sig
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: storage cleanups for pep-1.5.x
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7062/ : FAILURE
http://jenk
Francesco Romani has posted comments on this change.
Change subject: pep8: storage cleanups for pep-1.5.x
..
Patch Set 1: Verified+1
Mostly trivial changes: spacing or from 'Not X in Y' -> 'X not in Y'
Verified running unit tes
Francesco Romani has uploaded a new change for review.
Change subject: pep8: storage cleanups for pep-1.5.x
..
pep8: storage cleanups for pep-1.5.x
storage/* is now pep8 1.5.x clean.
Change-Id: I49d4e4e59101ea54759a700644f04c94
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Code-Review+1
Yaniv, per process the bug status is correct. The bug is 3.4. It just hasn't
bee
Michal Skrivanek has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/25276/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7060/ : FAILURE
http://je
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7061/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 4:
Patch set 5:
* improved the commit message
* renamed the exception as suggested to avoid confusion
--
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 4:
(4 comments)
http://gerrit.ovirt.org/#/c/25275/4//COMMIT_MSG
Commit Message:
Line 21: Id495f6047ba658
Francesco Romani has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7:
(5 comments)
http://gerrit.ovirt.org/#/c/22178/7/vdsm_hooks/spiceoptions/before_
67 matches
Mail list logo
