Change in vdsm[master]: vdsm_config: move download certificate

2014-05-04 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 25: (2 comments) http://gerrit.ovirt.org/#/c/26718/25/vdsm_reg/vdsm-reg-setup.in File vdsm_reg/vdsm-reg-setup

Change in vdsm[master]: vdsm_config: move download certificate

2014-05-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 25: Jenkins failure not related to patch. testLibvirtConfigureToSSLFalse

Change in vdsm[master]: vdsm_config: move download certificate

2014-05-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8515/ : SUCCESS http://jen

Change in vdsm[master]: vdsm_config: move download certificate

2014-05-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm_config: move download certificate .. Patch Set 25: Verified+1 Tested against branch ovirt-3.4 and worked autoinstall via http and https -- To

Change in vdsm[master]: hooks: macbind - Attach vm nics to specified bridge

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: macbind - Attach vm nics to specified bridge .. Patch Set 7: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/17895/7/vdsm.spec.in File vdsm.spec.

Change in vdsm[master]: storage: check if mount specification is a symlink

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: storage: check if mount specification is a symlink .. Patch Set 1: Would you please modify tests/mountTests.py so that it tests for the bug that you are fixing

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/547/

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Code-Review+2 Escalating score. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, vis

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: profiling: Add an application wide profile .. profiling: Add an application wide profile The built in Python profilers are good for single thread profi

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Escalating score. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit http://gerr

Change in vdsm[ovirt-3.4]: vdsm-reg: eliminate the VDSMBRIDGE macro

2014-05-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro .. Patch Set 1: Hi Yaniv, there is no bug for this one. -- To view, visit http://gerrit.ovirt.org/27320 T

Change in vdsm[master]: config: Make it easy to create default config

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: config: Make it easy to create default config .. Patch Set 2: Code-Review+2 globals are ugly! -- To view, visit http://gerrit.ovirt.org/25504 To unsubscribe,

Change in vdsm[master]: config: Make it easy to create default config

2014-05-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: config: Make it easy to create default config .. config: Make it easy to create default config Previously a default config object was created by invoki

Change in vdsm[ovirt-3.3]: fileUtils: Make memory filesystems support configurable

2014-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileUtils: Make memory filesystems support configurable .. Patch Set 1: I agree with you that the hidden file system check is evil and wrong. But I don't think that

Change in vdsm[ovirt-3.4]: core: return lver/spm id from pool metadata

2014-05-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: core: return lver/spm id from pool metadata .. core: return lver/spm id from pool metadata Currently the lver/spm id are being returned as they appear

Change in vdsm[ovirt-3.4]: core: fixing attribute error on fenceSpmStorage

2014-05-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: core: fixing attribute error on fenceSpmStorage .. core: fixing attribute error on fenceSpmStorage In change I75493d1db60e51cccd5231b516f963c970d24c99

Change in vdsm[ovirt-3.4]: core: fixing attribute error on fenceSpmStorage

2014-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27341 To unsubscribe, visit http://gerr

Change in vdsm[ovirt-3.4]: core: return lver/spm id from pool metadata

2014-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: return lver/spm id from pool metadata .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27340 To unsubscribe, visit http://gerrit.o

Change in vdsm[master]: Add logging on some filesystem operations

2014-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Add logging on some filesystem operations .. Patch Set 3: Xavi, please publish this patch. You should have a "Publish" button in gerrit, or just push a new version

Change in vdsm[master]: Change file permissions using ioprocess

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Change file permissions using ioprocess .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27268/1/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProc

Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit http

Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27267/1/vdsm/storage/outOfProcess.p

Change in vdsm[ovirt-3.4]: core: return lver/spm id from pool metadata

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: core: return lver/spm id from pool metadata .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27340 To unsubscribe, visit http://gerrit.o

Change in vdsm[ovirt-3.4]: core: fixing attribute error on fenceSpmStorage

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27341 To unsubscribe, visit http://gerr

Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 2: I'll give +1 once you address dougsland's comment -- To view, visit http://gerrit.ovirt.org/2

Change in vdsm[ovirt-3.4]: core: fixing attribute error on fenceSpmStorage

2014-05-04 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage .. Patch Set 1: Verified+1 verified fence scenario with http://gerrit.ovirt.org/#/c/27340/ -- To view, visit http://

Change in vdsm[ovirt-3.4]: core: return lver/spm id from pool metadata

2014-05-04 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: return lver/spm id from pool metadata .. Patch Set 1: Verified+1 verified fence scenario with http://gerrit.ovirt.org/#/c/27341 -- To view, visit http://gerri

Change in vdsm[master]: glob.glob ioprocess implementation

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: glob.glob ioprocess implementation .. Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26967/5/vdsm/storage/outOfProcess.py File vdsm/storage/

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-05-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 7: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/26576/7/vdsm/storage/outOfProcess.py F

Change in vdsm[ovirt-3.4]: core: return lver/spm id from pool metadata

2014-05-04 Thread laravot
Hello Nir Soffer, Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/27340 to review the following change. Change subject: core: return lver/spm id from pool metadata .. core: retu

Change in vdsm[ovirt-3.4]: core: fixing attribute error on fenceSpmStorage

2014-05-04 Thread laravot
Hello Nir Soffer, Federico Simoncelli, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/27341 to review the following change. Change subject: core: fixing attribute error on fenceSpmStorage ..

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm

Change in vdsm[ovirt-3.3]: libvirt_configure: persist /etc/libvirt/qemu-sanlock.conf

2014-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: libvirt_configure: persist /etc/libvirt/qemu-sanlock.conf .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27335 To unsubscribe, visit h

Change in vdsm[ovirt-3.4]: vdsm-reg: eliminate the VDSMBRIDGE macro

2014-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro .. Patch Set 1: should I expect bug for that fix? if you have such please add the url, if not please note it -- To v

Change in vdsm[ovirt-3.4]: vdsm-reg: eliminate the VDSMBRIDGE macro

2014-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27320 To unsubscribe, visit http://gerrit.ovir

Change in vdsm[master]: Add logging on some filesystem operations

2014-05-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: Add logging on some filesystem operations .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit http://gerrit.ovi