Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/27258/11/vdsm/virt/vm.py File

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 12: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 13: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 14: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 15: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8935/ :

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/27272/14/vdsm/mom.d/04-cputune.policy File vdsm/mom.d/04-cputune.policy: Line

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 16: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8936/ :

Change in vdsm[master]: json-rpc: Protocol detection

2014-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/26300/14/vdsm/protoDetector.py File vdsm/protoDetector.py: Line 177:

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 17: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8937/ :

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 15: Build Failed

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 18: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8938/ : SUCCESS

Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 1: Verified-1 -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8940/ : SUCCESS

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 11: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/26576/11/vdsm/storage/outOfProcess.py

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 11: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit

Change in vdsm[master]: glob.glob ioprocess implementation

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: glob.glob ioprocess implementation .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit

Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8943/ : SUCCESS

Change in vdsm[master]: Adding updateVmPolicy api

2014-05-18 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 20: Verified+1 -- To view, visit http://gerrit.ovirt.org/27272 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 18: Verified+1 -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 17: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 18: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Change file permissions using ioprocess

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Change file permissions using ioprocess .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27268 To unsubscribe, visit

Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Patch Set 6: Code-Review-1 (3 comments)

Change in vdsm[master]: Implement rest of os and os.path functionality

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Implement rest of os and os.path functionality .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit

Change in vdsm[master]: Remove unused remote file handler method (directWriteLines)

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Remove unused remote file handler method (directWriteLines) .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27640 To unsubscribe, visit

Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit

Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit

Change in vdsm[master]: keep pauseCode when migrating paused VM

2014-05-18 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: keep pauseCode when migrating paused VM .. keep pauseCode when migrating paused VM This patch fix a bug where the pauseCode is cleared on the destination host

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 16: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: keep pauseCode when migrating paused VM

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8945/ : SUCCESS

Change in vdsm[master]: profile: Support yappi builtins option

2014-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 3: Verified+1 This version replaces the nasty pstats output string searching with searching in ystats func

Change in vdsm[master]: profile: Support yappi builtins option

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8946/ : SUCCESS

Change in vdsm[master]: profile: Support yappi builtins option

2014-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 4: Verified+1 Remove unneeded recursive search - func.children is a flat list of the functions called by func,

Change in vdsm[master]: profile: Support yappi builtins option

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8947/ : SUCCESS

Change in vdsm[master]: json-rpc: Protocol detection

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 14: (1 comment) Just adding info on last review. Starting to review latest version now.

Change in vdsm[master]: keep pauseCode when migrating paused VM

2014-05-18 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27801 To unsubscribe, visit

Change in vdsm[master]: json-rpc: Protocol detection

2014-05-18 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: json-rpc: Protocol detection .. Patch Set 14: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26300/14/vdsm/protoDetector.py File vdsm/protoDetector.py:

Change in vdsm[master]: keep pauseCode when migrating paused VM

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8948/ : SUCCESS

Change in vdsm[master]: keep pauseCode when migrating paused VM

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: keep pauseCode when migrating paused VM .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8949/ : SUCCESS

Change in vdsm[master]: profile: Support yappi clock types

2014-05-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profile: Support yappi clock types .. Patch Set 1: Verified+1 Pass the tests. -- To view, visit http://gerrit.ovirt.org/27816 To unsubscribe, visit

Change in vdsm[master]: profile: Support yappi clock types

2014-05-18 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profile: Support yappi clock types .. profile: Support yappi clock types yappi supports both cpu clock and wall clcok. The default cpu clock is handy when you

Change in vdsm[master]: profile: Support yappi clock types

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi clock types .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8950/ : SUCCESS

Change in vdsm[master]: vdsm-tool: prefix private methods with _

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: vdsm-tool: prefix private methods with _ .. vdsm-tool: prefix private methods with _ Change-Id: I660c5492af2ed5e3ffb61b0a5308a43e03a0ce93 Signed-off-by: Mooli

Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. ConfigFile.py: test for key=val pattern only after replacing old lines. Change-Id:

Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: ConfigFile.py: include default section wrapping comments. .. ConfigFile.py: include default section wrapping comments. Since ConfigFile.py represents common

Change in vdsm[master]: ConfigFile.py: improve documentation

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: ConfigFile.py: improve documentation .. ConfigFile.py: improve documentation Change-Id: I22bf0a9d38d1d14679fe65e239b45dc3c0845cfe Signed-off-by: Mooli Tayer

Change in vdsm[master]: ConfigFile.py: provde backward compatibility with '# by vdsm...

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: ConfigFile.py: provde backward compatibility with '# by vdsm' comments. .. ConfigFile.py: provde backward compatibility with '# by vdsm' comments. see 'Backward

Change in vdsm[master]: configurator.py: sort imports alphabetically

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8951/ : SUCCESS

Change in vdsm[master]: ConfigFile.py: improve documentation

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8953/ : SUCCESS

Change in vdsm[master]: replace configure_libvirt.py with python code.

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8952/ : SUCCESS

Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable

Change in vdsm[master]: vdsm-tool: prefix private methods with _

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods with _ .. Patch Set 1: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: ConfigFile.py: provde backward compatibility with '# by vdsm...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provde backward compatibility with '# by vdsm' comments. .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable

Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 1: Code-Review-1 Verified-1 Build Unstable

Change in vdsm[master]: vdsm-tool: prefix private methods with _

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods with _ .. Patch Set 2: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: vdsm-tool: prefix private methods with _

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: prefix private methods with _ .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8960/ : SUCCESS

Change in vdsm[master]: configurator.py: sort imports alphabetically

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8959/ : SUCCESS

Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8961/ :

Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.

2014-05-18 Thread mtayer
mooli tayer has uploaded a new change for review. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. ConfigFile.py: improve indentation of multiline if statments. Change-Id:

Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 2: Build Successful

Change in vdsm[master]: replace configure_libvirt.py with python code.

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8963/ : SUCCESS

Change in vdsm[master]: ConfigFile.py: provde backward compatibility with '# by vdsm...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provde backward compatibility with '# by vdsm' comments. .. Patch Set 2: Build Successful

Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 1: Build Successful

Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27737 To unsubscribe, visit

Change in vdsm[master]: configurator.py: sort imports alphabetically

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit

Change in vdsm[master]: ConfigFile.py: improve documentation

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: prefix private methods with _

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: vdsm-tool: prefix private methods with _ .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/27821 To unsubscribe, visit

Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27822 To

Change in vdsm[master]: ConfigFile.py: test for key=val pattern only after replacing...

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: test for key=val pattern only after replacing old lines. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27823 To

Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 3: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 4: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27825 To unsubscribe, visit

Change in vdsm[master]: ConfigFile.py: provide backward compatibility with '# by vds...

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: provide backward compatibility with '# by vdsm' comments. .. Patch Set 5: Build Successful

Change in vdsm[master]: ConfigFile.py: improve documentation

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27819 To unsubscribe, visit

Change in vdsm[master]: ConfigFile.py: improve documentation

2014-05-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve documentation .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8969/ : SUCCESS

Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer

2014-05-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit

Change in vdsm[master]: ConfigFile.py: include default section wrapping comments.

2014-05-18 Thread mtayer
mooli tayer has posted comments on this change. Change subject: ConfigFile.py: include default section wrapping comments. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27820 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Extract domain monitoring methods

2014-05-18 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Extract domain monitoring methods .. Patch Set 1: Code-Review+1 (14 comments) great work! I left some notes on points I think can be further

Change in vdsm[master]: ipwrapper, configurators: Wait for bonds to go up

2014-05-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper, configurators: Wait for bonds to go up .. Patch Set 10: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26930/10//COMMIT_MSG Commit Message:

Change in vdsm[master]: vdsm-tool: add unprefixLines() to configfile.py.

2014-05-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: add unprefixLines() to configfile.py. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27737/1//COMMIT_MSG Commit Message: Line 15: tests