Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28244/1/vdsm_reg/vdsm-upgrade
File vdsm
Yoav Kleinberger has posted comments on this change.
Change subject: utilsTests: Styling of RollbackContextTests
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit
Yoav Kleinberger has posted comments on this change.
Change subject: Tests: log actual exceptions in RollbackContext
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28175
To unsubscribe, visit http://ge
Yoav Kleinberger has posted comments on this change.
Change subject: tests: Add assertNotRaises assertion
..
Patch Set 1: Code-Review+1
(9 comments)
http://gerrit.ovirt.org/#/c/28177/1//COMMIT_MSG
Commit Message:
Line 6:
Lin
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/28244/1/vdsm_reg/vdsm-upgrade
File vdsm_reg/vdsm-upgrad
Joey Boggs has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9621/ : FAIL
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit h
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
vdsm-upgrade: adds wrapper to ovirt-node-upgrade
Currently ovirt-node provides ovirt-node-upgra
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Stop domain monitors concurrently
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/27573/2/vdsm/storage/domainMonitor.py
File vdsm/
Francesco Romani has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 29:
(1 comment)
Ack for review; just added an initial note.
http://gerrit.ovirt.org/#/c/26300/29/vdsm/clientIF.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Create vm numa node according to the node index
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1380
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Create vm numa node according to the node index
..
vm: Create vm numa node according to the node index
For vm numa node in libvirt, the node index
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Create vm numa node according to the node index
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27987
To unsubscribe, visit http://
Dan Kenigsberg has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/26142/7/vdsm/virt/guestagent.py
File vdsm/vir
- Original Message -
> From: "Dan Kenigsberg"
> To: from...@redhat.com, smizr...@redhat.com, ybron...@redhat.com
> Cc: ee...@redhat.com, aba...@redhat.com, vdsm-patches@lists.fedorahosted.org,
> dc...@redhat.com, lara...@redhat.com,
> fsimo...@redhat.com
> Sent: Friday, May 30, 2014 3:00:
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Extract domain monitoring methods
..
Patch Set 1: Code-Review-1
(6 comments)
Requires some minor changes here and there. Marking with -1 fo
Francesco, Yaniv,
Have you found the time to dig into the coredump
of these Segmentation faults?
(It is unrelated to Liron's new patches)
On Fri, May 30, 2014 at 01:14:03PM +0100, Jenkins ci oVirt Server wrote:
> Project: http://jenkins.ovirt.org/job/vdsm_master_unit_tests/
> Build: http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: unify cow format check on creation
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1379/ : SUCCE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: unify cow format check on creation
..
volume: unify cow format check on creation
The same check performed both in fileVolume and blockVolume ha
Dan Kenigsberg has posted comments on this change.
Change subject: volume: unify cow format check on creation
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28126
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/137
Dan Kenigsberg has posted comments on this change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
Patch Set 1: Code-Review+2
I have no idea why justme=True has been put there to begin with. But never mi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
blockVolume: prepare volumes for shrinkToOptimalSize
The qemu-img check command needs the entir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: unify vm ovf management lock
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9620/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: introducing uploadImageToStream
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1377/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/
On Thu, May 29, 2014 at 11:32:53AM -0400, Antoni Segura Puimedon wrote:
>
>
> - Original Message -
> > From: "Jenkins ci oVirt Server"
> > To: dan...@redhat.com, vdsm-patches@lists.fedorahosted.org,
> > asegu...@redhat.com
> > Sent: Thursday, May 29, 2014 3:11:11 PM
> > Subject: [oVirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: generify "streamDownloadImage" related methods
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/13
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: removal of unneeded callback passing
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1374/ : SUCC
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: introducing uploadImageToStream
..
core: introducing uploadImageToStream
Adding uploadImageToStream verb which allows to retrieve image data fro
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: imageSharing - export logic to functions
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1373/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: unify vm ovf management lock
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1372/ : SUCCESS
--
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: generify "streamDownloadImage" related methods
..
core: generify "streamDownloadImage" related methods
This patch generifies the related "streamD
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: BindingXMLRPC - exporting logic out from do_PUT.
..
core: BindingXMLRPC - exporting logic out from do_PUT.
moved logic out from do_PUT method so
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: imageSharing - export logic to functions
..
core: imageSharing - export logic to functions
The "copy" logic within imageSharing.streamDownloadIma
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: removal of unneeded callback passing
..
core: removal of unneeded callback passing
The callback can be executed from sp.py after completing the o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: unify vm ovf management lock
..
hsm: unify vm ovf management lock
Taking one lock per VM definition could be extremely slow (especially
when the e
Federico Simoncelli has posted comments on this change.
Change subject: hsm: unify vm ovf management lock
..
Patch Set 2: Verified+1
Verified:
* use updateVM to upload an ovf
* use removeVM to delete an ovf
* use concurrent re
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: fix validateCreateVolumeParams exception
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9618/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: unify cow format check on creation
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9619/ : FAILURE
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: make preallocate optional in volume validation
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9616/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: unify validateCreateVolumeParams
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9617/ : FAILURE
http://
Federico Simoncelli has posted comments on this change.
Change subject: volume: fix validateCreateVolumeParams exception
..
Patch Set 2: Verified+1
Verified with:
* http://gerrit.ovirt.org/28126
* http://gerrit.ovirt.org/28128
Federico Simoncelli has posted comments on this change.
Change subject: sd: make preallocate optional in volume validation
..
Patch Set 3: Verified+1
Verified with:
* http://gerrit.ovirt.org/28126
* http://gerrit.ovirt.org/281
Federico Simoncelli has posted comments on this change.
Change subject: sd: unify validateCreateVolumeParams
..
Patch Set 3: Verified+1
Verified with:
* http://gerrit.ovirt.org/28126
* http://gerrit.ovirt.org/28128
* http://ge
Federico Simoncelli has posted comments on this change.
Change subject: volume: unify cow format check on creation
..
Patch Set 3: Verified+1
Verified with:
* http://gerrit.ovirt.org/28126
* http://gerrit.ovirt.org/28128
* htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add optimizations for hyperv
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9615/ : FAILURE
http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add optimizations for hyperv
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/961
Francesco Romani has posted comments on this change.
Change subject: vm: add optimizations for hyperv
..
Patch Set 2:
changes: implemented the clocksource fix.
--
To view, visit http://gerrit.ovirt.org/27619
To unsubscribe, v
Francesco Romani has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26142
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
..
Patch Set 7: Code-Review+1
may make sense to rename stop() to disconnect(), but it's fine as it is
Michal Skrivanek has posted comments on this change.
Change subject: vm: rename method for clarity
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28223
To unsubscribe, visit http://gerrit.ovirt.org/set
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: get rid of _getStatsInternal
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26557
To unsubscribe, visit http://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: virt: stats: move the guest stats in a method
..
Patch Set 9: -Verified
un-ticked verified until the very good points raised by Vinzenz are fulfilled.
--
To
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: Add assertNotRaises assertion
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28177/1/tests/testrunner.py
File tests/testrunner.py:
Line 180:
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: stats: move the guest stats in a method
..
Patch Set 9:
That means additionally of course. The easiest way to have this, is to install
the guest agent
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: stats: move the guest stats in a method
..
Patch Set 9:
To have the test reliable, you actually should test with the guest agent
installed!
--
To vie
58 matches
Mail list logo
