oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 30:
Build Failed
Hello Federico Simoncelli, Dan Kenigsberg, Kevin Wolf,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28382
to review the following change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9702/ :
Yeela Kaplan has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/26576/15/vdsm/storage/outOfProcess.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Implement rest of os and os.path functionality
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/27482/10/vdsm/storage/outOfProcess.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: glob.glob ioprocess implementation
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9703/ : FAILURE
mooli tayer has posted comments on this change.
Change subject: libvirtconnection: refactor: open a new connection in special
function
..
Patch Set 1:
(1 comment)
One nit, Other than that looks equivalent to old code.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Additional oop functionality
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9704/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert file metadata to use ioprocess for read/writes
..
Patch Set 12:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 30: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27258/30/vdsm/virt/vm.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: repoStats implementation using ioprocess instead of RFH
..
Patch Set 11:
Build Failed
Hello mooli tayer,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28383
to review the following change.
Change subject: utils: must unpersist files for remove
..
utils: must unpersist files for
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils.validateAccess ioprocess implementation
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9707/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add createdir, cleanupdir, simplewalk functionality
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9708/ :
mooli tayer has posted comments on this change.
Change subject: utils: must unpersist files for remove
..
Patch Set 1:
Is there no need to call persist afterwards in such cases?
To prevent the file from re appearing after
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Final separation of IOProcess and RFH
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Implement rest of os and os.path functionality
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9710/ :
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: must unpersist files for remove
..
Patch Set 1:
Hi Mooli,
We do unpersist to be able to remove and do not appear next reboot.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Change file permissions using ioprocess
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9711/ : FAILURE
- Original Message -
From: Francesco Romani from...@redhat.com
To: Dan Kenigsberg dan...@redhat.com
Cc: smizr...@redhat.com, ybron...@redhat.com, ee...@redhat.com,
aba...@redhat.com,
vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, lara...@redhat.com,
fsimo...@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: must unpersist files for remove
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9712/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: lvm: ignore LVs with special tag
..
Patch Set 8: Code-Review+1
Should be harmless to current vdsm code, and may be useful even if hosted
engine do use vdsm api to
Daniel Erez has posted comments on this change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28382
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 11: Code-Review-1 Verified-1
Build Failed
- Original Message -
From: Saggi Mizrahi smizr...@redhat.com
To: Francesco Romani from...@redhat.com
Cc: Dan Kenigsberg dan...@redhat.com, ybron...@redhat.com,
ee...@redhat.com, aba...@redhat.com,
vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, lara...@redhat.com,
Dan Kenigsberg has posted comments on this change.
Change subject: _findLiveSnapshotSupport: do not assume that guest features
exist
..
Patch Set 1:
Francesco, please share your beatification suggestions!
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: utilsTests: Styling of RollbackContextTests
..
Patch Set 6: Code-Review-1
(1 comment)
Marking -1 for visibility.
Federico Simoncelli has posted comments on this change.
Change subject: Tests: log actual exceptions in RollbackContext
..
Patch Set 1: Code-Review-1
This is now useless if in http://gerrit.ovirt.org/22886 we use the standard
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: simplify string conversion methods
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9714/ : FAILURE
Federico Simoncelli has uploaded a new change for review.
Change subject: api: remove obsolete volume prepare and teardown
..
api: remove obsolete volume prepare and teardown
Bug-Url:
Federico Simoncelli has uploaded a new change for review.
Change subject: api: expose prepare and teardown image
..
api: expose prepare and teardown image
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: move netlink into a lib vdsm subpackage
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9715/ :
Federico Simoncelli has posted comments on this change.
Change subject: hsm: unify vm ovf management lock
..
Patch Set 1: Verified+1
Same as master.
--
To view, visit http://gerrit.ovirt.org/28379
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: expose prepare and teardown image
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9716/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 32: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/26300/32/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: remove obsolete volume prepare and teardown
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9717/ :
Saggi Mizrahi has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27553
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9718/ :
Martin Polednik has uploaded a new change for review.
Change subject: vdsmapi-schema: fix typo in tpm device
..
vdsmapi-schema: fix typo in tpm device
Small typo in documentation, VmTpmDeviceType is in no way related
to
Michal Skrivanek has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9719/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmapi-schema: fix typo in tpm device
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9720/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: expose prepare and teardown image
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9721/ : FAILURE
Nir Soffer has posted comments on this change.
Change subject: multipath: Rescan also FC devices
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27122/4/vdsm/storage/hba.py
File vdsm/storage/hba.py:
Line 48: Bear
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: remove obsolete volume prepare and teardown
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9722/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: Stomp support
..
Patch Set 23: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Saggi Mizrahi has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 33: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26300
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 33:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9723/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Stomp support
..
Patch Set 23: Code-Review+2
raising score as this does not affect current workflows.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: Stomp support
..
jsonrpc: Stomp support
The mini broker turned up to be much more work than I expected.
This is an intermediate solution.
Nir Soffer has posted comments on this change.
Change subject: utilsTests: Styling of RollbackContextTests
..
Patch Set 6: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/22886/6/tests/utilsTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Stomp support
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/682/ :
SUCCESS
Nir Soffer has posted comments on this change.
Change subject: Tests: log actual exceptions in RollbackContext
..
Patch Set 1: -Code-Review
Right - both patches should be replaced with one patch using assertRaises.
--
To
Yaniv Bronhaim has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 33: Code-Review+1
please move BindingXMLRPC.py to rpc dir in another patch (this already tested)
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28382
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: blockVolume: prepare volumes for shrinkToOptimalSize
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28382/1//COMMIT_MSG
Commit Message:
Line 14:
Allon Mureinik has posted comments on this change.
Change subject: hsm: unify vm ovf management lock
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28379
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 32:
(1 comment)
http://gerrit.ovirt.org/#/c/26300/32/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding removeConf to sanlock module
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/26055/5//COMMIT_MSG
Commit Message:
Line 7: Adding removeConf to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding removeConf to sanlock module
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9724/ : FAILURE
Jiří Moskovčák has posted comments on this change.
Change subject: api: expose prepare and teardown image
..
Patch Set 2: Verified+1 Code-Review+1
Works for my use case.
--
To view, visit http://gerrit.ovirt.org/28389
To
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netlink: add qdisc information retrieval
..
netlink: add qdisc information retrieval
libnl-3 has support for reporting and creating some traffic
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove redundant print
..
Remove redundant print
This print add usage explanation of vdsm-tool command on error. There is
no need for such print. Unless
Yaniv Bronhaim has posted comments on this change.
Change subject: Setting enum for isconfigured return value and change override
semantics
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/28007
To
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 21:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py
File
Nir Soffer has posted comments on this change.
Change subject: api: remove obsolete volume prepare and teardown
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/28390/2//COMMIT_MSG
Commit Message:
Line 4: Commit:
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 22:
just verify again. the code looks complete from my prospective
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: api: expose prepare and teardown image
..
api: expose prepare and teardown image
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092166
Dan Kenigsberg has posted comments on this change.
Change subject: api: expose prepare and teardown image
..
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.ovirt.org/28389
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: expose prepare and teardown image
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1389/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Setting enum for isconfigured return value and change override
semantics
..
Patch Set 6:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: This commit adds a man page for the vdsm-tool command line
utility.
..
Patch Set 1: Code-Review-1
(1 comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Decrease cpu usage when executing commands
..
utils: Decrease cpu usage when executing commands
After optimizing list2cmdline, we can see that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Decrease cpu usage when executing commands
..
Patch Set 14:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9726/ :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: This commit adds a man page for the vdsm-tool command line
utility.
..
This commit adds a man page for the vdsm-tool command line utility.
This
Dan Kenigsberg has posted comments on this change.
Change subject: This commit adds a man page for the vdsm-tool command line
utility.
..
Patch Set 2: Verified+1 Code-Review+2
Copying score, only a minor text change.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: glob.glob ioprocess implementation
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9727/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Additional oop functionality
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9728/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/25976/16/vdsm/virt/migration.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert file metadata to use ioprocess for read/writes
..
Patch Set 13:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: repoStats implementation using ioprocess instead of RFH
..
Patch Set 12:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileUtils.validateAccess ioprocess implementation
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9731/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add createdir, cleanupdir, simplewalk functionality
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9732/ :
Kobi Ianko has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 30:
(1 comment)
http://gerrit.ovirt.org/#/c/27258/30/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Kobi Ianko has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 31:
Not verified yet
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Final separation of IOProcess and RFH
..
Patch Set 7: -Code-Review -Verified
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Implement rest of os and os.path functionality
..
Patch Set 13: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 33:
(6 comments)
protocol detection and xmlrpc looks fine, expect two issues:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Change file permissions using ioprocess
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9735/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: simplify string conversion methods
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9736/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: This commit adds a man page for the vdsm-tool command line
utility.
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: add qdisc information retrieval
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9738/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: move netlink into a lib vdsm subpackage
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9737/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove redundant print
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9739/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: This commit adds a man page for the vdsm-tool command line
utility.
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 31: Code-Review-1 Verified-1
Build Failed
1 - 100 of 129 matches
Mail list logo
