Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 4:
(5 comments)
http://gerrit.ovirt.org/#/c/34366/4/tests/functional/dhcp.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clean dhclient processes that are left after functional tests
..
Patch Set 5:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13177/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13178/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move watchdog device to vmdevices.py
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13179/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move balloon device to vmdevices.py
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13180/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13181/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13182/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13183/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move watchdog device to vmdevices.py
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13184/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13186/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move balloon device to vmdevices.py
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13185/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 5: Verified+1
Fixed, re-verified using same means
--
To view, visit http://gerrit.ovirt.org/34305
To
Martin Polednik has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 4: Verified+1
Only resolved issue with previous commit, re-verified using same means
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: add functionality to detach host devices
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/32389/3/vdsm/hostdev.py
File vdsm/hostdev.py:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: Do not use udev to set permissions on external
luns
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34162
To
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 1: Code-Review-1
(1 comment)
Good catch! :-) I have a note how to improve your nice
Nir Soffer has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34361/1/lib/vdsm/netinfo.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: assertIsNone is not available on Python 2.6
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34497
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34361/1/lib/vdsm/netinfo.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34305
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34306
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 2:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 2: Code-Review-1
(2 comments)
Last version contains a regression, but previous version
oVirt Jenkins CI Server has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13188/ : SUCCESS
mooli tayer has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/34045
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 3:
tested on el66
--
To view, visit http://gerrit.ovirt.org/34046
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: autoload modules.
..
Patch Set 3: Verified+1
verified on el6.6
--
To view, visit http://gerrit.ovirt.org/34049
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13189/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: moving setup booleans verb to be part of the configurators
..
Patch Set 6:
why mooli?
--
To view, visit http://gerrit.ovirt.org/34463
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: configurator module names optional, defaults to file name.
..
Patch Set 2:
Build Failed
mooli tayer has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 3: Verified+1
verified on el6.6
--
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe,
mooli tayer has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 3: Verified+1
verified on el66
--
To view, visit http://gerrit.ovirt.org/34046
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 3: Verified+1
verified on el6.6
--
To view, visit http://gerrit.ovirt.org/34048
To
mooli tayer has posted comments on this change.
Change subject: tool: change configure verb logic.
..
Patch Set 2: Verified+1
verified on el6.6
--
To view, visit http://gerrit.ovirt.org/34100
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: configurator module names optional, defaults to file name.
..
Patch Set 2: Verified+1
verified on el6.6
--
To view, visit http://gerrit.ovirt.org/34099
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13190/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13191/
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 2: Code-Review-1
(1 comment)
Replace % with str.format()?
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: autoload modules.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13194/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: change configure verb logic.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13196/ : SUCCESS
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/34361/2/lib/vdsm/netinfo.py
File
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding back sebool-un\config verbs to keep backwards
compatibility
..
Adding back sebool-un\config verbs to keep backwards compatibility
Keeping sebool verbs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: configurators package should only contain configurators.
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding back sebool-un\config verbs to keep backwards
compatibility
..
Patch Set 1:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: moving setup booleans verb to be part of the configurators
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/34463
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 3:
Build Failed
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
..
Patch Set 3: Code-Review+1
Nir's original intent is now fulfilled :-) Please see comments on
mooli tayer has posted comments on this change.
Change subject: Moving getSELinuxEnforeMode to utils
..
Patch Set 3: Code-Review+1 Verified+1
$ sudo python
Python 2.6.6 (r266:84292, Nov 21 2013, 10:50:32)
[GCC 4.4.7 20120313
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13199/ : SUCCESS
Vitor de Lima has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 2:
Losing the unit test is pretty bad, what do you suggest in order to fake the
/sys entries that are needed by
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13200/ : SUCCESS
--
Ido Barkan has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 1:
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: testrunner: capture warnings in log only if supported
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4132/
Dan Kenigsberg has posted comments on this change.
Change subject: Adding back sebool-un\config verbs to keep backwards
compatibility
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/34508/1//COMMIT_MSG
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34306
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34305
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move rng device to vmdevices.py
..
virt: move rng device to vmdevices.py
No real code changes
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move watchdog device to vmdevices.py
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34308
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move watchdog device to vmdevices.py
..
virt: move watchdog device to vmdevices.py
No real code changes
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move balloon device to vmdevices.py
..
virt: move balloon device to vmdevices.py
No real code changes
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: move tpm device to vmdevices.py
..
virt: move tpm device to vmdevices.py
No real code changes
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move balloon device to vmdevices.py
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34309
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 7: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/34391/7//COMMIT_MSG
Commit Message:
Line 5:
Ondřej Svoboda has uploaded a new change for review.
Change subject: vdsm: capture warnings in log only if supported
..
vdsm: capture warnings in log only if supported
python_warnings_enable is off by default but let's protect
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: capture warnings in log only if supported
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13201/ :
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28915
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/34114
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: VDSM hook for random network allocation during VM power on
..
VDSM hook for random network allocation during VM power on
This hook is useful in cases
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move rng device to vmdevices.py
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4133/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: capture warnings in log only if supported
..
Patch Set 1: Code-Review-1
Sorry, I've already taken another version of this in
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: capture warnings in log only if supported
..
Patch Set 1: Code-Review+2
oops, that one was only about tests.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move tpm device to vmdevices.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4134/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tool: bugfix function called as attribute.
..
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/34487/1//COMMIT_MSG
Commit Message:
Line 3:
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: extend ModuleConfigurer documentation.
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34045
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: change enumeration naming.
..
Patch Set 3: Code-Review+1
doesn't improve anything but better names imo.
--
To view, visit http://gerrit.ovirt.org/34046
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: change configurators from classes to modules.
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move watchdog device to vmdevices.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4135/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move balloon device to vmdevices.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4136/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
(4 comments)
http://gerrit.ovirt.org/#/c/33783/4/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
mooli tayer has posted comments on this change.
Change subject: tool: bugfix function called as attribute.
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/34487/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
mooli tayer has posted comments on this change.
Change subject: tool: bugfix function called as attribute.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34487
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 8:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6:
rebased because git-review was complaining (?), should be of no harm for the
affected files.
Revision 5
Francesco Romani has posted comments on this change.
Change subject: tests: split SampleWindow tests
..
Patch Set 2: Verified+1
verified running the test themselves (no code changes).
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: rename variables to make code nicer
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13203/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13204/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: split SampleWindow tests
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13205/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: sampling: rename variables to make code nicer
..
Patch Set 4: Verified+1
trivial rename, verified using both existing and new (34512) tests.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: rename variables to make code nicer
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13206/ :
mooli tayer has posted comments on this change.
Change subject: Adding back sebool-un\config verbs to keep backwards
compatibility
..
Patch Set 1: Code-Review-1
What I meant was not to return this implementation but
maintain
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tool: bugfix function called as attribute.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13202/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13207/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: split SampleWindow tests
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13208/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not use lscpu on ppc64
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13209/ : SUCCESS
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 11: Verified-1
Do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13210/ :
Liron Aravot has posted comments on this change.
Change subject: tests: assertIsNone is not available on Python 2.6
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34497
To unsubscribe, visit
1 - 100 of 121 matches
Mail list logo