Darshan N has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/18414/7/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Lin
Dan Kenigsberg has posted comments on this change.
Change subject: storageServer: remove dead code from getSessionInfo
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34537
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domain_descriptor: Use stable devices hash
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4151/ : FAILURE
h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Start DomainDescriptor tests
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4150/ : FAILURE
http://j
Dan Kenigsberg has submitted this change and it was merged.
Change subject: domain_descriptor: Use stable devices hash
..
domain_descriptor: Use stable devices hash
Commit af09a3ff50 changed the way we compute the devices hash.
Dan Kenigsberg has posted comments on this change.
Change subject: domain_descriptor: Use stable devices hash
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34621
To unsubscribe, visit http://gerrit.ov
Petr Horáček has abandoned this change.
Change subject: netlink: link info without cache
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/32864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Start DomainDescriptor tests
..
tests: Start DomainDescriptor tests
Adding some tests before fixing hashing implementation.
Change-Id: I3502d0d
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Start DomainDescriptor tests
..
Patch Set 1: Code-Review+2
raising score
--
To view, visit http://gerrit.ovirt.org/34620
To unsubscribe, visit http://g
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: libnl: drop libnl-1 dependency
..
libnl: drop libnl-1 dependency
El6.6 is out. Since the next release of vdsm will not support
earlier releases than th
Francesco Romani has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34406
To unsubscribe, visit ht
Francesco Romani has posted comments on this change.
Change subject: vm: return displayIp as a string in default case
..
Patch Set 1: Code-Review+1
silly mistake from me back in time.
This just reminded me that we need an autom
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return displayIp as a string in default case
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13294/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: expose hostdev via vdsClient
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13295/ : FAILURE
http://
Frank Kobzik has uploaded a new change for review.
Change subject: vm: return displayIp as a string in default case
..
vm: return displayIp as a string in default case
Previously, default value of displayInfo.displayIp was numbe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: rename buildConfDevices
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13284/ : FAILURE
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add functionality to reattach host devices
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13292/ : FA
Francesco Romani has posted comments on this change.
Change subject: domain_descriptor: Use stable devices hash
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34621
To unsubscribe, visit http://gerrit.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: add functionality to detach host devices
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13291/ : FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13290
Antoni Segura Puimedon has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 4: Verified+1
Installed the rpm with 3.5 installed and it allows migration :-)
Thin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13289
oVirt Jenkins CI Server has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13288
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13287/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: vm: rationalize device setup
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13286/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: split storage part from device normalization
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13285/ : FA
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 12: Verified-1
Do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: reorder device normalization
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13283/ : FAILURE
http://je
Francesco Romani has uploaded a new change for review.
Change subject: WIP: vm: rationalize device setup
..
WIP: vm: rationalize device setup
WIP - still evaluating
Change-Id: I233569ba0104171807f5bcf0b6fedbd2d9b748f9
Bug-Url:
Francesco Romani has uploaded a new change for review.
Change subject: vm: split storage part from device normalization
..
vm: split storage part from device normalization
We learned the hard way multiple times in the past
that
Francesco Romani has uploaded a new change for review.
Change subject: vm: rename buildConfDevices
..
vm: rename buildConfDevices
Them Vm.buildConfDevices method is not building configuration.
It is rather making sure the device
Francesco Romani has uploaded a new change for review.
Change subject: vm: reorder device normalization
..
vm: reorder device normalization
as part of Vm startup, device configuration is checked
and device is normalized.
The las
Nir Soffer has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34639
To unsubscribe, visit http
mooli tayer has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
..
Patch Set 4:
(5 comments)
Sorry, submitted before replying.
http://gerrit.ovirt.org/#/c/33771/4/vdsm
Sahina Bose has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/18414/7/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
L
Dan Kenigsberg has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34637
To unsubscribe, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13282/ : F
Darshan N has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 6:
(3 comments)
http://gerrit.ovirt.org/#/c/18414/6/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Li
Vitor de Lima has posted comments on this change.
Change subject: caps: Additional ppc64 hardware information
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34617
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1328
Dan Kenigsberg has posted comments on this change.
Change subject: spec: remove redundant check.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34610
To unsubscribe, visit http://gerrit.ovirt.org/setti
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1328
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13260/ : SUCCESS
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-
Allon Mureinik has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34639
To unsubscribe, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13258/ : FAILURE
http://j
Allon Mureinik has uploaded a new change for review.
Change subject: volume: Log the correct error when creating a volume fails
..
volume: Log the correct error when creating a volume fails
When a volume creation failed because
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list, restore and status verbs.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/132
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: remove redundant check.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13257/ : SUCCESS
http://jenki
Darshan N has uploaded a new change for review.
Change subject: gluster: volume snapshot list, restore and status verbs.
..
gluster: volume snapshot list, restore and status verbs.
This patch adds three new verbs to list, restor
Ondřej Svoboda has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/34637/1//COMMIT_MSG
Commit Message:
Line 2: A
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327
Dan Kenigsberg has posted comments on this change.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/34637/1//COMMIT_MSG
Commit Message:
Line 2: A
Ondřej Svoboda has uploaded a new change for review.
Change subject: bondopts: Add defaults for the 'arp_all_targets' option
..
bondopts: Add defaults for the 'arp_all_targets' option
This option would be output even if it had a
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit http://gerrit.ovirt.org/setti
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13274/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34636
To unsubscribe, visit http://gerrit.ovirt.o
Liron Aravot has uploaded a new change for review.
Change subject: schema: fix guest disk mapping versioning
..
schema: fix guest disk mapping versioning
The guest disk mapping report feature is being merged to the ovirt-3.5
bra
Nir Soffer has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 3:
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration between hosts
Nir Soffer has posted comments on this change.
Change subject: domain_descriptor: Use stable devices hash
..
Patch Set 1: Verified+1
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration between hos
Nir Soffer has posted comments on this change.
Change subject: domain_descriptor: Eliminate magic hash init value
..
Patch Set 1: Verified+1
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration bet
Nir Soffer has posted comments on this change.
Change subject: domain_descriptor: More careful falsy check
..
Patch Set 1: Verified+1
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration between ho
Nir Soffer has posted comments on this change.
Change subject: guestagent: Simpler and safer disk mapping hash
..
Patch Set 1: Verified+1
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration betwee
Nir Soffer has posted comments on this change.
Change subject: guestagent: Use new style class
..
Patch Set 1: Verified+1
Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and
migration between hosts.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13273/ :
Nir Soffer has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 3: Verified+1
Version 3 fix hash limit to 30 characters, required to work with Engine.
Verified on
Martin Polednik has posted comments on this change.
Change subject: virt: move vm.GraphicsDevice -> vmdevices.Graphics
..
Patch Set 1: Code-Review-1
(1 comment)
-1 for visibility: I would like to see _getNetworkIp() in the gra
Martin Polednik has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 9: Verified+1
- make check
- functional tests
--
To view, visit http://gerrit.ovirt.org/34391
To unsubscrib
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13272/ : FAILURE
http:
Nir Soffer has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit http://gerrit.ovirt.org/sett
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: rename VideoDevice to Video
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13271/ : SUCCESS
http:
Nir Soffer has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 2: Verified-1
It does not work - fucking engine wants up to 30 characters for the hash, and
md5 in
Vinzenz Feenstra has posted comments on this change.
Change subject: domain_descriptor: More careful falsy check
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34623
To unsubscribe, visit http://gerrit
Vinzenz Feenstra has posted comments on this change.
Change subject: domain_descriptor: Eliminate magic hash init value
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34622
To unsubscribe, visit http:/
Vinzenz Feenstra has posted comments on this change.
Change subject: domain_descriptor: Use stable devices hash
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34621
To unsubscribe, visit http://gerrit.
Vinzenz Feenstra has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33045
To unsubscribe, visit http:
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: Start DomainDescriptor tests
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34620
To unsubscribe, visit http://gerrit.ovirt.o
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Simpler and safer disk mapping hash
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34625
To unsubscribe, visit http://ge
Vinzenz Feenstra has posted comments on this change.
Change subject: guestagent: Use new style class
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34624
To unsubscribe, visit http://gerrit.ovirt.org/s
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove configure sanlock from %post installation
..
Patch Set 1:
but this was fixed in the sanlock configurator. Douglas, can you please ack or
nack regarding
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/33771/5/vdsm.spec.in
File vdsm.spec.in:
Line
Francesco Romani has posted comments on this change.
Change subject: guestagent: Use new style class
..
Patch Set 1: Code-Review+1
I agree with using new style classes only.
--
To view, visit http://gerrit.ovirt.org/34624
To
Francesco Romani has posted comments on this change.
Change subject: tests: Start DomainDescriptor tests
..
Patch Set 1: Code-Review+1
nice addition
--
To view, visit http://gerrit.ovirt.org/34620
To unsubscribe, visit http:/
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 16:
(3 comments)
http://gerrit.ovirt.org/#/c/29392/16/lib/vdsm/sigutils.py
File lib/vdsm/sigutils.py:
Lin
Sahina Bose has posted comments on this change.
Change subject: gluster: geo replication status and status detail
..
Patch Set 6:
(1 comment)
Darshan, could you address these comments?
Is it possible to make this patch indepen
89 matches
Mail list logo