Change in vdsm[master]: gluster: geo replication status and status detail

2014-10-30 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/18414/7/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Lin

Change in vdsm[master]: storageServer: remove dead code from getSessionInfo

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: storageServer: remove dead code from getSessionInfo .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34537 To unsubscribe, visit http://

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4151/ : FAILURE h

Change in vdsm[master]: tests: Start DomainDescriptor tests

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4150/ : FAILURE http://j

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: domain_descriptor: Use stable devices hash .. domain_descriptor: Use stable devices hash Commit af09a3ff50 changed the way we compute the devices hash.

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34621 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: netlink: link info without cache

2014-10-30 Thread phoracek
Petr Horáček has abandoned this change. Change subject: netlink: link info without cache .. Abandoned -- To view, visit http://gerrit.ovirt.org/32864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: tests: Start DomainDescriptor tests

2014-10-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Start DomainDescriptor tests .. tests: Start DomainDescriptor tests Adding some tests before fixing hashing implementation. Change-Id: I3502d0d

Change in vdsm[master]: tests: Start DomainDescriptor tests

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 1: Code-Review+2 raising score -- To view, visit http://gerrit.ovirt.org/34620 To unsubscribe, visit http://g

Change in vdsm[master]: libnl: drop libnl-1 dependency

2014-10-30 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: libnl: drop libnl-1 dependency .. libnl: drop libnl-1 dependency El6.6 is out. Since the next release of vdsm will not support earlier releases than th

Change in vdsm[master]: openstacknet: Fix migration when using security groups

2014-10-30 Thread fromani
Francesco Romani has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34406 To unsubscribe, visit ht

Change in vdsm[master]: vm: return displayIp as a string in default case

2014-10-30 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: return displayIp as a string in default case .. Patch Set 1: Code-Review+1 silly mistake from me back in time. This just reminded me that we need an autom

Change in vdsm[master]: vm: return displayIp as a string in default case

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: return displayIp as a string in default case .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13294/ : FA

Change in vdsm[master]: vdsm: expose hostdev via vdsClient

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13295/ : FAILURE http://

Change in vdsm[master]: vm: return displayIp as a string in default case

2014-10-30 Thread fkobzik
Frank Kobzik has uploaded a new change for review. Change subject: vm: return displayIp as a string in default case .. vm: return displayIp as a string in default case Previously, default value of displayInfo.displayIp was numbe

Change in vdsm[master]: vm: rename buildConfDevices

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: rename buildConfDevices .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13284/ : FAILURE http://jenkins

Change in vdsm[master]: vdsm: add functionality to reattach host devices

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add functionality to reattach host devices .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13292/ : FA

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread fromani
Francesco Romani has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34621 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: vdsm: add functionality to detach host devices

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add functionality to detach host devices .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13291/ : FAIL

Change in vdsm[master]: openstacknet: Fix migration when using security groups

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13290

Change in vdsm[master]: openstacknet: Fix migration when using security groups

2014-10-30 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 4: Verified+1 Installed the rpm with 3.5 installed and it allows migration :-) Thin

Change in vdsm[master]: openstacknet: Fix migration when using security groups

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13289

Change in vdsm[master]: openstacknet: Fix migration when using security groups

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: openstacknet: Fix migration when using security groups .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13288

Change in vdsm[master]: Convert VM from external source to Data Domain

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Convert VM from external source to Data Domain .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13287/ : SUC

Change in vdsm[master]: WIP: vm: rationalize device setup

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: vm: rationalize device setup .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13286/ : FAILURE http://j

Change in vdsm[master]: vm: split storage part from device normalization

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: split storage part from device normalization .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13285/ : FA

Change in vdsm[master]: Convert VM from external source to Data Domain

2014-10-30 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Convert VM from external source to Data Domain .. Patch Set 12: Verified-1 Do not review -- To view, visit http://gerrit.ovirt.org/34294 To unsubscribe, visit

Change in vdsm[master]: vm: reorder device normalization

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: reorder device normalization .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13283/ : FAILURE http://je

Change in vdsm[master]: WIP: vm: rationalize device setup

2014-10-30 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: WIP: vm: rationalize device setup .. WIP: vm: rationalize device setup WIP - still evaluating Change-Id: I233569ba0104171807f5bcf0b6fedbd2d9b748f9 Bug-Url:

Change in vdsm[master]: vm: split storage part from device normalization

2014-10-30 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: split storage part from device normalization .. vm: split storage part from device normalization We learned the hard way multiple times in the past that

Change in vdsm[master]: vm: rename buildConfDevices

2014-10-30 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: rename buildConfDevices .. vm: rename buildConfDevices Them Vm.buildConfDevices method is not building configuration. It is rather making sure the device

Change in vdsm[master]: vm: reorder device normalization

2014-10-30 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: reorder device normalization .. vm: reorder device normalization as part of Vm startup, device configuration is checked and device is normalized. The las

Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34639 To unsubscribe, visit http

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47

2014-10-30 Thread mtayer
mooli tayer has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 4: (5 comments) Sorry, submitted before replying. http://gerrit.ovirt.org/#/c/33771/4/vdsm

Change in vdsm[master]: gluster: geo replication status and status detail

2014-10-30 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/18414/7/vdsm/gluster/cli.py File vdsm/gluster/cli.py: L

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34637 To unsubscribe, visit htt

Change in vdsm[master]: gluster: geo replication status and status detail

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13282/ : F

Change in vdsm[master]: gluster: geo replication status and status detail

2014-10-30 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/18414/6/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Li

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

2014-10-30 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34617 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1328

Change in vdsm[master]: spec: remove redundant check.

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34610 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add a hook to configure IPv6 networking through custom properties .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1328

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13260/ : SUCCESS http://j

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327

Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add a hook to configure IPv6 networking through custom properties .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-

Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

2014-10-30 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34639 To unsubscribe, visit htt

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13258/ : FAILURE http://j

Change in vdsm[ovirt-3.5]: volume: Log the correct error when creating a volume fails

2014-10-30 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: volume: Log the correct error when creating a volume fails .. volume: Log the correct error when creating a volume fails When a volume creation failed because

Change in vdsm[master]: gluster: volume snapshot list, restore and status verbs.

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot list, restore and status verbs. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/132

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327

Change in vdsm[master]: spec: remove redundant check.

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13257/ : SUCCESS http://jenki

Change in vdsm[master]: gluster: volume snapshot list, restore and status verbs.

2014-10-30 Thread dnarayan
Darshan N has uploaded a new change for review. Change subject: gluster: volume snapshot list, restore and status verbs. .. gluster: volume snapshot list, restore and status verbs. This patch adds three new verbs to list, restor

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34637/1//COMMIT_MSG Commit Message: Line 2: A

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1327

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34637/1//COMMIT_MSG Commit Message: Line 2: A

Change in vdsm[master]: bondopts: Add defaults for the 'arp_all_targets' option

2014-10-30 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: bondopts: Add defaults for the 'arp_all_targets' option .. bondopts: Add defaults for the 'arp_all_targets' option This option would be output even if it had a

Change in vdsm[ovirt-3.5]: vm: return diskMapping on status()

2014-10-30 Thread laravot
Liron Aravot has posted comments on this change. Change subject: vm: return diskMapping on status() .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/33197 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: schema: fix guest disk mapping versioning

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: fix guest disk mapping versioning .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13274/ : SUCCESS

Change in vdsm[master]: schema: fix guest disk mapping versioning

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: schema: fix guest disk mapping versioning .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34636 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: schema: fix guest disk mapping versioning

2014-10-30 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: schema: fix guest disk mapping versioning .. schema: fix guest disk mapping versioning The guest disk mapping report feature is being merged to the ovirt-3.5 bra

Change in vdsm[master]: utils: Add changehash function for change detection

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 3: Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration between hosts

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: Verified+1 Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration between hos

Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domain_descriptor: Eliminate magic hash init value .. Patch Set 1: Verified+1 Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration bet

Change in vdsm[master]: domain_descriptor: More careful falsy check

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domain_descriptor: More careful falsy check .. Patch Set 1: Verified+1 Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration between ho

Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: guestagent: Simpler and safer disk mapping hash .. Patch Set 1: Verified+1 Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration betwee

Change in vdsm[master]: guestagent: Use new style class

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: guestagent: Use new style class .. Patch Set 1: Verified+1 Verified on rhel6 and rhel7 hosts, by creating and provisioning vms and migration between hosts. -- To

Change in vdsm[master]: utils: Add changehash function for change detection

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13273/ :

Change in vdsm[master]: utils: Add changehash function for change detection

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 3: Verified+1 Version 3 fix hash limit to 30 characters, required to work with Engine. Verified on

Change in vdsm[master]: virt: move vm.GraphicsDevice -> vmdevices.Graphics

2014-10-30 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: virt: move vm.GraphicsDevice -> vmdevices.Graphics .. Patch Set 1: Code-Review-1 (1 comment) -1 for visibility: I would like to see _getNetworkIp() in the gra

Change in vdsm[master]: devices: rename VideoDevice to Video

2014-10-30 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: devices: rename VideoDevice to Video .. Patch Set 9: Verified+1 - make check - functional tests -- To view, visit http://gerrit.ovirt.org/34391 To unsubscrib

Change in vdsm[master]: devices: rename VideoDevice to Video

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: rename VideoDevice to Video .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13272/ : FAILURE http:

Change in vdsm[ovirt-3.5]: vm: return diskMapping on status()

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: return diskMapping on status() .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33197 To unsubscribe, visit http://gerrit.ovirt.org/sett

Change in vdsm[master]: devices: rename VideoDevice to Video

2014-10-30 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: rename VideoDevice to Video .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13271/ : SUCCESS http:

Change in vdsm[master]: utils: Add changehash function for change detection

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 2: Verified-1 It does not work - fucking engine wants up to 30 characters for the hash, and md5 in

Change in vdsm[master]: domain_descriptor: More careful falsy check

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: domain_descriptor: More careful falsy check .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34623 To unsubscribe, visit http://gerrit

Change in vdsm[master]: domain_descriptor: Eliminate magic hash init value

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: domain_descriptor: Eliminate magic hash init value .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34622 To unsubscribe, visit http:/

Change in vdsm[master]: domain_descriptor: Use stable devices hash

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: domain_descriptor: Use stable devices hash .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34621 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: utils: Add changehash function for change detection

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: utils: Add changehash function for change detection .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33045 To unsubscribe, visit http:

Change in vdsm[master]: tests: Start DomainDescriptor tests

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34620 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: guestagent: Simpler and safer disk mapping hash

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guestagent: Simpler and safer disk mapping hash .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34625 To unsubscribe, visit http://ge

Change in vdsm[master]: guestagent: Use new style class

2014-10-30 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guestagent: Use new style class .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34624 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: Remove configure sanlock from %post installation

2014-10-30 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Remove configure sanlock from %post installation .. Patch Set 1: but this was fixed in the sanlock configurator. Douglas, can you please ack or nack regarding

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47

2014-10-30 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47 .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33771/5/vdsm.spec.in File vdsm.spec.in: Line

Change in vdsm[master]: guestagent: Use new style class

2014-10-30 Thread fromani
Francesco Romani has posted comments on this change. Change subject: guestagent: Use new style class .. Patch Set 1: Code-Review+1 I agree with using new style classes only. -- To view, visit http://gerrit.ovirt.org/34624 To

Change in vdsm[master]: tests: Start DomainDescriptor tests

2014-10-30 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Start DomainDescriptor tests .. Patch Set 1: Code-Review+1 nice addition -- To view, visit http://gerrit.ovirt.org/34620 To unsubscribe, visit http:/

Change in vdsm[master]: signals: Handle signals to non-main threads

2014-10-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 16: (3 comments) http://gerrit.ovirt.org/#/c/29392/16/lib/vdsm/sigutils.py File lib/vdsm/sigutils.py: Lin

Change in vdsm[master]: gluster: geo replication status and status detail

2014-10-30 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: geo replication status and status detail .. Patch Set 6: (1 comment) Darshan, could you address these comments? Is it possible to make this patch indepen