Nir Soffer has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38437
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: Update drive.format after active layer merge
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38437
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: infra: Introduce EventFD support
..
Patch Set 7: Code-Review-1
any new patch before it gets in as is ? please re-submit already
--
To view, visit
Hello Nir Soffer, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38437
to review the following change.
Change subject: Live Merge: Update drive.format after active layer merge
Adam Litke has uploaded a new change for review.
Change subject: qemu-img: Handle image end offset on different lines of output
..
qemu-img: Handle image end offset on different lines of output
Current code assumes that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16310/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38434
To
Martin Peřina has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 2: Verified+1
Added note that vmMigrating is deprecated by incomingVmMigrations and
Nir Soffer has posted comments on this change.
Change subject: janitorial: vm: switch to response.error()
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38268/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: janitorial: vm: remove _reportError
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38269
To unsubscribe, visit
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37934/5/client/vdsClient.py
File
Nir Soffer has posted comments on this change.
Change subject: vm: remove obfuscated use of errCode
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38267/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: janitorial: introduce the 'response' module
..
Patch Set 6:
Nice!
--
To view, visit https://gerrit.ovirt.org/37912
To unsubscribe, visit
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: changed description for Image.download method
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38439
To unsubscribe, visit
Candace Sheremeta has uploaded a new change for review.
Change subject: vdsm: changed description for Image.download method
..
vdsm: changed description for Image.download method
changed the description for Image.download
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: removed optional markers for volUUID
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16314/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: lvm: Raise an exception if missing physical volume
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/27442
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: changed description for Image.download method
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16313/ :
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: removed optional markers for volUUID
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit
Candace Sheremeta has uploaded a new change for review.
Change subject: vdsm: removed optional markers for volUUID
..
vdsm: removed optional markers for volUUID
after examining the code, it's clear that the volUUID parameter
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: sourceroute: demote error log message
..
net: sourceroute: demote error log message
DHCP server may provide vdsm with partial IP information (one of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: sourceroute: demote error log message
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16306/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using
hardware iSCSI)
..
Patch Set 2:
(5 comments)
Nir Soffer has posted comments on this change.
Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using
hardware iSCSI)
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/38354
To
Dan Kenigsberg has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38432
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16307/ :
Dan Kenigsberg has abandoned this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38430
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit
Nir Soffer has posted comments on this change.
Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using
hardware iSCSI)
..
Patch Set 3:
Please see my comments in version 2.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38433
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38433
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: net: sourceroute: demote error log message
..
Patch Set 1:
The issue of course is not a missing IP address or netmask, but is a missing
default gateway.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16308/ :
Dan Kenigsberg has abandoned this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/38431
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16309/ :
Hello Nir Soffer, Federico Simoncelli,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38434
to review the following change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
Amador Pahim has abandoned this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Abandoned
Abandoned due to the wrong change-id. Please visit
Allon Mureinik has posted comments on this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38434
To
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap changeBlockDev tests
..
Patch Set 1: Verified+1
verified running the new tests
--
To view, visit https://gerrit.ovirt.org/38391
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: add the response.success() helper
..
Patch Set 5:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: use recommended logging
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16301/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: json-rpc: export setLogLevel API
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16303/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: sos plugin: collect /var/lib/vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38418
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Patch Set 2:
Build Successful
Michal Skrivanek has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38420/1/vdsm/rpc/vdsmapi-schema.json
File
Idan Shaby has uploaded a new change for review.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
In change I9932b044c (lvm: Raise an
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Raise an exception if missing physical volume
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16299/ :
Francesco Romani has uploaded a new change for review.
Change subject: api: allow setLogLevel to tune a specific logger
..
api: allow setLogLevel to tune a specific logger
the not widely known setLogLevel VDSM verb allows to
Francesco Romani has uploaded a new change for review.
Change subject: api: make usage of doneCode uniform
..
api: make usage of doneCode uniform
The usage of doneCode in VDSM is a little ugly,
but this patch makes it uniformly
Francesco Romani has uploaded a new change for review.
Change subject: api: use recommended logging
..
api: use recommended logging
Update the logging in setLogLevel to use
less convoluted and more modern idiom.
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: API: streamline and make setLogLevel correct
..
API: streamline and make setLogLevel correct
According to the schema, setLogLevel should accept
a log level
Francesco Romani has uploaded a new change for review.
Change subject: json-rpc: export setLogLevel API
..
json-rpc: export setLogLevel API
This API was already available over XMl-RPC.
There is no reason to leave JSON-RPC
Sandro Bonazzola has posted comments on this change.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/36237
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: make queryBlockJobs a periodic operation
..
Patch Set 14:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: restore unresponsive on timeout when sampling
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: split up stats production
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/539/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: restore highWrite monitoring
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2631/ :
There
Francesco Romani has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 5:
(3 comments)
minor comments
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Additional reporting of CPU usage in ns
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
..
Patch Set 14:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2626/ :
There
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drop now unused code
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2632/ :
There was an
Allon Mureinik has uploaded a new change for review.
Change subject: spec: upgrade selinux dependency for gluster
..
spec: upgrade selinux dependency for gluster
Upgrade the SELinux policy dependency in order to require a fix
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap changeBlockDev tests
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/38391
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap changeBlockDev tests
..
Patch Set 2:
verified again running the tests
--
To view, visit https://gerrit.ovirt.org/38391
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using
hardware iSCSI)
..
Patch Set 3: Code-Review-1
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Additional reporting of IO statistics
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2633/
Dan Kenigsberg has posted comments on this change.
Change subject: tests: bootstrap changeBlockDev tests
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38391/2/tests/vmTests.py
File tests/vmTests.py:
Line 1299:
Francesco Romani has posted comments on this change.
Change subject: hostdev: add hostdev device definition
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/37700/10/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 185:
Martin Polednik has posted comments on this change.
Change subject: hostdev: add hostdev device definition
..
Patch Set 10: Verified+1
vdsmapi schema wasn't pushed, other than that copying +v
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] Adding cron job check for available updates of vdsm
packages
..
Patch Set 1:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: drive: allow error policy fine tuning
..
Patch Set 8:
version 8 just changes the commit message (no code changes), explaining in a
better way the
Francesco Romani has abandoned this change.
Change subject: virt: drop useless return value of VM.create
..
Abandoned
this may be conceptually right, but timing for this patch is wrong. Will
restore later on
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: vm: remove _reportError
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2642/ :
Francesco Romani has abandoned this change.
Change subject: DONTMERGE: virt: log device changes
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/33641
To unsubscribe, visit https://gerrit.ovirt.org/settings
Idan Shaby has posted comments on this change.
Change subject: lvm: Raise an exception if missing physical volume
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/27442
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: factor out common fields in vm stats
..
Abandoned
too little gains, let's save this for a future deeper refactoring
--
To view, visit
Idan Shaby has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/38421
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: make usage of doneCode uniform
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16302/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16304/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: introduce the 'response' module
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: bootstrap changeBlockDev tests
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16296/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: api: allow setLogLevel to tune a specific logger
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16305/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove obfuscated use of errCode
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2644/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16298/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16300/
Ala Hino has posted comments on this change.
Change subject: qemu-img: Handle image end offset on different lines of output
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38355
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: host stats: Add number of in/out migrations
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38420
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 6:
(1 comment)
good enough for me now. Was that verified?
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Update qemu requirement in EL7
..
spec: Update qemu requirement in EL7
Update the required qemu-kvm and qemu-img packages to consume a bugfix
which
Yeela Kaplan has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35936
To
Amador Pahim has posted comments on this change.
Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using
hardware iSCSI)
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/38354
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmdevices: remove duplicate slot in audio device
..
Patch Set 2:
Build Failed
1 - 100 of 168 matches
Mail list logo
