Bala.FA has submitted this change and it was merged.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
gluster: Added an optional argument to mountBrokerSetup verb
Added an optional argument called
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::bug 1230353#1230353IGNORE, not o
Timothy Asir has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1227781::ERROR, private bug
Timothy Asir has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42210/3/vdsm/gluster/storagedev.py
File vdsm/gluster/st
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40141
To unsubscribe, v
Bala.FA has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/42298
T
Darshan N has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/40141
To unsubscribe, visit https:/
Bala.FA has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 14: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/40141/14//COMMIT_MSG
Commit Message:
Darshan N has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42298
To unsubscribe, visit https
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1230353::ERROR,
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg, Sahina Bose,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42298
to review the following change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
.
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1230342::ERROR, p
Bala.FA has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42210/3/vdsm/gluster/storagedev.py
File vdsm/g
Darshan N has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/40141/11/vdsm/gluster/api.py
File vdsm/gluster/
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Bala.FA has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 11: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/40141/11/vdsm/gluster/api.py
File v
Timothy Asir has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42210
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1227781::ERROR, private bug
Timothy Asir has posted comments on this change.
Change subject: gluster: handle partition table corruption error
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/42210/2/vdsm/gluster/storagedev.py
File vdsm/gluster/s
Dan Kenigsberg has posted comments on this change.
Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
..
Patch Set 9: Code-Review-1
needs manual rebase
--
To view, visit https://gerrit.ovirt.org/41
Dan Kenigsberg has posted comments on this change.
Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41571
To unsubscribe, v
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: add support for usb devices
..
Patch Set 8: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/39715
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: add support for usb devices
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: add support for usb devices
..
hostdev: add support for usb devices
In order to support USB passthrough, we only have to pass usb hostdev
comp
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix writing of logBlkSize property
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix writing of logBlkSize property
..
tests: Fix writing of logBlkSize property
This recent patch[1] changed FakeBlockStorageDomain so that we w
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix writing of logBlkSize property
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42051
To unsubscribe, visit https://gerrit.o
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move logBlkSize
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/41996
To unsubscribe, visit https://gerrit.ovirt.org/s
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: introduce class heirarchy
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/41993
To unsubscribe, visit https://gerrit.o
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move path getters
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/41995
To unsubscribe, visit https://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move BlockSD.getVSize
..
Patch Set 5:
Despite CI False positives, works for me...
--
To view, visit https://gerrit.ovirt.org/41994
To unsub
Adam Litke has posted comments on this change.
Change subject: tests: Fix writing of logBlkSize property
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42051
To unsubscribe, visit https://gerrit.ovirt.or
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: move BlockSD.getVSize
..
Patch Set 5: Verified+1
Despite CI False positives, works for me...
--
To view, visit https://gerrit.ovirt.org/419
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move path getters
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: introduce class heirarchy
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix writing of logBlkSize property
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move logBlkSize
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move BlockSD.getVSize
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Pavel Zhukov has uploaded a new change for review.
Change subject: Improve readability of _ownedIfcfg procedure
..
Improve readability of _ownedIfcfg procedure
Before _ownedIfcfg returned free possible values (True, False or Non
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/40141/10/vdsm/rpc/vdsmapi-gluster-schem
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: Improve readability of _ownedIfcfg procedure
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/42206/3/vdsm/protocoldetector.py
File vdsm/protocoldetect
automat...@ovirt.org has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 3:
* Update tracker::#1229859::OK
* Update tracker::#1215236::OK
* Check Bug-Url::OK
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 3: Verified+1
Pushed simple patch to fix only the issue. Verified with steps described in BZ.
--
automat...@ovirt.org has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 1:
* Update tracker::#1229859::OK
* Update tracker::#1215236::OK
* Check Bug-Url::OK
* Check
Piotr Kliczewski has abandoned this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Abandoned
Wrong branch
--
To view, visit https://gerrit.ovirt.org/42284
To unsubscribe, visit https://gerrit.ovirt
Piotr Kliczewski has uploaded a new change for review.
Change subject: protocoldetecor: SSLError handled not correctly
..
protocoldetecor: SSLError handled not correctly
Whenever there was ssl issue during protocol detection the
automat...@ovirt.org has posted comments on this change.
Change subject: protocoldetecor: SSLError handled not correctly
..
Patch Set 1:
* Update tracker::#1229859::OK
* Update tracker::#1215236::OK
--
To view, visit https://
Michal Skrivanek has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 33: Verified+1
as per Adam Litke's confirmation this resolved the connection problem in
latest master fo
Dan Kenigsberg has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://ger
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: noipspoof: allow multiple interfaces
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42078
To unsubscribe, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: noipspoof: allow multiple interfaces
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: noipspoof: allow multiple interfaces
..
hooks: noipspoof: allow multiple interfaces
In this patch, the specified IPs are set on all interfaces.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
gluster: Added an optional argument to mountBrokerSetup verb
Added an optional argument
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 4:
* Update tracker::#1220345::OK
* Check TR::#1220345::ERROR, 3.6.0 should not
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40141/10/vdsm/rpc/vdsmapi-g
Darshan N has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/40141
To unsubscribe, visit https:/
Darshan N has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/40141/9//COMMIT_MSG
Commit Message:
Line 7: ena
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: noipspoof: improve docstring
..
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/42031
To unsubscribe, visit https://ger
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to override/reset cli snapshot scheduling.
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: noipspoof: improve docstring
..
hooks: noipspoof: improve docstring
The property's regexp must include the comma characters.
Users should be re
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: noipspoof: improve docstring
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
Dan Kenigsberg has posted comments on this change.
Change subject: migration: use the response module
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40492
To unsubscribe, visit https://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: migration: fix spacing
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has uploaded a new change for review.
Change subject: client: update to keep up with setLogLevel changes
..
client: update to keep up with setLogLevel changes
Bring vdsClient up to speed with setLogLevel changes
automat...@ovirt.org has posted comments on this change.
Change subject: client: update to keep up with setLogLevel changes
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added an optional argument to mountBrokerSetup verb
..
Patch Set 3:
* Update tracker::#1220345::OK
* Check Bug-Url::OK
* Check Public Bug::#12203
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/40141/9//COMMIT_MSG
Commit Message:
Line 7
automat...@ovirt.org has posted comments on this change.
Change subject: json-rpc: export setLogLevel API
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: api: allow setLogLevel to tune a specific logger
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: api: use recommended logging
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: api: make usage of doneCode uniform
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/38423
To unsub
Francesco Romani has abandoned this change.
Change subject: api: make usage of doneCode uniform
..
Abandoned
useless
--
To view, visit https://gerrit.ovirt.org/38423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: events: vm status notifications
..
events: vm status notifications
Whenever vm changes status we send notification to an engine with vmid
and new statu
Dan Kenigsberg has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 32:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: virt: use only SourceThread.stop()
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/40521
To unsubs
Francesco Romani has abandoned this change.
Change subject: virt: use only SourceThread.stop()
..
Abandoned
squashed in 40520
--
To view, visit https://gerrit.ovirt.org/40521
To unsubscribe, visit https://gerrit.ovirt.org/set
automat...@ovirt.org has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: virt: enhance/fix migration.SourceThread.stop()
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: migration: fix spacing
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
automat...@ovirt.org has posted comments on this change.
Change subject: migration: use the response module
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make stop() update internal status
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: virt: use only SourceThread.stop()
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Francesco Romani has posted comments on this change.
Change subject: virt: adding statusTime in milliseconds
..
Patch Set 21: Code-Review+1
thanks for implementing my suggestions.
--
To view, visit https://gerrit.ovirt.org/40
Francesco Romani has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Code-Review+1
Can't think of anything else, hence +1
--
To view, visit https://gerrit.ovirt.org/38937
To un
Piotr Kliczewski has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/41380/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Piotr Kliczewski has posted comments on this change.
Change subject: virt: adding statusTime in milliseconds
..
Patch Set 21: Verified+1
Rebased and comments fixed. Verified by updating existing vdsm and starting,
suspending a
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Verified+1
Rebased and comments fixed. Verified by updating existing vdsm and starting,
suspending and resto
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 33: Verified+1
Rebased and comments fixed. Verified by updating existing vdsm and starting,
suspending an
Piotr Kliczewski has posted comments on this change.
Change subject: virt: Trigger event on guest agent status changes
..
Patch Set 19: Verified+1
Rebased and comments fixed. Verified by updating existing vdsm and starting,
su
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 33:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: status: logging status values before sending event
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
1 - 100 of 204 matches
Mail list logo