Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2: Code-Review+1
(4 comments)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: Live merge: Update base size after live merge
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42921
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: _upgrade_onboot failed on python 2.6.6
..
net: _upgrade_onboot failed on python 2.6.6
The flags keyword argument was added only on python 2.7.
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: fix python 2.7 specific code
..
net: fix python 2.7 specific code
This syntax is only supported in python 2.7 hence should be removed
from 3.5
automat...@ovirt.org has posted comments on this change.
Change subject: net: _upgrade_onboot failed on python 2.6.6
..
Patch Set 5:
* Update tracker::#1203422::OK
* Set MODIFIED::bug 1203422#1203422IGNORE, not all
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix python 2.7 specific code
..
Patch Set 2:
* Update tracker::#1203422::OK
* Set MODIFIED::bug 1203422#1203422IGNORE, not all related
Francesco Romani has posted comments on this change.
Change subject: validate listen_tls config value in libvirtd.conf
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/43437/1/lib/vdsm/tool/configurators/libvirt.py
Yaniv Bronhaim has posted comments on this change.
Change subject: net: _upgrade_onboot failed on python 2.6.6
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/43507
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 17: Code-Review+1
Rebases only since v14, I believe.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/6/tests/concurrentTests.py
File tests/concurrentTests.py:
Line
Ido Barkan has posted comments on this change.
Change subject: net: _upgrade_onboot failed on python 2.6.6
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/43507
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: fix python 2.7 specific code
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/43512
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: net: _upgrade_onboot failed on python 2.6.6
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43507
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Forcibly unregister fds with errors from epoll
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: resourceManager: Avoid uneeded recursive locking
..
Patch Set 3: Code-Review+1
(2 comments)
seems self-contained (since I'm not storage expert) and looks
Marcin Mirecki has posted comments on this change.
Change subject: virt: migration: create full status in migration.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43357/1/vdsm/API.py
File vdsm/API.py:
Line 353:
Francesco Romani has posted comments on this change.
Change subject: testlib: Fix permutations of decorated tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43433
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: net: tests: clean legacy bonds from kernelConfig
..
Patch Set 4:
still
==
ERROR:
Francesco Romani has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 10: Code-Review+1
(3 comments)
looks ok and looks nice. Comments inside about possible very minor improvements.
automat...@ovirt.org has posted comments on this change.
Change subject: adding StorageDomain.activateHsm()
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: adding StorageDomain.removeVmData()
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 5: Code-Review+1
codewise looks easy :)
--
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm hooks: report hook stderr to Engine if it fails an action
..
Patch Set 20:
* Update tracker::#1219630::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: add arguments to send_status_event
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: resourceManager: Avoid uneeded recursive locking
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: drop cluster version 3.6
..
Patch Set 1: Code-Review-1
please limit this to ppc
--
To view, visit https://gerrit.ovirt.org/43307
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 377:
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: status is an enumeration, not as tuple
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: make vm events callback public
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: virt: event: send status event on migrations
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on pause and resume
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: do not report empty balloonInfo
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on domDependentInit
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: do not override Down status
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: events: do not send hashes in status messages
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: virt: clientif: remove generic vm status event
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on reboot
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: stats: do not send empty disks/networks
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on setDownStatus
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: emit event on guest status change
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on IO Error
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: rwlock: Mark time sensitive test as stress test
..
rwlock: Mark time sensitive test as stress test
Testing 256 concurrent threads on the our overloaded CI slaves
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Mark time sensitive test as stress test
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: validate listen_tls config value in libvirtd.conf
..
Patch Set 1: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: clean legacy bonds from kernelConfig
..
Patch Set 4: Code-Review+2 Continuous-Integration+1
Error unrelated to patch
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: fix testRestoreNetworksOnlyRestoreUnchangedDevices
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43545
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1806:
Freddy Rolland has posted comments on this change.
Change subject: resize-lun: Rescan fiber channel devices
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/43388
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: virt: make vm events callback public
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43308
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43582
To
automat...@ovirt.org has posted comments on this change.
Change subject: vm: stats: move vmstats translation code away
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: send status event on powerdown
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/43365
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: change logic to emit events
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/43345
To
Francesco Romani has abandoned this change.
Change subject: vm: event: change logic to emit events
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/43345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has abandoned this change.
Change subject: vm: event: send status event on powerdown
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/43365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has uploaded a new change for review.
Change subject: test jenkins, please delete
..
test jenkins, please delete
Change-Id: I88e0fccfe52b23d675a74e44e6da06c2b74bfbeb
Signed-off-by: Dan Kenigsberg
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove supportedProtocols parameter which is not in use
..
Remove supportedProtocols parameter which is not in use
Requires to update MarshallingTestCase.java
automat...@ovirt.org has posted comments on this change.
Change subject: Remove supportedProtocols parameter which is not in use
..
Patch Set 1:
* Update tracker::#1234790::OK
* Check Bug-Url::OK
* Check Public
Allon Mureinik has posted comments on this change.
Change subject: resize-lun: Rescan fiber channel devices
..
Patch Set 6: Code-Review+1
(2 comments)
+1 on the code, minor comments on the commit message.
Also, please
Dan Kenigsberg has posted comments on this change.
Change subject: vm: event: status is an enumeration, not as tuple
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/43413
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: resize-lun: Rescan fiber channel devices
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/43388/6//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: JsonRpcServer tests suite
..
tests: JsonRpcServer tests suite
Change-Id: I1090764c7289544abe331a13ec765ceed2a53afe
Signed-off-by: pkliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: JsonRpcClient tests suite
..
tests: JsonRpcClient tests suite
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: test jenkins, please delete
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: clean legacy bonds from kernelConfig
..
Patch Set 5:
* Update tracker::#1203422::OK
* Check TR::#1203422::OK
* Set MODIFIED::bug
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: tests: fix testRestoreNetworksOnlyRestoreUnchangedDevices
..
net: tests: fix testRestoreNetworksOnlyRestoreUnchangedDevices
iproute2 in el6 does
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: tests: clean legacy bonds from kernelConfig
..
net: tests: clean legacy bonds from kernelConfig
VdsProxy netinfo is built from getVdsCapabilities
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: fix testRestoreNetworksOnlyRestoreUnchangedDevices
..
Patch Set 4:
* Update tracker::#1203422::OK
* Check TR::#1203422::OK
* Set
automat...@ovirt.org has posted comments on this change.
Change subject: validate listen_tls config value in libvirtd.conf
..
Patch Set 2:
* Update tracker::#1148024::OK
* Check Bug-Url::OK
* Check Public Bug::#1148024::OK,
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43042
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: fix hostdev addressing
..
hostdev: fix hostdev addressing
Host devices are special in a sense that in case of PCI, there are two
addresses
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: inline source address function
..
hostdev: inline source address function
Due to addressing changes, there is no additional value in
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: inline source address function
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: add basic unit tests for XML
..
Patch Set 4: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/43088
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: add basic unit tests for XML
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix hostdev addressing
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: inline source address function
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43379
To unsubscribe, visit
Ondřej Svoboda has uploaded a new change for review.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
network: wait for a bridge to appear before disabling IPv6 on it
A traceback such as
automat...@ovirt.org has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43581
To
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 3: Verified+1
Rebase only, no code changes. Copying verification flag from previous patch set.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 2: Verified+1
Rebase only, no code changes. Copying verification flag from previous patch set.
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 2: Verified+1
Rebase only, no code changes. Copying verification flag from previous patch set.
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: vm: events: reorganize events
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43538/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3649:
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: add tests for guest addressing
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/43093
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: add basic unit tests for XML
..
hostdev: add basic unit tests for XML
Now VDSM has the needed tools to unit test the creation of host
Martin Polednik has posted comments on this change.
Change subject: hostdev: add tests for guest addressing
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/43093
To unsubscribe, visit
1 - 100 of 237 matches
Mail list logo