Change in vdsm[master]: multipath: Write multipath.conf atomically

Fabian Deutsch has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44869/3/lib/vdsm/tool/configurators/multipath.py File lib/v

Change in vdsm[master]: multipath: Backup old configuration using hard link

Fabian Deutsch has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44866/3/lib/vdsm/tool/configurators/multipath.py F

Change in vdsm[master]: net: always persist ifcfg files.

Dan Kenigsberg has posted comments on this change. Change subject: net: always persist ifcfg files. .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44878 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: concurrent: Introduce concurrent.thread() utility

Nir Soffer has posted comments on this change. Change subject: concurrent: Introduce concurrent.thread() utility .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/44894 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: threads: Name long running threads

Nir Soffer has posted comments on this change. Change subject: threads: Name long running threads .. Patch Set 1: See https://gerrit.ovirt.org/44894 for a better approach. -- To view, visit https://gerrit.ovirt.org/44893 To u

Change in vdsm[master]: concurrent: Use new concurrent.thread() utility

automat...@ovirt.org has posted comments on this change. Change subject: concurrent: Use new concurrent.thread() utility .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: concurrent: Use new concurrent.thread() utility

automat...@ovirt.org has posted comments on this change. Change subject: concurrent: Use new concurrent.thread() utility .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: concurrent: Use new concurrent.thread() utility

Nir Soffer has uploaded a new change for review. Change subject: concurrent: Use new concurrent.thread() utility .. concurrent: Use new concurrent.thread() utility This patch remove eliminate some boilerplate code by using the n

Change in vdsm[master]: concurrent: Introduce concurrent.thread() utility

Nir Soffer has uploaded a new change for review. Change subject: concurrent: Introduce concurrent.thread() utility .. concurrent: Introduce concurrent.thread() utility We are repeating this boilerplate code everywhere: def

Change in vdsm[master]: concurrent: Introduce concurrent.thread() utility

automat...@ovirt.org has posted comments on this change. Change subject: concurrent: Introduce concurrent.thread() utility .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: threads: Name long running threads

Nir Soffer has posted comments on this change. Change subject: threads: Name long running threads .. Patch Set 1: Code-Review-1 I don't think this we should continue in this direction, we have too much boilerplate and setting

Change in vdsm[master]: threads: Name long running threads

automat...@ovirt.org has posted comments on this change. Change subject: threads: Name long running threads .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[ovirt-3.6]: register: Add --vdsm-uuid

Douglas Schilling Landgraf has posted comments on this change. Change subject: register: Add --vdsm-uuid .. Patch Set 1: Verified+1 backport only -- To view, visit https://gerrit.ovirt.org/44887 To unsubscribe, visit https://

Change in vdsm[ovirt-3.6]: register: Add --vdsm-uuid

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: register: Add --vdsm-uuid .. register: Add --vdsm-uuid This patch adds --vdsm-uuid option to user provide host UUID to be used instead vdsm.utils.

Change in vdsm[ovirt-3.6]: register: Add --vdsm-uuid

automat...@ovirt.org has posted comments on this change. Change subject: register: Add --vdsm-uuid .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: net: always persist ifcfg files.

Fabian Deutsch has posted comments on this change. Change subject: net: always persist ifcfg files. .. Patch Set 2: Code-Review+1 The chaneg itself looks good, but I can not tell if it will be called in all relevant flows. --

Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration

Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Replace misused asserts with InvalidConfiguration .. Patch Set 3: In getBondingForNic, the assert can be removed. # ip link add type dummy # ip lin

Change in vdsm[master]: network: bridge inherits DHCP unique identifier from its DHC...

Ondřej Svoboda has posted comments on this change. Change subject: network: bridge inherits DHCP unique identifier from its DHCP-enabled port .. Patch Set 4: Let me add that I used Ido's "net: create bond properly during start

Change in vdsm[master]: network: bridge inherits DHCP unique identifier from its DHC...

Ondřej Svoboda has posted comments on this change. Change subject: network: bridge inherits DHCP unique identifier from its DHCP-enabled port .. Patch Set 4: Verified+1 No regression with ifcfg configurator. Failing tests are

Change in vdsm[master]: register: Add --ca-file

Dan Kenigsberg has posted comments on this change. Change subject: register: Add --ca-file .. Patch Set 2: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/44576/2/lib/vdsm/tool/register.py File lib/vdsm/tool/register.p

Change in vdsm[master]: ipwrapper: Use zombiereaper to wait for process

Ido Barkan has posted comments on this change. Change subject: ipwrapper: Use zombiereaper to wait for process .. Patch Set 1: Code-Review-1 this whole code now moved to lib/vdsm/netlink/monitor.py and uses netlink directly. I

Change in vdsm[master]: tests: functional - convert to run over jsonrpc

Dima Kuznetsov has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43237 To unsubscribe, visit https://g

Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration

Ido Barkan has posted comments on this change. Change subject: netinfo: Replace misused asserts with InvalidConfiguration .. Patch Set 3: Ondrej, you are probably right, but I see no reason why not fix this now. If you think w

Change in vdsm[master]: net: monitor: string formating enhancement

Ido Barkan has posted comments on this change. Change subject: net: monitor: string formating enhancement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44800 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: net: always persist ifcfg files.

automat...@ovirt.org has posted comments on this change. Change subject: net: always persist ifcfg files. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: m2c: rename m2c modules

Dan Kenigsberg has posted comments on this change. Change subject: m2c: rename m2c modules .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44493 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: supervdsm: Move supervdsm module into lib

automat...@ovirt.org has posted comments on this change. Change subject: supervdsm: Move supervdsm module into lib .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To vie

Change in vdsm[master]: supervdsm: Move supervdsm module into lib

Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsm: Move supervdsm module into lib .. supervdsm: Move supervdsm module into lib This patch moves the code for supervdsm proxy into the lib of vd

Change in vdsm[master]: supervdsm: Move supervdsm module into lib

Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: Move supervdsm module into lib .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/44597 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: net: always persist ifcfg files.

automat...@ovirt.org has posted comments on this change. Change subject: net: always persist ifcfg files. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: net: always persist ifcfg files.

Ido Barkan has uploaded a new change for review. Change subject: net: always persist ifcfg files. .. net: always persist ifcfg files. Currently the persistence of ifcfg files is only done during setSafeNetworkConfig. But, if the

Change in vdsm[master]: supervdsm: Decorator for supervdsm proxied calls.

Yeela Kaplan has posted comments on this change. Change subject: supervdsm: Decorator for supervdsm proxied calls. .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44598 To unsubscribe, visit https://ge

Change in vdsm[master]: core: Remove substitutions from dumpStorageTable

automat...@ovirt.org has posted comments on this change. Change subject: core: Remove substitutions from dumpStorageTable .. Patch Set 2: * Update tracker::#1098179::OK * Check Bug-Url::OK * Check Public Bug::#1098179::OK, publ

Change in vdsm[master]: core: Remove substitutions from dumpStorageTable

automat...@ovirt.org has posted comments on this change. Change subject: core: Remove substitutions from dumpStorageTable .. Patch Set 1: * Update tracker::#1098179::OK * Check Bug-Url::OK * Check Public Bug::#1098179::OK, publ

Change in vdsm[master]: core: Remove substitutions from dumpStorageTable

Dima Kuznetsov has uploaded a new change for review. Change subject: core: Remove substitutions from dumpStorageTable .. core: Remove substitutions from dumpStorageTable This patch removes the use of substitutions from dumpStora

Change in vdsm[master]: supervdsm: Decorator for supervdsm proxied calls.

Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Decorator for supervdsm proxied calls. .. Patch Set 6: Verified+1 Verified using UTs and system tests framework -- To view, visit https://gerrit.ov

Change in vdsm[master]: functional tests: virt: fix devices verification

Yeela Kaplan has abandoned this change. Change subject: functional tests: virt: fix devices verification .. Abandoned -- To view, visit https://gerrit.ovirt.org/43600 To unsubscribe, visit https://gerrit.ovirt.org/settings Ge

Change in vdsm[master]: functional tests: virt: fix devices verification

automat...@ovirt.org has posted comments on this change. Change subject: functional tests: virt: fix devices verification .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/4

Change in vdsm[master]: vdscli: jsonrpc: return results compatible with xmlrpc

Yeela Kaplan has abandoned this change. Change subject: vdscli: jsonrpc: return results compatible with xmlrpc .. Abandoned -- To view, visit https://gerrit.ovirt.org/43436 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: vdscli: jsonrpc: return results compatible with xmlrpc

automat...@ovirt.org has posted comments on this change. Change subject: vdscli: jsonrpc: return results compatible with xmlrpc .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: tests: functional - convert to run over jsonrpc

Yeela Kaplan has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/43237 To unsubscribe, visit https://gerrit

Change in vdsm[master]: tests: functional - convert to run over jsonrpc

automat...@ovirt.org has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 10: * Update tracker::#1138381::OK * Check Bug-Url::OK * Check Public Bug::#1138381::OK, publ

Change in vdsm[master]: multipath: Backup old configuration using hard link

Nir Soffer has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44866/3/lib/vdsm/tool/configurators/multipath.py File

Change in vdsm[master]: multipath: Backup old configuration using hard link

Nir Soffer has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/44866 To unsubscribe, visit https://gerri

Change in vdsm[master]: multiapth: Tell the user about backups

Nir Soffer has posted comments on this change. Change subject: multiapth: Tell the user about backups .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/44867 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: multipath: Use more meaningful names

Yeela Kaplan has posted comments on this change. Change subject: multipath: Use more meaningful names .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/44861 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: multipath: Write multipath.conf atomically

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Write multipath.conf atomically .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: multiapth: Reorganize constants and improve documentation

automat...@ovirt.org has posted comments on this change. Change subject: multiapth: Reorganize constants and improve documentation .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url fou

Change in vdsm[master]: multipath: Reformat old tags list

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Reformat old tags list .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: multipath: Keep tags sorted from newer to older

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Keep tags sorted from newer to older .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: multipath: Use more meaningful names

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Use more meaningful names .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: multipath: Fix multipath.conf permissions

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Fix multipath.conf permissions .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: multipath: Use tuple for constant data

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Use tuple for constant data .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: multipath: Backup old configuration using hard link

automat...@ovirt.org has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, ma

Change in vdsm[master]: multiapth: Tell the user about backups

automat...@ovirt.org has posted comments on this change. Change subject: multiapth: Tell the user about backups .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: multipath: Backup old configuration using hard link

Nir Soffer has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 2: Verified-1 Works only after the last patch in the topic. -- To view, visit https://gerrit.ovir

Change in vdsm[master]: multipath: Backup old configuration using hard link

Nir Soffer has posted comments on this change. Change subject: multipath: Backup old configuration using hard link .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/44866/2/lib/vdsm/tool/configurators/multipath.py File

Change in vdsm[master]: tests: functional - convert to run over jsonrpc

automat...@ovirt.org has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 9: * Update tracker::#1138381::OK * Check Bug-Url::OK * Check Public Bug::#1138381::OK, publi

Change in vdsm[master]: v2v: get VM information from OVA file

Shahar Havivi has posted comments on this change. Change subject: v2v: get VM information from OVA file .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/43271/10/vdsm/v2v.py File vdsm/v2v.py: Line 185: _add_gener