Change in vdsm[master]: config: Improve options documentation

2015-08-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: config: Improve options documentation .. Patch Set 1: Code-Review-1 (1 comment) bug +1 for the concept, unfortunately there is a typo inside. -1 for visibili

Change in vdsm[master]: gluster: fix AttributeError in exception.py

2015-08-21 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: gluster: fix AttributeError in exception.py .. Patch Set 4: Code-Review+1 Acked. Tim: Confirm that the python issue http://bugs.python.org/issue15440 is not fixed

Change in vdsm[master]: gluster: fix TypeError in exception.py

2015-08-21 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: gluster: fix TypeError in exception.py .. Patch Set 1: Code-Review+1 Tim: Confirm that the mentioned python bug is not fixed in latest 2.7 -- To view, visit https:/

Change in vdsm[master]: gluster: fix TypeError in exception.py

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix TypeError in exception.py .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1231722::ERROR, private bug * Check P

Change in vdsm[master]: gluster: fix AttributeError in exception.py

2015-08-21 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: fix AttributeError in exception.py .. Patch Set 4: yes, its fixed only in 3.3. In python version 2.7 its not fixed -- To view, visit https://gerrit.ovi

Change in vdsm[master]: net: tests: enable tests to run with OVS

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: net: tests: enable tests to run with OVS .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: hooks: Open vSwitch configurator

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Open vSwitch configurator .. Patch Set 64: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: tests: virt: move powerdown related tests away

2015-08-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: virt: move powerdown related tests away .. Patch Set 1: Splitting out vmOperationTests seems even better, I'll go that way. Thanks Martin! -- To vie

Change in vdsm[master]: gluster: fix xfs filesystem is created with wrong inode size

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. Patch Set 4: * Update tracker::#1244865::OK * Check Bug-Url::OK * Check Public Bug::#12448

Change in vdsm[master]: gluster: fix xfs filesystem is created with wrong inode size

2015-08-21 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43847 To unsubscribe, visit ht

Change in vdsm[master]: tests: split vm operation tests.

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: split vm operation tests. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: vm: make acpiShutdown more robust

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: make acpiShutdown more robust .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: virt: add and use vm.acpiReboot() method

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: add and use vm.acpiReboot() method .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: tests: split vm operation tests.

2015-08-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: split vm operation tests. .. Patch Set 2: Verified+1 verified running - old tests (vmTests) - new tests (vmOperationsTests) - all tests (make check) -

Change in vdsm[master]: migration: make status attribute private

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: make status attribute private .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: virt: do not use status after getStat()

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: migration: move progress update into an helper

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: move progress update into an helper .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: migration: add helper to add status field

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: add helper to add status field .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: migration: de-entangle migration stat reporting

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: de-entangle migration stat reporting .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: migration: build new reason on success

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: build new reason on success .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: migration: return plain response on error

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: return plain response on error .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: migration: replace boolean with proper Events

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: migration: replace boolean with proper Events .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: client: update to keep up with setLogLevel changes

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: client: update to keep up with setLogLevel changes .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: tests: split vm operation tests.

2015-08-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: split vm operation tests. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/45064/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-08-21

Change in vdsm[master]: API: restore setLogLevel backward compatibility

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: API: restore setLogLevel backward compatibility .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: json-rpc: export setLogLevel API

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: json-rpc: export setLogLevel API .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: debug log for getAllVmStats() and getVMList()

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: vm: debug log for getAllVmStats() and getVMList() .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: API: streamline and make setLogLevel correct

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: API: streamline and make setLogLevel correct .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: API: allow setLogLevel to tune a specific logger

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: API: allow setLogLevel to tune a specific logger .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: vm: remove unused 'output' value in response

2015-08-21 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: remove unused 'output' value in response .. Patch Set 16: Verified+1 verified inspecting Engine (VdsProperties.java) looking for the 'output' field const

Change in vdsm[master]: config: Improve options documentation

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: config: Improve options documentation .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195421::ERROR, private bug * Check Pu

Change in vdsm[master]: config: Improve options documentation

2015-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: config: Improve options documentation .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45167/1/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 231:

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread alitke
Adam Litke has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/44857/3//COMMIT_MSG Commit Message: Line 11: to manage long-running st

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: tests: split vm operation tests.

2015-08-21 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: tests: split vm operation tests. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45064 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: networkTests: normalize dict keys and values to str (from un...

2015-08-21 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: networkTests: normalize dict keys and values to str (from unicode) .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no b

Change in vdsm[master]: networkTests: normalize dict keys and values to str (from un...

2015-08-21 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: networkTests: normalize dict keys and values to str (from unicode) .. networkTests: normalize dict keys and values to str (from unicode) Change-Id: I6362e0418

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py File vdsm/jobs.py: Line 73: _JOB_TYPE = None L

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 5: (2 comments) Looks good, -1 for visibility. https://gerrit.ovirt.org/#/c/44857/5/vdsm/jobs.py File vdsm/jobs.py:

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 5: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/44857 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: Refactor v2v jobs for reusability

2015-08-21 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Refactor v2v jobs for reusability .. Patch Set 5: (6 comments) The tests can be simplified. https://gerrit.ovirt.org/#/c/44857/5/tests/jobsTests.py File tests/job