Fabian Deutsch has posted comments on this change.
Change subject: multipath: Fix multipath.conf selinux labels
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46398
To unsubscribe, visit https://gerri
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/14/vdsm.spec.in
File vdsm.spec.in:
Line 628: sed -i -
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 10: Code-Review-1
(3 comments)
Also see my comments in version 9 in image.py
https://gerrit.ovirt.org/#/c/3
Germano Veit Michel has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
> Germano, I refined the commit message, please check.
Looks better. Thanks for that.
-
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
CI won't run any tests since Germano is not in our whitelist :-(
Dan, can you trigger CI tests fo
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
Germano, I refined the commit message, please check.
--
To view, visit https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2: Verified+1
Verified by GSS:
https://bugzilla.redhat.com/show_bug.cgi?id=1267444#c3
Good enough fo
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4: Code-Review-1
(18 comments)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File te
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Fix multipath.conf selinux labels
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/7//COMMIT_MSG
Commit Message:
Line 57:
Nir Soffer has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/46270/7/tests/samplingTests.py
File tests/samplingTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2/lib/yajsonrpc/betterAsyncore.py
File lib
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: build: Introduce --enable-gluster configuration
..
Patch Set 1: Code-Review-1
(3 comments)
Address comments.
https://gerrit.ovirt.org/#/c/46708/1/lib/vdsm/constan
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 3: Code-Review-1
(4 comments)
Just some modernization advice, probably not exactly r
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: ovs: start every log with 'OVS: '
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46906/4/vdsm_hooks/ovs/ovs_utils.py
File vdsm_hooks/ovs/ovs_u
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 9:
(10 comments)
https://gerrit.ovirt.org/#/c/33910/9/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 22
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(6 comments)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 241
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Ondřej Svoboda has posted comments on this change.
Change subject: tests: net: use new veth_pair in networkTestsOVS.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46914
To unsubscribe, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move jobs.py to lib/vdsm
..
Move jobs.py to lib/vdsm
The host jobs infrastructure in jobs.py is general purpose and belongs
in the vdsm-python package.
Dan Kenigsberg has posted comments on this change.
Change subject: Move jobs.py to lib/vdsm
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46141
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: Move jobs.py to lib/vdsm
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
Adam Litke has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/46417/4/tests/blockVolumeTests.py
File tests/blockVolume
Ondřej Svoboda has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
I see no reason for two functions turning the same switch on or off.
"set_ipv6" is
Ondřej Svoboda has posted comments on this change.
Change subject: configurators: move disable_ipv6 code to a common function
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46984/3/vdsm/network/configurators/ifcfg.p
Ondřej Svoboda has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46985/4//COMMIT_MSG
Commit Messa
Petr Horáček has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46985/4//COMMIT_MSG
Commit Message
Petr Horáček has posted comments on this change.
Change subject: configurators: move disable_ipv6 code to a common function
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46984/3/vdsm/network/configurators/ifcfg.py
Petr Horáček has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
i'd prefer to rename it to set_ipv6 or better create two functions enable and
disabl
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 4:
* Update tracker::#1219363::OK
* Check Bug-Url::OK
* Check Public Bu
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: move disable_ipv6 code to a common function
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 3:
* Update tracker::#1219363::OK
* Check Bug-Url::OK
* Check Public Bu
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 2:
* Update tracker::#1219363::OK
* Check Bug-Url::OK
* Check Public Bu
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: move disable_ipv6 code to a common function
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43746
To unsubscribe, visit https://gerrit.ovirt.
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: HostSample always gets current cpus
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: remove HostStatsThread.get()
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ondřej Svoboda has uploaded a new change for review.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
Change-Id: I154f22a5f59174d0e33235
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add retry logic for incoming limit
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Francesco Romani has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/42035/14/vdsm/virt/hoststats.py
File vdsm/virt/hoststa
Francesco Romani has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/42034/14//COMMIT_MSG
Commit Message:
Line 9: pro
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
Patch Set 1:
* Update tracker::#1219363::OK
* Check Bug-Url::OK
* Check Public Bu
automat...@ovirt.org has posted comments on this change.
Change subject: configurators: move disable_ipv6 code to a common function
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Ondřej Svoboda has uploaded a new change for review.
Change subject: configurators: make disable_ipv6 permanent by using sysctl.d
configs
..
configurators: make disable_ipv6 permanent by using sysctl.d configs
TODO: Will SELinu
Ondřej Svoboda has uploaded a new change for review.
Change subject: configurators: move disable_ipv6 code to a common function
..
configurators: move disable_ipv6 code to a common function
Change-Id: I39d39f10cc2e7f593bb4ba3c65
automat...@ovirt.org has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: WIP - do not merge
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: periodic: extract required_on staticmethod
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46833/2/vdsm/virt/periodic.py
File vdsm/vir
Francesco Romani has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46941/1/tests/integration/jsonRpcHelper.py
File tests/integrat
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry logic for incoming limit
..
Patch Set 1:
(2 comments)
initial review
https://gerrit.ovirt.org/#/c/46971/1/vdsm/virt/migration.py
File v
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Pull some vars into the class
..
register: Pull some vars into the class
Change-Id: I1601ec61a30971f175630013023e8be2de77da17
Signed-off-by: Fabian D
automat...@ovirt.org has posted comments on this change.
Change subject: register: Simplify setting defaults
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Simplify setting defaults
..
register: Simplify setting defaults
Change-Id: Id02327439fcc5a88a6489635ea9bd293bbe350cd
Signed-off-by: Fabian Deutsch
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Drop CA path redundancies
..
register: Drop CA path redundancies
Change-Id: I0a386f9b3f398ea5e5537e146448954ec3b057cb
Signed-off-by: Fabian Deutsch
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Fix certificate validation
..
register: Fix certificate validation
Change-Id: Idcd1eab617ea21655ec89419c0f3532eefeec4f9
Signed-off-by: Fabian Deutsch
Fabian Deutsch has uploaded a new change for review.
Change subject: register: Leave the logging to the vdsm-tool
..
register: Leave the logging to the vdsm-tool
Change-Id: I6795077ce62d254c1ca5497eb6291291b2d03033
Signed-off-by
automat...@ovirt.org has posted comments on this change.
Change subject: register: Pull some vars into the class
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: register: Fix certificate validation
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: register: Drop CA path redundancies
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
automat...@ovirt.org has posted comments on this change.
Change subject: register: Leave the logging to the vdsm-tool
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Roman Mohr has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 14: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42035/14/vdsm/virt/hoststats.py
File vdsm/virt
Roman Mohr has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42035/13/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Roman Mohr has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42035/13/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Roman Mohr has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 14: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42034/14//COMMIT_MSG
Commit Message:
Lin
Francesco Romani has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/45954/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add retry logic for incoming limit
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Fabian Deutsch has uploaded a new change for review.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
vdsm-tool: Ensure that the vdsm uuid is a string
Change-Id: I3c1f341dd66a468cf704158789e158f6d61f1d98
Signe
automat...@ovirt.org has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45954/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46788
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/3/vdsm/API.py
File vdsm/API.py:
Line 571: :ty
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1273
Martin Polednik has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46788
To unsubscribe, visit h
Francesco Romani has posted comments on this change.
Change subject: sampling: add 'ncpus' property to HostSample
..
Patch Set 14: Verified+1
verified with 42034 running patched VDSM and checking from time to time the
output o
Francesco Romani has posted comments on this change.
Change subject: sampling: move translation code into hoststats.py
..
Patch Set 14: Verified+1
verified with 42035 running patched VDSM and checking from time to time the
out
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 2:
No longer warns about unknown devices for channel devices
--
To view, visit https://
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/46788
To unsubscribe, visit htt
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1128881::ERROR, priv
Martin Polednik has posted comments on this change.
Change subject: virt: Don't warn about unknown type for channel devices
..
Patch Set 1: Code-Review+1
As discussed earlier a nice logs cleanup
--
To view, visit https://gerr
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2//COMMIT_MSG
Commit Message:
Line 9: It seems th
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43746/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When we re
Francesco Romani has posted comments on this change.
Change subject: tests: fixed mangled names in crossImportTests
..
Patch Set 2: Verified+1
rebased and fixed the commit message -> copied score
--
To view, visit https://ger
automat...@ovirt.org has posted comments on this change.
Change subject: tests: fixed mangled names in crossImportTests
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Yaniv Bronhaim has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2//COMMIT_MSG
Commit Message:
Line 9: It seems that
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43746/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When we rece
Francesco Romani has posted comments on this change.
Change subject: faqemu: refactor and update
..
Patch Set 5: Code-Review+1
(1 comment)
initial review. Looks really nice!
https://gerrit.ovirt.org/#/c/46961/5/vdsm_hooks/faq
Francesco Romani has posted comments on this change.
Change subject: vdsm: isolate fake_kvm into a hook
..
Patch Set 4: Code-Review+1
(3 comments)
looks good, only few comments/questions inside
https://gerrit.ovirt.org/#/c/46
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 7: Code-Review+1
(7 comments)
looks good. Few minor comments and questions inside
https://gerrit.ovirt.org/#/c/4
Francesco Romani has posted comments on this change.
Change subject: nettestlib: add ppc64le TUNSETIFF value
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46955
To unsubscribe, visit https://gerrit.o
96 matches
Mail list logo
