Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-29 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 10: Code-Review-1 debian/vdsm-python.install would probably like kernelconfig.py, too. -- To

Change in vdsm[master]: shell helper: typo

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: shell helper: typo .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: shell helper: typo

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: shell helper: typo .. shell helper: typo Change-Id: I43384a95c8334c3d9ac9258224e3091932d882b8 Signed-off-by: Ido Barkan

Change in vdsm[master]: core: Fix makefile

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: core: Fix makefile .. Patch Set 2: Code-Review-1 wrong branch? 11:47:04 make[2]: *** No rule to make target 'testSRiovVm.xml', needed by 'all-am'. Stop.

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 2: * #1282187::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1282187::OK, public bug *

Change in vdsm[master]: netinfo: assess DHCP on devices from DHCP client processes

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from DHCP client processes .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: netinfo: assess DHCP on devices from DHCP client processes

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: assess DHCP on devices from DHCP client processes .. Patch Set 7: Code-Review-1 would you be kind to rebase your patch on top of Ido's

Change in vdsm[master]: monitor: Do not release host id during shutdown

2015-11-29 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: monitor: Do not release host id during shutdown .. monitor: Do not release host id during shutdown When shutting down, all domain monitors are stopped and release

Change in vdsm[master]: monitor: Do not release host id during shutdown

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: * #1269768::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269768::OK, public bug *

Change in vdsm[master]: netinfo: assess DHCP on devices from DHCP client processes

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from DHCP client processes .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sp: Allow attaching of monitored domain

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 2: * #1269768::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269768::OK, public bug * Check

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

2015-11-29 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: hsm: Prevent stop monitoring of a pool domain .. hsm: Prevent stop monitoring of a pool domain When hosted engine agent is entering local maintenance, it must

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 1: * #1282187::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1282187::OK, public bug *

Change in vdsm[master]: ifcfg: remove files properly on the node

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 2: * #1283628::Update tracker: OK * Set MODIFIED::bug 1283628#1283628OK -- To view, visit

Change in vdsm[master]: ifcfg: remove files properly on the node

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48841 To unsubscribe, visit

Change in vdsm[master]: ifcfg: remove files properly on the node

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: ifcfg: remove files properly on the node .. ifcfg: remove files properly on the node Since change-id I02ae28c345 we are always persisting ifcfg files

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 154:

Change in vdsm[ovirt-3.6]: ifcfg: remove files properly on the node

2015-11-29 Thread sshnaidm
Sagi Shnaidman has uploaded a new change for review. Change subject: ifcfg: remove files properly on the node .. ifcfg: remove files properly on the node Since change-id I02ae28c345 we are always persisting ifcfg files on the

Change in vdsm[ovirt-3.6]: ifcfg: remove files properly on the node

2015-11-29 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49373 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49223 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: ifcfg: remove files properly on the node

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: * #1283628::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283628::OK, public bug * Check

Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49217 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 5: Ala, please check why jenkins fails, commment here if it is not relevant to this patch, and report to

Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 4: Check jenkins failures, verify. -- To view, visit https://gerrit.ovirt.org/49223 To unsubscribe, visit

Change in vdsm[master]: build: Fix --disable-gluster-mgmt

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Fix --disable-gluster-mgmt .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: build: Make with_hooks condition more clear

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: Make with_hooks condition more clear .. build: Make with_hooks condition more clear Use simple if instead of cryptic parameter expansion

Change in vdsm[master]: build: Make with_hooks condition more clear

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: Make with_hooks condition more clear .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49345 To unsubscribe, visit

Change in vdsm[master]: build: Make with_hooks condition more clear

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Make with_hooks condition more clear .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: build: Fix --disable-gluster-mgmt

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: Fix --disable-gluster-mgmt .. build: Fix --disable-gluster-mgmt The automake condition was correct only when the feature is disabled by

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: split netinfo module

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: net: move network library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move network library under lib/vdsm .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: move tc library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move tc library under lib/vdsm .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Show debug message before action

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Show debug message before action .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49170/4/lib/vdsm/netinfo.py File

Change in vdsm[master]: build: Cleanup conditionals in the build system

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 20: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/48446 To unsubscribe,

Change in vdsm[master]: build: Cleanup conditionals in the build system

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: build: Cleanup conditionals in the build system

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: Cleanup conditionals in the build system .. build: Cleanup conditionals in the build system Previously builders had to edit the spec manually

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-29 Thread bkorren
Barak Korren has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/49001 To unsubscribe,

Change in vdsm[ovirt-3.6]: ifcfg: remove files properly on the node

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49373 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: add logs during the recovery .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49140 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: tests: Disable flaky test

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Disable flaky test .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49166 To unsubscribe, visit

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49001 To unsubscribe,

Change in vdsm[master]: Add environment variable to scan alignment calls

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Add environment variable to scan alignment calls .. Patch Set 3: Why is this not good enough for now? -- To view, visit https://gerrit.ovirt.org/40402 To

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-29 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: contrib script to build for rhev with the required flags .. build: contrib script to build for rhev with the required flags Change-Id:

Change in vdsm[master]: Add environment variable to scan alignment calls

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Add environment variable to scan alignment calls .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40402/3/vdsm/alignmentScan.py File

Change in vdsm[master]: shell helper: typo

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: shell helper: typo .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49206 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: shell-helper: stop using service command

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: shell-helper: stop using service command .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49215 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: tests: Disable flaky test

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: tests: Disable flaky test .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49166 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: Flatten KernelConfig logic

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: Flatten KernelConfig logic .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/48893 To unsubscribe, visit

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/48824 To unsubscribe, visit

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/49170 To unsubscribe, visit

Change in vdsm[master]: net: move tc library under lib/vdsm

2015-11-29 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: move tc library under lib/vdsm .. Patch Set 1: part of Petr's aesthetic remarks were fixed. -- To view, visit https://gerrit.ovirt.org/49238 To unsubscribe,

Change in vdsm[master]: net: Flatten KernelConfig logic

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Flatten KernelConfig logic .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: move tc library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move tc library under lib/vdsm .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: move network library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move network library under lib/vdsm .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: split netinfo module

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/48672/7/vdsm/v2v.py File vdsm/v2v.py: Line 154: #

Change in vdsm[master]: Adding python3 run for nosetests

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Moving panic function to separate module

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Moving panic function to separate module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Moving panic function to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Moving panic function to separate module .. Moving panic function to separate module Taking panic out of utils allows to mock panic in testrunner without

Change in vdsm[master]: Moving modprobe operations to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving modprobe operations to separate module .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49349 To unsubscribe, visit

Change in vdsm[master]: Moving panic function to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving panic function to separate module .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49351 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49205 To unsubscribe, visit

Change in vdsm[master]: Moving modprobe operations to separate module

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Moving modprobe operations to separate module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Moving modprobe operations to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Moving modprobe operations to separate module .. Moving modprobe operations to separate module that way we won't need to import utils each testValidation

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

2015-11-29 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 6: > (1 comment) The different between the old and the new api is: 1. the new return all up and down VMs in one

Change in vdsm[master]: Moving panic function to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving panic function to separate module .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49351/1/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48824 To unsubscribe, visit

Change in vdsm[master]: Moving modprobe operations to separate module

2015-11-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Moving modprobe operations to separate module .. Patch Set 1: Code-Review-1 Nice, but this is private test helper, we dont publish it in the vdsm library. Does it

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

2015-11-29 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: I verified on rhel 7.2. Regarding the epoch, it works also without it. We can fix it in master, I

Change in vdsm[master]: shell-helper: stop using service command

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: shell-helper: stop using service command .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49215 To unsubscribe, visit

Change in vdsm[master]: Moving panic function to separate module

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Moving panic function to separate module .. Patch Set 1: -Verified -- To view, visit https://gerrit.ovirt.org/49351 To unsubscribe, visit

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

2015-11-29 Thread smelamud
Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Correct VM state before vm.cont() in _recover() .. Patch Set 2: ping -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit

Change in vdsm[master]: host stats: Collect stats from online cpu cores only

2015-11-29 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 13: Roy, Martin - seems like SLA stuff, please review -- To view, visit

Change in vdsm[master]: ifcfg: remove files properly on the node

2015-11-29 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Code-Review+1 Tested -- To view, visit https://gerrit.ovirt.org/48841 To unsubscribe, visit

Change in vdsm[master]: ifcfg: remove files properly on the node

2015-11-29 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48841 To unsubscribe, visit

Change in vdsm[master]: Print debug message before action

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Print debug message before action .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Print debug message before action

2015-11-29 Thread sshnaidm
Sagi Shnaidman has uploaded a new change for review. Change subject: Print debug message before action .. Print debug message before action Print debug message about removing the file If it's after - we won't know about what is

Change in vdsm[master]: spec: Require ioprocess containing important fixes

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require ioprocess containing important fixes .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Print debug message before action

2015-11-29 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Print debug message before action .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49368 To unsubscribe, visit

Change in vdsm[master]: build: Fix --disable-gluster-mgmt

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: build: Fix --disable-gluster-mgmt .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49344 To unsubscribe, visit

Change in vdsm[master]: build: Make with_hooks condition more clear

2015-11-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: build: Make with_hooks condition more clear .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49345 To unsubscribe, visit

Change in vdsm[master]: build: Fix --disable-gluster-mgmt

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: build: Fix --disable-gluster-mgmt .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49344 To unsubscribe, visit

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/49170/4/lib/vdsm/netinfo.py File

Change in vdsm[master]: core: Fix makefile

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: core: Fix makefile .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: core: Fix makefile

2015-11-29 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: core: Fix makefile .. core: Fix makefile Fixed Makefile to copy testSRiovVm.xml to build directory. This missing file causes test_sriov_vm to fail on branch 3.6

Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the

Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the

Change in vdsm[ovirt-3.6]: gluster: Remove duplicate servers

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 5: -Verified * #1286428::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1286428::OK, public bug *

Change in vdsm[ovirt-3.6]: gluster: Fix unit test docstring

2015-11-29 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: gluster: Fix unit test docstring .. Patch Set 4: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view,

Change in vdsm[master]: net: move tc library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move tc library under lib/vdsm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: move network library under lib/vdsm

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move network library under lib/vdsm .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

  1   2   >